sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC issues

Browse Source 
1. Separate variable definition and initialization.
2. Make the variable naming following Edk2 rule.

V2: Remove the updates of guard macros in header files.

Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Evan Lloyd <evan.lloyd@arm.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
This commit is contained in:
Dandan Bi
2018-06-05 09:20:05 +08:00
committed by Eric Dong
parent a6eaba4d7f
commit f75c747828
14 changed files with 178 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c
View File

@ -45,32 +45,32 @@ RegisterParser (
IN PARSE_ACPI_TABLE_PROC ParserProc
)
{
UINT32 index;
UINT32 Index;
if ((ParserProc == NULL) || (Signature == ACPI_PARSER_SIGNATURE_NULL)) {
return EFI_INVALID_PARAMETER;
}
// Search if a parser is already installed
for (index = 0;
index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
index++)
for (Index = 0;
Index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
Index++)
{
if (Signature == mTableParserList[index].Signature) {
if (mTableParserList[index].Parser != NULL) {
if (Signature == mTableParserList[Index].Signature) {
if (mTableParserList[Index].Parser != NULL) {
return EFI_ALREADY_STARTED;
}
}
}
// Find the first free slot and register the parser
for (index = 0;
index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
index++)
for (Index = 0;
Index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
Index++)
{
if (mTableParserList[index].Signature == ACPI_PARSER_SIGNATURE_NULL) {
mTableParserList[index].Signature = Signature;
mTableParserList[index].Parser = ParserProc;
if (mTableParserList[Index].Signature == ACPI_PARSER_SIGNATURE_NULL) {
mTableParserList[Index].Signature = Signature;
mTableParserList[Index].Parser = ParserProc;
return EFI_SUCCESS;
}
}
@ -96,19 +96,19 @@ DeregisterParser (
IN UINT32 Signature
)
{
UINT32 index;
UINT32 Index;
if (Signature == ACPI_PARSER_SIGNATURE_NULL) {
return EFI_INVALID_PARAMETER;
}
for (index = 0;
index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
index++)
for (Index = 0;
Index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
Index++)
{
if (Signature == mTableParserList[index].Signature) {
mTableParserList[index].Signature = ACPI_PARSER_SIGNATURE_NULL;
mTableParserList[index].Parser = NULL;
if (Signature == mTableParserList[Index].Signature) {
mTableParserList[Index].Signature = ACPI_PARSER_SIGNATURE_NULL;
mTableParserList[Index].Parser = NULL;
return EFI_SUCCESS;
}
}
@ -137,18 +137,18 @@ GetParser (
OUT PARSE_ACPI_TABLE_PROC * ParserProc
)
{
UINT32 index;
UINT32 Index;
if ((ParserProc == NULL) || (Signature == ACPI_PARSER_SIGNATURE_NULL)) {
return EFI_INVALID_PARAMETER;
}
for (index = 0;
index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
index++)
for (Index = 0;
Index < (sizeof (mTableParserList) / sizeof (mTableParserList[0]));
Index++)
{
if (Signature == mTableParserList[index].Signature) {
*ParserProc = mTableParserList[index].Parser;
if (Signature == mTableParserList[Index].Signature) {
*ParserProc = mTableParserList[Index].Parser;
return EFI_SUCCESS;
}
}