From f784fc0e39f9837dc409aa4f776bcd80e88e925f Mon Sep 17 00:00:00 2001 From: YuanhaoXie Date: Mon, 11 Sep 2023 18:57:48 +0800 Subject: [PATCH] UefiCpuPkg/MtrrUnitTest: Update UnitTestGetFirmwareVariableMtrrCount. Update UnitTestGetFirmwareVariableMtrrCount for the case the when Fixed MTRRs are not supported. The original implementation returns FALSE when either fixed MTRR isn't supported or the number of variable MTRRs is 0. The correct behavior should return FALSE only when both fixed MTRR isn't supported and the number of variable MTRRs is 0. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Reviewed-by: Eric Dong Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c b/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c index ac18d9d25d..75ae4d65b9 100644 --- a/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c +++ b/UefiCpuPkg/Library/MtrrLib/UnitTest/MtrrLibUnitTest.c @@ -550,7 +550,7 @@ UnitTestGetFirmwareVariableMtrrCount ( InitializeMtrrRegs (&SystemParameter); PatchPcdSet32 (PcdCpuNumberOfReservedVariableMtrrs, 2); Result = GetFirmwareVariableMtrrCount (); - UT_ASSERT_EQUAL (Result, 0); + UT_ASSERT_EQUAL (Result, SystemParameter.VariableMtrrCount - 2); // // Expect ASSERT() if variable MTRR count is > MTRR_NUMBER_OF_VARIABLE_MTRR