sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RedfishPkg/RedfishDiscoverDxe: remove Redfish false alarm

Browse Source 
- It is expected that caller receives EFI_NO_MAPPING status
when call issues Configure() to unconfigured network interface.
Remove this false alarm in GetSubnetInfo() function.
- Fix typos

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
This commit is contained in:
Nickle Wang
2023-10-23 20:40:42 +08:00
committed by mergify[bot]
parent da73578bf7
commit fb044b7fe8
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
View File

@@ -198,13 +198,17 @@ Tcp4GetSubnetInfo (
Tcp4Option.EnableNagle = TRUE; Tcp4Option.EnableNagle = TRUE;
Status = Tcp4->Configure (Tcp4, &Tcp4CfgData); Status = Tcp4->Configure (Tcp4, &Tcp4CfgData);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information\n", __func__)); if (Status == EFI_NO_MAPPING) {
return EFI_SUCCESS;
}
DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information: %r\n", __func__, Status));
return Status; return Status;
} }
Status = Tcp4->GetModeData (Tcp4, NULL, NULL, &IpModedata, NULL, NULL); Status = Tcp4->GetModeData (Tcp4, NULL, NULL, &IpModedata, NULL, NULL);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __func__)); DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information: %r\n", __func__, Status));
return Status; return Status;
} }
@@ -267,7 +271,7 @@ Tcp6GetSubnetInfo (
ZeroMem ((VOID *)&IpModedata, sizeof (EFI_IP6_MODE_DATA)); ZeroMem ((VOID *)&IpModedata, sizeof (EFI_IP6_MODE_DATA));
Status = Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL); Status = Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL);
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __func__)); DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information: %r\n", __func__, Status));
return Status; return Status;
} }
@@ -1002,13 +1006,13 @@ NetworkInterfaceGetSubnetInfo (
Instance Instance
); );
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet infomation.\n", __func__)); DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet information.\n", __func__));
return Status; return Status;
} else { } else {
DEBUG ((DEBUG_MANAGEABILITY, "%a:MAC address: %s\n", __func__, Instance->StrMacAddr)); DEBUG ((DEBUG_MANAGEABILITY, "%a:MAC address: %s\n", __func__, Instance->StrMacAddr));
if (CheckIsIpVersion6 (Instance)) { if (CheckIsIpVersion6 (Instance)) {
if (Instance->SubnetAddrInfoIPv6Number == 0) { if (Instance->SubnetAddrInfoIPv6Number == 0) {
DEBUG ((DEBUG_ERROR, "%a: There is no Subnet infomation for IPv6 network interface.\n", __func__)); DEBUG ((DEBUG_WARN, "%a: There is no Subnet information for IPv6 network interface.\n", __func__));
return EFI_NOT_FOUND; return EFI_NOT_FOUND;
} }
@@ -1554,7 +1558,7 @@ TestForRequiredProtocols (
); );
if (EFI_ERROR (Status)) { if (EFI_ERROR (Status)) {
if (Index == ListCount - 1) { if (Index == ListCount - 1) {
DEBUG ((DEBUG_ERROR, "%a: all required protocols are found on this controller handle: %p.\n", __func__, ControllerHandle)); DEBUG ((DEBUG_INFO, "%a: all required protocols are found on this controller handle: %p.\n", __func__, ControllerHandle));
return EFI_SUCCESS; return EFI_SUCCESS;
} }
} }