sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MdePkg: Fix OUT parameters marked as IN OUT

Browse Source 
Some OUT parameters in the specification were mistakenly marked as IN OUT.
"IN OUT" replaced with "OUT" in the following interfaces

EFI_BOOT_SERVICES.GetMemoryMap():MemoryMap
EFI_BOOT_SERVICES.LocateHandleBuffer():NoHandles
EFI_SIMPLE_POINTER_PROTOCOL.GetState():State
EFI_ABSOLUTE_POINTER_PROTOCOL.GetState():State
EFI_EDID_OVERRIDE_PROTOCOL.GetEdid():EdidSize and Edid
EFI_ATA_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_SD_MMC_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_EXT_SCSI_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath
EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():Image
(UEFI 2.8 errata a, mantis 2035)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
This commit is contained in:
Oleksiy Yakovlev
2020-05-15 04:51:41 +08:00
committed by mergify[bot]
parent 5af8fccd26
commit ff95c0fcba
9 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
MdePkg/Include/Protocol/AbsolutePointer.h
View File

@@ -169,7 +169,7 @@ typedef
EFI_STATUS EFI_STATUS
(EFIAPI *EFI_ABSOLUTE_POINTER_GET_STATE)( (EFIAPI *EFI_ABSOLUTE_POINTER_GET_STATE)(
IN EFI_ABSOLUTE_POINTER_PROTOCOL *This, IN EFI_ABSOLUTE_POINTER_PROTOCOL *This,
IN OUT EFI_ABSOLUTE_POINTER_STATE *State OUT EFI_ABSOLUTE_POINTER_STATE *State
); );

4
MdePkg/Include/Protocol/AtaPassThru.h
View File

@@ -315,7 +315,7 @@ EFI_STATUS
@param[in] PortMultiplierPort The port multiplier port number of the ATA device for which a @param[in] PortMultiplierPort The port multiplier port number of the ATA device for which a
device path node is to be allocated and built. If there is no device path node is to be allocated and built. If there is no
port multiplier, then specify 0xFFFF. port multiplier, then specify 0xFFFF.
@param[in,out] DevicePath A pointer to a single device path node that describes the ATA @param[out] DevicePath A pointer to a single device path node that describes the ATA
device specified by Port and PortMultiplierPort. This function device specified by Port and PortMultiplierPort. This function
is responsible for allocating the buffer DevicePath with the is responsible for allocating the buffer DevicePath with the
boot service AllocatePool(). It is the caller's responsibility boot service AllocatePool(). It is the caller's responsibility
@@ -334,7 +334,7 @@ EFI_STATUS
IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN EFI_ATA_PASS_THRU_PROTOCOL *This,
IN UINT16 Port, IN UINT16 Port,
IN UINT16 PortMultiplierPort, IN UINT16 PortMultiplierPort,
IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath
); );
/** /**

4
MdePkg/Include/Protocol/EdidOverride.h
View File

@@ -44,8 +44,8 @@ EFI_STATUS
IN EFI_EDID_OVERRIDE_PROTOCOL *This, IN EFI_EDID_OVERRIDE_PROTOCOL *This,
IN EFI_HANDLE *ChildHandle, IN EFI_HANDLE *ChildHandle,
OUT UINT32 *Attributes, OUT UINT32 *Attributes,
IN OUT UINTN *EdidSize, OUT UINTN *EdidSize,
IN OUT UINT8 **Edid OUT UINT8 **Edid
); );
/// ///

4
MdePkg/Include/Protocol/FirmwareManagement.h
View File

@@ -345,7 +345,7 @@ EFI_STATUS
@param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance. @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
@param[in] ImageIndex A unique number identifying the firmware image(s) within the device. @param[in] ImageIndex A unique number identifying the firmware image(s) within the device.
The number is between 1 and DescriptorCount. The number is between 1 and DescriptorCount.
@param[in, out] Image Points to the buffer where the current image is copied to. @param[out] Image Points to the buffer where the current image is copied to.
@param[in, out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes. @param[in, out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes.
On return, points to the length of the image, in bytes. On return, points to the length of the image, in bytes.
@@ -364,7 +364,7 @@ EFI_STATUS
(EFIAPI *EFI_FIRMWARE_MANAGEMENT_PROTOCOL_GET_IMAGE)( (EFIAPI *EFI_FIRMWARE_MANAGEMENT_PROTOCOL_GET_IMAGE)(
IN EFI_FIRMWARE_MANAGEMENT_PROTOCOL *This, IN EFI_FIRMWARE_MANAGEMENT_PROTOCOL *This,
IN UINT8 ImageIndex, IN UINT8 ImageIndex,
IN OUT VOID *Image, OUT VOID *Image,
IN OUT UINTN *ImageSize IN OUT UINTN *ImageSize
); );

4
MdePkg/Include/Protocol/NvmExpressPassthru.h
View File

@@ -214,7 +214,7 @@ EFI_STATUS
@param[in] NamespaceId The NVM Express namespace ID for which a device path node is to be @param[in] NamespaceId The NVM Express namespace ID for which a device path node is to be
allocated and built. Caller must set the NamespaceId to zero if the allocated and built. Caller must set the NamespaceId to zero if the
device path node will contain a valid UUID. device path node will contain a valid UUID.
@param[in,out] DevicePath A pointer to a single device path node that describes the NVM Express @param[out] DevicePath A pointer to a single device path node that describes the NVM Express
namespace specified by NamespaceId. This function is responsible for namespace specified by NamespaceId. This function is responsible for
allocating the buffer DevicePath with the boot service AllocatePool(). allocating the buffer DevicePath with the boot service AllocatePool().
It is the caller's responsibility to free DevicePath when the caller It is the caller's responsibility to free DevicePath when the caller
@@ -231,7 +231,7 @@ EFI_STATUS
(EFIAPI *EFI_NVM_EXPRESS_PASS_THRU_BUILD_DEVICE_PATH)( (EFIAPI *EFI_NVM_EXPRESS_PASS_THRU_BUILD_DEVICE_PATH)(
IN EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL *This, IN EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL *This,
IN UINT32 NamespaceId, IN UINT32 NamespaceId,
IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath
); );
/** /**

2
MdePkg/Include/Protocol/ScsiPassThruExt.h
View File

@@ -259,7 +259,7 @@ EFI_STATUS
IN EFI_EXT_SCSI_PASS_THRU_PROTOCOL *This, IN EFI_EXT_SCSI_PASS_THRU_PROTOCOL *This,
IN UINT8 *Target, IN UINT8 *Target,
IN UINT64 Lun, IN UINT64 Lun,
IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath
); );
/** /**

4
MdePkg/Include/Protocol/SdMmcPassThru.h
View File

@@ -164,7 +164,7 @@ EFI_STATUS
@param[in] This A pointer to the EFI_SD_MMMC_PASS_THRU_PROTOCOL instance. @param[in] This A pointer to the EFI_SD_MMMC_PASS_THRU_PROTOCOL instance.
@param[in] Slot Specifies the slot number of the SD card for which a device @param[in] Slot Specifies the slot number of the SD card for which a device
path node is to be allocated and built. path node is to be allocated and built.
@param[in,out] DevicePath A pointer to a single device path node that describes the SD @param[out] DevicePath A pointer to a single device path node that describes the SD
card specified by Slot. This function is responsible for card specified by Slot. This function is responsible for
allocating the buffer DevicePath with the boot service allocating the buffer DevicePath with the boot service
AllocatePool(). It is the caller's responsibility to free AllocatePool(). It is the caller's responsibility to free
@@ -182,7 +182,7 @@ EFI_STATUS
(EFIAPI *EFI_SD_MMC_PASS_THRU_BUILD_DEVICE_PATH) ( (EFIAPI *EFI_SD_MMC_PASS_THRU_BUILD_DEVICE_PATH) (
IN EFI_SD_MMC_PASS_THRU_PROTOCOL *This, IN EFI_SD_MMC_PASS_THRU_PROTOCOL *This,
IN UINT8 Slot, IN UINT8 Slot,
IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath
); );
/** /**

2
MdePkg/Include/Protocol/SimplePointer.h
View File

@@ -109,7 +109,7 @@ typedef
EFI_STATUS EFI_STATUS
(EFIAPI *EFI_SIMPLE_POINTER_GET_STATE)( (EFIAPI *EFI_SIMPLE_POINTER_GET_STATE)(
IN EFI_SIMPLE_POINTER_PROTOCOL *This, IN EFI_SIMPLE_POINTER_PROTOCOL *This,
IN OUT EFI_SIMPLE_POINTER_STATE *State OUT EFI_SIMPLE_POINTER_STATE *State
); );
/// ///

8
MdePkg/Include/Uefi/UefiSpec.h
View File

@@ -211,7 +211,7 @@ EFI_STATUS
On output, it is the size of the buffer returned by the firmware if On output, it is the size of the buffer returned by the firmware if
the buffer was large enough, or the size of the buffer needed to contain the buffer was large enough, or the size of the buffer needed to contain
the map if the buffer was too small. the map if the buffer was too small.
@param[in, out] MemoryMap A pointer to the buffer in which firmware places the current memory @param[out] MemoryMap A pointer to the buffer in which firmware places the current memory
map. map.
@param[out] MapKey A pointer to the location in which firmware returns the key for the @param[out] MapKey A pointer to the location in which firmware returns the key for the
current memory map. current memory map.
@@ -232,7 +232,7 @@ typedef
EFI_STATUS EFI_STATUS
(EFIAPI *EFI_GET_MEMORY_MAP)( (EFIAPI *EFI_GET_MEMORY_MAP)(
IN OUT UINTN *MemoryMapSize, IN OUT UINTN *MemoryMapSize,
IN OUT EFI_MEMORY_DESCRIPTOR *MemoryMap, OUT EFI_MEMORY_DESCRIPTOR *MemoryMap,
OUT UINTN *MapKey, OUT UINTN *MapKey,
OUT UINTN *DescriptorSize, OUT UINTN *DescriptorSize,
OUT UINT32 *DescriptorVersion OUT UINT32 *DescriptorVersion
@@ -1556,7 +1556,7 @@ EFI_STATUS
@param[in] Protocol Provides the protocol to search by. @param[in] Protocol Provides the protocol to search by.
This parameter is only valid for a SearchType of ByProtocol. This parameter is only valid for a SearchType of ByProtocol.
@param[in] SearchKey Supplies the search key depending on the SearchType. @param[in] SearchKey Supplies the search key depending on the SearchType.
@param[in, out] NoHandles The number of handles returned in Buffer. @param[out] NoHandles The number of handles returned in Buffer.
@param[out] Buffer A pointer to the buffer to return the requested array of handles that @param[out] Buffer A pointer to the buffer to return the requested array of handles that
support Protocol. support Protocol.
@@ -1574,7 +1574,7 @@ EFI_STATUS
IN EFI_LOCATE_SEARCH_TYPE SearchType, IN EFI_LOCATE_SEARCH_TYPE SearchType,
IN EFI_GUID *Protocol, OPTIONAL IN EFI_GUID *Protocol, OPTIONAL
IN VOID *SearchKey, OPTIONAL IN VOID *SearchKey, OPTIONAL
IN OUT UINTN *NoHandles, OUT UINTN *NoHandles,
OUT EFI_HANDLE **Buffer OUT EFI_HANDLE **Buffer
); );