Gary Lin
d6224153d7
SecurityPkg/SecureBootConfigDxe: Remove type casting from the ChooseFile handlers
...
The type casting in the ChooseFile is not necessary and it actually
hid the incompatible handlers from the compiler.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin <glin@suse.com >
Reviewed-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Dandan Bi <dandan.bi@intel.com >
2016-03-24 09:26:49 +01:00
Zhang, Chao B
abffadf0ec
SecurityPkg: SecureBootConfigDxe: Update coding style
...
Update code to follow EDK2 coding style.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang<chao.b.zhang@intel.com >
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com >
2016-03-11 12:28:01 +08:00
Dandan Bi
762d8ddb28
SecurityPkg: Use FileExplorerLib in SecureBootConfigDxe
...
Using existing library FileExplorerLib to replace the same
logic in SecureBootConfigDxe to make the code clear. After using
FileExplorerLib, the UI behavior for enroll PK will change,
previously when select one PK file, commit/discard changes will
return to Device Manager,press ESC will return to FileExplorer.
Now using FileExplorerLib the behavior will keep same with
enroll KEK/DB/..., commit/discard changes will return to Custom
Secure Boot Options form and ESC will return to PK options form.
Cc: Chao Zhang <chao.b.zhang@intel.com >
Cc: Eric Dong <eric.dong@intel.com >
Cc: Laszlo Ersek <lersek@redhat.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com >
Acked-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com >
2016-02-26 16:52:51 +08:00
Chao Zhang
e8cd9b8041
SecurityPkg: SecureBootConfigDxe: Fix potential NULL pointer dereference
...
Fix SecureBoot potential NULL pointer dereference.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19751 6f19259b-4bc3-4df7-8a09-765794883524
2016-01-27 02:46:51 +00:00
Chao Zhang
623538ff98
SecurityPkg: SecureBootConfigDxe: Fix string typo
...
Fix secure boot mode transition string typo.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by: Qin Long <qin.long@intel.com >
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19646 6f19259b-4bc3-4df7-8a09-765794883524
2016-01-15 05:26:04 +00:00
Chao Zhang
02dd6af921
SecurityPkg: SecureBootConfigDxe: Enhance secure boot string update logic
...
ExtractConfig is called many times, so it's not efficient to update Secure Boot STR_SECURE_BOOT_STATE_CONTENT, STR_CUR_SECURE_BOOT_MODE_CONTENT string in ExtractConfig.
As these 2 strings are displayed on one form, always update them when opening the form.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19645 6f19259b-4bc3-4df7-8a09-765794883524
2016-01-15 01:06:51 +00:00
Chao Zhang
96832eefea
SecurityPkg: SecureBootConfigDxe: SecureBoot UI for Customized SecureBoot Mode
...
Add SecureBoot UI support for Customized SecureBoot Mode transition according to Mantis 1263. User can do secure boot mode transition through UI.
https://mantis.uefi.org/mantis/view.php?id=1263
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by: Zeng Star <star.zeng@intel.com >
Reviewed-by: Long Qin <qin.long@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19134 6f19259b-4bc3-4df7-8a09-765794883524
2015-12-07 06:20:36 +00:00
Ard Biesheuvel
a16170a110
SecurityPkg: Update SecureBootConfigDxe to support ARM image
...
Update SecureBootConfigDxe component to allow the enrollment of
the digests of EFI executable that are built for ARM or AARCH64.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17406 6f19259b-4bc3-4df7-8a09-765794883524
2015-05-11 06:37:03 +00:00
Shumin Qiu
69f8bb5288
SecurityPkg: Fix typo.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17047 6f19259b-4bc3-4df7-8a09-765794883524
2015-03-13 08:25:27 +00:00
Long, Qin
12d95665cb
Correct the Hash Calculation for Revoked X.509 Certificate to align with RFC3280 and UEFI 2.4 Spec.
...
This patch added one new X509GetTBSCert() interface in BaseCryptLib to retrieve the TBSCertificate,
and also corrected the hash calculation for revoked certificate to aligned the RFC3280 and UEFI 2.4 spec.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: "Long, Qin" <qin.long@intel.com >
Reviewed-by: "Dong, Guo" <guo.dong@initel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16559 6f19259b-4bc3-4df7-8a09-765794883524
2014-12-25 08:37:08 +00:00
Qin Long
20333c6d56
UEFI 2.4 X509 Certificate Hash and RFC3161 Timestamp Verification support for Secure Boot
...
Main ChangeLogs includes:
1. Introduce the new GUID and structure definitions for certificate hash and timestamp support;
2. Update Image Verification Library to support DBT signature checking;
3. Update the related SecureBoot Configuration Pages;
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long <qin.long@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16380 6f19259b-4bc3-4df7-8a09-765794883524
2014-11-14 08:41:12 +00:00
Chao Zhang
33985e3b52
Fix execution status & DEBUG message level mismatch. EFI_D_ERROR is used only when failure/case can’t be resolved by code.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16320 6f19259b-4bc3-4df7-8a09-765794883524
2014-11-10 05:01:15 +00:00
Eric Dong
c93bcb7ef4
Return to BMM page if parse the file info failed.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15067 6f19259b-4bc3-4df7-8a09-765794883524
2014-01-09 05:59:53 +00:00
Fu Siyuan
742d9b3a38
Refine the Secure Boot UI driver to input the GUID and varstroe name when using HiiSetBrowserData/HiiGetBrowserData.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong, Eric <eric.dong@intel.com >
Reviewed-by: Dong, Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14897 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-25 06:40:34 +00:00
Fu Siyuan
a365eed476
Fix a bug in secure boot configuration driver: Enroll DB/KEK will disable Attempt Secure Boot option.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14590 6f19259b-4bc3-4df7-8a09-765794883524
2013-08-22 09:46:03 +00:00
Gary Ching-Pang Lin
fd64f84f23
Checks the length of the file name to avoid illegal access.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Ching-Pang Lin <glin@suse.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14531 6f19259b-4bc3-4df7-8a09-765794883524
2013-08-08 02:41:37 +00:00
sfu5
ee79ac8d0e
Pop up error message when user tries to enroll an invalid certificate file into KEK/DB/DBX.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Yao Jiewen <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14373 6f19259b-4bc3-4df7-8a09-765794883524
2013-05-17 07:03:49 +00:00
sfu5
a2f2c258d4
Update secure boot UI driver to handle “reset to default” hot key.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Yao Jiewen <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14257 6f19259b-4bc3-4df7-8a09-765794883524
2013-04-12 01:44:54 +00:00
sfu5
b7d269eae1
Fix infinite loop bug in secure boot UI driver.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14082 6f19259b-4bc3-4df7-8a09-765794883524
2013-01-25 02:01:47 +00:00
sfu5
f71ed839e1
1. Set the secure boot state to Standard Mode when user leaving secure boot setup page.
...
2. Add “Current SecureBoot State” field to reflect current secure boot status of the platform.
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Yao Jiewen <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14042 6f19259b-4bc3-4df7-8a09-765794883524
2013-01-09 05:19:43 +00:00
sfu5
0357efe3f5
Add a dialog box with help message when user changes the state of "Attempt Secure Boot" check box.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13733 6f19259b-4bc3-4df7-8a09-765794883524
2012-09-14 07:28:37 +00:00
sfu5
e4d7370d18
Update the secure boot configuration UI to accept *.crt certificate file.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13546 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-23 01:03:53 +00:00
sfu5
cf7409f228
Update the secure boot configuration UI to accept *.der certificate file as the Platform Key.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13525 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-12 01:09:00 +00:00
sfu5
0fb450fb3e
Reset the platform when user choose to enroll/delete the PK variable.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13515 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-09 09:17:00 +00:00
sfu5
8f8ca22e59
1. Reset system when user changes secure boot state in secure boot configuration form.
...
2. Update the method to detect secure boot state in DxeImageVerificationLib and secure boot configuration driver.
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13505 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-05 08:08:12 +00:00
sfu5
de2447dd4c
Fix compatibility issue when using IPF image with PE32 magic value in the OptionalHeader.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13433 6f19259b-4bc3-4df7-8a09-765794883524
2012-06-08 02:09:48 +00:00
ydong10
f01b91ae42
Fixed build failed.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13406 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-31 08:35:48 +00:00
ydong10
bf4a3dbd47
Add new interface GetVariable2 and GetEfiGlobalVariable2 to return more info. Also replace old interface with new one.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13375 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-30 07:36:00 +00:00
sfu5
8c1babfd28
Update auth-variable and secure boot UI driver to support only time-based PK, KEK and Signature Database variable variable according to UEFI Spec requirement.
...
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13310 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-14 07:36:20 +00:00
sfu5
ba57d4fdf0
Add pointer check for NULL before dereference it.
...
Signed-off-by: Fu, Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong, Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13162 6f19259b-4bc3-4df7-8a09-765794883524
2012-04-05 02:39:46 +00:00
sfu5
4adc12bfc3
1. Fix GCC build failure in SecurityPkg.
...
Signed-off-by: sfu5
Reviewed-by: gdong1
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13146 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-28 09:06:35 +00:00
sfu5
ecc722ad41
1. Remove “Force clear PK” feature in AuthVarialbe driver.
...
2. Update API ForceClearPK() to UserPhysicalPresent() in PlatformSecureLib.
2. Update SecureBootConfigDxe driver and AuthVariable driver to support Custom Secure Boot Mode feature.
3. Fix some bugs in AuthVariable driver.
Signed-off-by: sfu5
Reviewed-by: tye
Reviewed-by: gdong1
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13144 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-27 08:17:23 +00:00
ydong10
fab1046560
Update for SecurityPkg.
...
Per UEFI spec, on CallBack action EFI_BROWSER_ACTION_CHANGING, the return value of ActionRequest will be ignored, but on CallBack action EFI_BROWSER_ACTION_CHANGED, the return value of ActionRequest will be used.
But, EDKII browser still processes the got ActionRequest. And, all HII drivers in EDKII project also returns their expected ActionRequest value on action EFI_BROWSER_ACTION_CHANGING.
Now update the browser to follow the spec, and update all core Hii drivers to keep old working modal.
Signed-off-by: ydong10
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12868 6f19259b-4bc3-4df7-8a09-765794883524
2011-12-15 02:59:03 +00:00
ydong10
ea71453f72
Initialize the variable before use it to avoid SCT test failed.
...
Signed-off-by: ydong10
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12744 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-21 07:42:53 +00:00
qianouyang
bc0c99b3df
Update ConfigAcess Protocol which is produced by SecureBootConfigDxe to follow the UEFI SPEC (Handle the Request parameter is NULL in ExtractConfig interface).
...
Signed-off-by: qianouyang
Reviewed-by: ydong10
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12707 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-15 10:22:35 +00:00
qianouyang
beda2356f5
Enable/Disable Secured Boot by 'Secure Boot Configuration' Page which is under Setup browser.
...
Signed-off-by: qianouyang
Reviewed-by: gdong1
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12586 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-28 03:46:20 +00:00