sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
30,837 Commits 13 Branches 33 Tags
096cd41ce734a5959f3afa535bb88c6fb78bd1c7
Commit Graph

523 Commits

Author SHA1 Message Date
qhuang8
d9177625f6 Adjust the function layout to remove the prototype of internal functions to reduce sync efforts. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5921 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 14:20:29 +00:00
qhuang8
e676c4d0c6 Apply HighBitSet() in MDE baseLib to retire the internal function CoreHighestSetBit(). 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5920 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:35:14 +00:00
qhuang8
2ce854f515 Remove the status code EFI_ALREADY_STARTED to avoid confusion since it is not a possible return status from LoadFile() interface. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5919 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:34:18 +00:00
qhuang8
f94b9be34f Adjust the function layout of Timer.c to remove the prototype to reduce sync efforts. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5918 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:32:52 +00:00
qhuang8
3f1435782f Refine code to remove the last entry of mArchProtocol. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5917 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:31:43 +00:00
qhuang8
57b4ecb94b Fix several code review minor comments: 
1. Line 79:Use the pre-initialized global variable mPoolHeadList = INITIALIZE_LIST_HEAD_VARIABLE (mPoolHeadList) to remove the statement in line 102
2. Line 337: The debug print statement: “Addr = %x” should change to “Addr = %p” since the expected Buffer is VOID *; How about “(len %x) %,d” ? The Size & Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 
3.Line 413, 418, 425, 477: Use “Buffer != NULL” instead of “NULL != Buffer”  
4. Line 451: The debug print statement: “FreePool = %x” should change to FreePool = %p” since Head->Data is pointer; How about “(len %x) %,d” ? The Head->Size& Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5916 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:29:44 +00:00
qhuang8
d45fd26026 Fix several code review minor comments: 
1.Line 1520, 1525, 1530:Use goto to save Release Lock
2.Line 224: Do not use DEBUG_ERROR, since it is not an error case
3.Scrub the DEBUG () print statement to add DEBUG_PAGE
4.Line 20: Typo of "help cooalese"


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5915 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:28:05 +00:00
qwang12
a70c0fd846 Add VA_END to end the VA_START. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5907 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 02:30:24 +00:00
qwang12
46fee0d7b6 Remove the unnecessary spin_lock protection around CoreUnloadImage. There is almost zero possibility for this reentrancy issue here. With this change, we also keep EDK 2 and EDK core's CoreUnloadImage consistent with each other. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5906 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 02:20:24 +00:00
eric_tian
11074aabe1 CoreHandleProtocol function description should be corrected. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5903 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-16 08:02:57 +00:00
eric_tian
1947c70c3e Merge the global data in ExecData.c to Event.c 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5901 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-16 07:53:15 +00:00
eric_tian
c18f12d375 Comments for CoreInitializeMemoryServices should be updated 
Comments for CoreInitializeGcdServices should be updated.
Comments for CoreInitializeEventServices should be updated.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5899 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-16 07:35:17 +00:00
eric_tian
5f3232d7e8 The file name Exec.h contains UEFI Event support functions and structure. But its file name is not very meaningful and we can consider renaming it. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5898 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-16 07:22:44 +00:00
eric_tian
1349236994 follow up the comments from code review. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5891 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-16 05:19:25 +00:00
qhuang8
7899b79715 Remove the internal CoreCreateProtocolNotifyEvent() in DxeCore, for UefiLib provide the similar function EfiCreateProtocolNotifyEvent(). DxeCore can use that library function. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5883 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-12 01:12:31 +00:00
qhuang8
f0d5cbb66a Update the usage of ALIGN_VARIABLE for the interface change. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5870 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-10 16:05:24 +00:00
qwang12
fa3c419fec Fix a bug by adding CoreReleaseProtocolLock. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5866 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-10 06:30:40 +00:00
qhuang8
3b6ffb6a13 Add EFIAPI modifier for all GCD services APIs 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5865 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-10 03:25:49 +00:00
qhuang8
c0a23f8c37 Remove the prototype of internal functions to avoid the sync efforts. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5861 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-09 05:36:40 +00:00
qwang12
130f16022c Rename Hand.h to Handle.h. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5860 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-09 05:29:23 +00:00
qwang12
c79be85e9d Adjust the field position of PROTOCOL_NOTIFY. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5858 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-09 05:19:46 +00:00
qwang12
6c857d668c 1) Update some comment. 
2) Add in handle for the out_of_resource cases
3) Add in Done label to clean up the code.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5853 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-09 02:39:44 +00:00
qhuang8
599979d4ce Remove unused global variable. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5852 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-09 01:50:38 +00:00
qhuang8
dbfb4b229c Remove two obsolete function prototypes. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5851 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-09 01:47:33 +00:00
qwang12
b9066aae25 Change field Handle to type IHANDLE to remove the type casting. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5846 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-08 12:50:40 +00:00
qwang12
4008328a99 Remove NULL_HANDLE. NULL_HANDLE should be replaced with NULL as consistency. For now, only DXE core is using this macro. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5836 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-08 05:02:38 +00:00
qwang12
7f932291b5 Add more comment for EFI_DEP_REPLACE_TRUE 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5833 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-08 02:00:38 +00:00
qwang12
7ffbd6182d Remove a dead macro EFI_DXESERVICE 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5832 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-08 01:55:51 +00:00
vanjeff
8ee3a19908 Updated EFI_FVB_ATTRIBUTES to EFI_FVB_ATTRIBUTES_2. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5800 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-03 08:55:55 +00:00
qhuang8
19e14fc9d9 1. Use AllocateAlignedPages() to remove tricky logic in DebugImageInfo.c 
2. Add ReportStatusCodeLib instance in MdeModulePkg.dsc for DxeCore.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5774 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-02 05:51:05 +00:00
qhuang8
ceb9059cda clean up DxeCore to remove some dead code. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5764 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-01 11:32:49 +00:00
qhuang8
2680a30801 Clean up DxeCore to use report status code macros in ReportStatusCode to retire CoreReportProgressCode() & CoreReportProgressCodeSpecific() in Library.c in DxeCore. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5761 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-01 08:27:31 +00:00
qhuang8
de4e6bf963 Fix several approved code review comments: 
1. Remove internal function prototypes to avoid sync efforts. The layout of them have been adjusted
2. Apply macro ALIGN_POINTER to get next section stream
3. Fix a potential memory leak issue.
4. Make the comparison between type UINTN and 0 consistent between one function.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5747 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-28 02:53:16 +00:00
qhuang8
9c4ac31cca Clean up DxeCore to remove duplicate memory allocation & device path utility services in Library.c.DxeCore should use MemoryAllocationLib & DevicePathLib for these API. 
Minor cleanup the coding style: #include <DxeMain.h> should be changed to #include "DxeMain.h" since "DxeMain.h" is not pubic header fie.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5742 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-27 14:29:23 +00:00
qhuang8
070f0cf7f2 Add dependency of DevicePathLib to DxeCore so that the internal device path related APIs can be retired to avoid code duplication. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5738 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-27 13:48:11 +00:00
lgao4
e872988180 remove the unused msa files in MdeModulePkg. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5726 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-25 05:03:29 +00:00
qhuang8
0e9b156ddc Remove the global variable of gDxeCoreBS and uses the gBS in UefiBootServicesTableLib for DXE Core. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5697 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-20 09:41:53 +00:00
qhuang8
4fdc91291e Add GLOBAL_REMOVE_IF_UNREFERENCED modifier in the array and change the protocol UI strings to ASCII string since they are only for debug purpose. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5672 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-18 08:40:52 +00:00
qhuang8
4e498a0f27 Remove an unreferenced field in PROTOCOL_INTERFACE data structure. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5670 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-18 08:39:05 +00:00
qwang12
1439777e96 1) Change DEBUG_ERROR TO DEBUG_LOAD as InstallProtocolInterface information is not an error. 
2) Revert binary comparison for consistency.
3) Minor updates for comments.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5621 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-08 03:49:09 +00:00
mdkinney
51b02d81f0 Fix UEFI Boot Service CreateEvent() to follow UEFI Specification with respect to the use of TPL_APPLICATION 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5606 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-01 23:54:52 +00:00
mdkinney
911361242b Increase size of function addresses printed in DEBUG messages from 10 to 11 characters 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5602 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-01 22:41:20 +00:00
vanjeff
75b046c3d4 Using Spin lock instead of using RaiseTpl() to prevent UnloadImage() re-entrance. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5600 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-01 08:10:49 +00:00
qhuang8
443109389d Minor clean up. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5572 6f19259b-4bc3-4df7-8a09-765794883524
 2008-07-26 07:46:04 +00:00
qhuang8
022c6d45ef Code Scrub for Dxe Core. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5560 6f19259b-4bc3-4df7-8a09-765794883524
 2008-07-24 02:54:45 +00:00
qhuang8
e94a9ff727 Code scrub for DxeCore 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5520 6f19259b-4bc3-4df7-8a09-765794883524
 2008-07-18 09:50:09 +00:00
lgao4
5f597758e2 Code scrube for MdeModule Definitions. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5428 6f19259b-4bc3-4df7-8a09-765794883524
 2008-07-08 13:29:42 +00:00
qhuang8
6960e9ae7a Remove minor defects in Doxygen header 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5270 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-22 09:00:12 +00:00
vanjeff
57d6f36db6 add debug information. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5266 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-21 08:32:06 +00:00
qhuang8
23c98c9417 Update to fix minor coding style issues. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5256 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-21 01:40:12 +00:00