sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,454 Commits 13 Branches 33 Tags
0d10bfc88a7cb9683cac6016ef1c11b5c8370bf3
Commit Graph

25 Commits

Author SHA1 Message Date
eric_tian
525aded947 add assert logic to avoid Klocwork fake report 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7512 6f19259b-4bc3-4df7-8a09-765794883524
 2009-02-12 06:39:01 +00:00
jji4
7df7393feb check the usage of %d,%x,%ld,%lx and so on in debug print statement. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7080 6f19259b-4bc3-4df7-8a09-765794883524
 2008-12-18 08:48:36 +00:00
qhuang8
f3f2e05db8 Clean up to update the reference of the these macros: 
EFI_SIGNATURE_16 -> SIGNATURE_16
  EFI_SIGNATURE_32 -> SIGNATURE_32
  EFI_SIGNATURE_64 -> SIGNATURE_64
  EFI_FIELD_OFFSET -> OFFSET_OF
  EFI_MAX_BIT      -> MAX_BIT
  EFI_MAX_ADDRESS  -> MAX_ADDRESS
These macros are not defined in UEFI spec. It makes more sense to use the equivalent macros in Base.h to avoid alias.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@7056 6f19259b-4bc3-4df7-8a09-765794883524
 2008-12-16 15:34:21 +00:00
vanjeff
43025b293f ECC Clean up. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6205 6f19259b-4bc3-4df7-8a09-765794883524
 2008-10-24 02:55:01 +00:00
qhuang8
6e53646837 Fix several coding style violations 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@6163 6f19259b-4bc3-4df7-8a09-765794883524
 2008-10-21 03:11:47 +00:00
eric_tian
dc8d93ca0c add detail comments on the complicated code segment. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5954 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-23 14:49:45 +00:00
eric_tian
ec90508b3d move header files in MdeModulePkg\Core\Dxe except DxeMain.h into their corresponding sub-module directories. It is used to provide good modularity. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5949 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-23 07:35:34 +00:00
qhuang8
d9177625f6 Adjust the function layout to remove the prototype of internal functions to reduce sync efforts. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5921 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 14:20:29 +00:00
qhuang8
57b4ecb94b Fix several code review minor comments: 
1. Line 79:Use the pre-initialized global variable mPoolHeadList = INITIALIZE_LIST_HEAD_VARIABLE (mPoolHeadList) to remove the statement in line 102
2. Line 337: The debug print statement: “Addr = %x” should change to “Addr = %p” since the expected Buffer is VOID *; How about “(len %x) %,d” ? The Size & Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 
3.Line 413, 418, 425, 477: Use “Buffer != NULL” instead of “NULL != Buffer”  
4. Line 451: The debug print statement: “FreePool = %x” should change to FreePool = %p” since Head->Data is pointer; How about “(len %x) %,d” ? The Head->Size& Pool->Used belong to type UINTN? Cast it to UINT64 and use %lx 


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5916 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:29:44 +00:00
qhuang8
d45fd26026 Fix several code review minor comments: 
1.Line 1520, 1525, 1530:Use goto to save Release Lock
2.Line 224: Do not use DEBUG_ERROR, since it is not an error case
3.Scrub the DEBUG () print statement to add DEBUG_PAGE
4.Line 20: Typo of "help cooalese"


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5915 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-17 13:28:05 +00:00
qhuang8
f0d5cbb66a Update the usage of ALIGN_VARIABLE for the interface change. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5870 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-10 16:05:24 +00:00
qhuang8
599979d4ce Remove unused global variable. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5852 6f19259b-4bc3-4df7-8a09-765794883524
 2008-09-09 01:50:38 +00:00
qhuang8
9c4ac31cca Clean up DxeCore to remove duplicate memory allocation & device path utility services in Library.c.DxeCore should use MemoryAllocationLib & DevicePathLib for these API. 
Minor cleanup the coding style: #include <DxeMain.h> should be changed to #include "DxeMain.h" since "DxeMain.h" is not pubic header fie.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5742 6f19259b-4bc3-4df7-8a09-765794883524
 2008-08-27 14:29:23 +00:00
qhuang8
022c6d45ef Code Scrub for Dxe Core. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5560 6f19259b-4bc3-4df7-8a09-765794883524
 2008-07-24 02:54:45 +00:00
qhuang8
e94a9ff727 Code scrub for DxeCore 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5520 6f19259b-4bc3-4df7-8a09-765794883524
 2008-07-18 09:50:09 +00:00
qhuang8
23c98c9417 Update to fix minor coding style issues. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5256 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-21 01:40:12 +00:00
qhuang8
6cea0db87c Change the file name case to follow coding style: The first character should be capital. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5246 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-21 01:00:57 +00:00
qhuang8
3a610a1877 Change the file name case to follow coding style: The first character should be capital. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5245 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-21 01:00:25 +00:00
qhuang8
71f68914fa Fix the prediction warnings in DxeMain. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5190 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-09 07:52:58 +00:00
qhuang8
162ed59443 Add doxygen style comments for functions in DxeMain. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5189 6f19259b-4bc3-4df7-8a09-765794883524
 2008-05-09 07:08:30 +00:00
lgao4
504214c487 Add comments and DoxyGen format for these files. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5028 6f19259b-4bc3-4df7-8a09-765794883524
 2008-04-09 07:07:50 +00:00
eric_tian
88c8f7fbfd [Description] 
spelling mistake
[Impaction]
modify the mistake
[Reference Info]
Found the spelling mistake in pool.c

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4949 6f19259b-4bc3-4df7-8a09-765794883524
 2008-03-24 07:11:37 +00:00
qhuang8
383c303c49 Fix two minor defects: 
1. CoreGetMemoryMap() returns unclean data
2. Zero length memory descriptor might be added to the memory map

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4790 6f19259b-4bc3-4df7-8a09-765794883524
 2008-03-04 11:33:13 +00:00
mdkinney
b74350e956 1) Improve the EFI Memory Map stability to improve ACPI S4 support 
2) Update DXE IPL to always publish the MemoryTypeInformation HOB



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@4327 6f19259b-4bc3-4df7-8a09-765794883524
 2007-11-27 02:47:37 +00:00
yshang1
28a0029718 Check in DxeCore for Nt32 platform. Currently, it does not follow PI/UEFI2.1. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@3045 6f19259b-4bc3-4df7-8a09-765794883524
 2007-07-04 10:51:54 +00:00