af90df3cb0
ShellPkg-UefiShellCommandLib: Add EFIAPI in VA_List library function
...
Add EFIAPI in CatPrint library function. Every function which uses
variable list need explicit use EFIAPI to force use MS ABI. This change
is needed to pass CLANG38 build.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi <steven.shi@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-08-10 12:56:53 +08:00
ba601bddf8
ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin
...
Use explicit CopyMem to replace compiler builtin to do the structure
values assignment. This change is needed to pass CLANG38 build.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi <steven.shi@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-08-10 12:56:37 +08:00
5aeafb3a25
ShellPkg/ls: Display the correct directory path
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hpe.com >
2016-08-10 10:17:17 +08:00
47ec935660
ShellPkg/ls: Fix to support "ls fs0:File.txt"
...
“ls fs0:\File.txt" can list the file correctly but
when the backslash is removed from colon, the file cannot
be listed.
The patch fixes this issue.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hpe.com >
2016-08-10 10:17:13 +08:00
f4c6c0fdb6
ShellPkg SmbiosView: Show "SocketDesignation" instead of "Socket" for Type 4
...
It is to make the info shown more aligned with SMBIOS spec.
Cc: Amy Chan <amy.chan@intel.com >
Cc: Ruiyu Ni <ruiyu.ni@intel.com >
Cc: Jaben Carsey <jaben.carsey@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Amy Chan <amy.chan@intel.com >
2016-08-08 17:00:20 +08:00
9b7143c904
ShellPkg: Correct files with CRLF line ending
...
Cc: Ruiyu Ni <ruiyu.ni@intel.com >
Cc: Jaben Carsey <jaben.carsey@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-29 09:18:12 +08:00
fc41b97f12
ShellPkg/LoadPciRom: Fix the ConnectAll() implementation
...
Old implementation depends on UefiHandleParsingLib and uses
incorrect Index to get handle type.
The simplest ConnectAll() implementation can be just to
locate all handles and call BS.ConnectController() for each
of them recursively. BS.ConnectController() does nothing
to the image handle. Such implementation is borrowed from
BDS core implementation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2016-07-25 10:20:14 +08:00
1b0319535b
ShellPkg/If: Fix issue to pass static code checker
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2016-07-25 10:20:13 +08:00
94fcb76b61
ShellPkg/UefiHandleParsingLib: Fix issue to pass static code checker
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2016-07-25 10:20:13 +08:00
cb9f3a59c3
ShellPkg/DrvDiag: Fix a critical typo bug
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Hao A Wu <hao.a.wu@intel.com >
2016-07-25 10:20:12 +08:00
95fc5a8775
ShellPkg: Fix echo to support displaying special characters
...
Run 'echo -t' without the patch will get the result:
echo: Unknown flag - '-t'
The expected result is to display '-t' literally.
This patch adds special handle for 'echo'. 'echo' will not use the
general parameter parsing library.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-20 10:28:00 +08:00
0fcf8d4df8
ShellPkg: Add Shell[Get|Set]RawCmdLine to ShellCommandLib
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-20 10:27:56 +08:00
c0bcd3433f
ShellPkg: Move FindFirstCharacter/GetNextParameter to ShellCommandLib
...
And add Shell prefix to the two library APIs.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-20 10:27:51 +08:00
cf041fd799
ShellPkg/UefiShellCommandLib.c: Formalize EOL
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-20 10:26:58 +08:00
9ba25c7db7
ShellPkg: Fix VS2010/2012 build failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Dandan Bi <dandan.bi@intel.com >
2016-07-19 11:12:22 +08:00
e7a5a238c3
ShellPkg/Ping6: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:22 +08:00
a915fea68e
ShellPkg/Ifconfig6: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:19 +08:00
eeb9744e56
ShellPkg/UefiShellLib.c: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:16 +08:00
18bff310aa
ShellPkg/IfConfig: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:13 +08:00
2efafabf41
ShellPkg/UefiShellLib: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:10 +08:00
28d447f9bd
ShellPkg/Mv: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:07 +08:00
0b34dc1324
ShellPkg/Cp: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:04 +08:00
a34b7c3662
ShellPkg/Cd: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 11:04:00 +08:00
581c03896c
ShellPkg/If: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:53 +08:00
59b7dbac4e
ShellPkg/For: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:48 +08:00
26ca45a86f
ShellPkg/DrvDiag: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:45 +08:00
58972f5cf7
ShellPkg/DrvCfg: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:42 +08:00
55b1d63de7
ShellPkg/DevTree: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:38 +08:00
3e9442a564
ShellPkg/Edit: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:35 +08:00
20cfed165c
ShellPkg/LoadPciRom: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:32 +08:00
aba0ca78c6
ShellPkg/EfiDecompress: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:29 +08:00
ca1b2411f5
ShellPkg/EfiCompress: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:26 +08:00
c87bb070a6
ShellPkg/DMem: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:23 +08:00
107d05a433
ShellPkg/UefiShellCommandLib.c: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:20 +08:00
2c7c3b87bf
ShellPkg/ConsistMapping.c: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:17 +08:00
5945813f69
ShellPkg/UefiShellBcfgCommandLib: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:14 +08:00
aa3276c171
ShellPkg/UefiHandleParsingLib.c: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:11 +08:00
d758f80971
ShellPkg/Dp: Handle memory allocation failure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-18 10:55:08 +08:00
e2f5c491d8
ShellPkg: Fix issue about Ifconfig6 -r command.
...
Follow the Shell Spec, when the interface name is Specified,
we need to refresh the Ipv6 configuration.
Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com >
Cc: Ye Ting <ting.ye@intel.com >
Cc: Fu Siyuan <siyuan.fu@intel.com >
Cc: Wu Jiaxin <jiaxin.wu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com >
Reviewed-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com >
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com >
2016-07-15 14:45:55 +08:00
664fd5877d
Revert "ShellPkg: Make the USB mouse behavior in 'edit' consistent with 'hexedit'."
...
This reverts commit ee60bd2b6a
and
e36ed7a84b
.
The two commits enhanced 'edit' to support text selection through
mouse. But the code introduced some bugs resulting the text
selection behavior is not very usable and potentially hang in
certain platforms.
So I'd like to revert them firstly. If there is strong
requirement for the text selection through mouse in 'edit'
I will refine and re-add the code.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jarben.carsey@intel.com >
2016-07-08 14:54:30 +08:00
1d32246161
ShellPkg: Series of patches to fix typos - apropriate to appropriate
...
Cc: Jaben Carsey <jaben.carsey@intel.com >
Cc: Shumin Qiu <shumin.qiu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com >
Reviewed-By: Jaben Carsey <jaben.carsey@intel.com >
2016-07-07 15:24:24 -07:00
80f7a8f5f9
ShellPkg:Ping: Ping command hangs with intermittent packet losses
...
When we have intermittent loss of packets, ping command doesnt
return to Shell prompt. It keeps looping in the while (Status
==EFI_NOT_READY) since Private->RxCount will never reach
Private->SendNum. Addresses the issue with the use of a new varibale
in the PRIVATE structure.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com >
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-07-07 08:00:50 -07:00
e06a4c0812
Fix GUID dereference
...
Print's "%g" argument requires a EFI_GUID pointer, not the EFI_GUID
value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com >
Reviewed-By: Jaben Carsey <jaben.carsey@intel.com >
2016-07-06 08:19:54 -07:00
dded3ae880
ShellPkg: Update the error prompt for ping6 command.
...
when we use the ping6 command without configuring the network
interface, it should give correct prompt to users.
Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com >
Cc: Fu Siyuan <siyuan.fu@intel.com >
Cc: Wu Jiaxin <jiaxin.wu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com >
Reviewed-by: Sriram Subramanian <sriram-s@hpe.com >
Reviewed-by: Hegde, Nagaraj P <nagaraj-p.hegde@hpe.com >
Reviewed-By: Wu Jiaxin <jiaxin.wu@intel.com >
2016-07-05 16:48:31 +08:00
42cb906852
ShellPkg: UefiHandleParsingLib: remove tautological comparison
...
The code being removed in this patch dates back to git commit a405b86d27
(Sep 14, 2010; "udk2010.up2.shell initial release."). The condition always
evaluates to true, and it breaks DEBUG builds of ArmVirtPkg with gcc-6.1:
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c:
In function 'ParseHandleDatabaseByRelationshipWithType':
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c:2465:76:
error: self-comparison always evaluates to true
[-Werror=tautological-compare]
ASSERT((*HandleType)[HandleIndex] == (*HandleType)[HandleIndex]);
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org >
Cc: Gerd Hoffmann <kraxel@redhat.com >
Cc: Jaben Carsey <jaben.carsey@intel.com >
Cc: Michael Zimmermann <sigmaepsilon92@gmail.com >
Reported-by: Gerd Hoffmann <kraxel@redhat.com >
Reported-by: Michael Zimmermann <sigmaepsilon92@gmail.com >
Suggested-by: Jaben Carsey <jaben.carsey@intel.com >
Ref: http://thread.gmane.org/gmane.comp.bios.edk2.devel/13794/focus=13939
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-06-30 23:14:29 +02:00
4a7518d31a
ShellPkg: don't call functions with side effects in ASSERT_EFI_ERROR()
...
When ASSERT_EFI_ERROR() is compiled out, dependent on build flags, only
the status checking should be removed; the function calls should stay.
Cc: Jaben Carsey <jaben.carsey@intel.com >
Cc: Shumin Qiu <shumin.qiu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-06-30 17:27:15 +02:00
5e32460d80
ShellPkg/UefiHandleParsing: Show handle's loaded image device path
...
The patch fixed a bug in UefiHandleParsingLib to show handle's loaded
image device path.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-06-21 15:59:26 +08:00
46213c8eb4
ShellPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr
...
It is the follow up of 3ab41b7a32
to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with
UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS.
Cc: Jiewen Yao <jiewen.yao@intel.com >
Cc: Jaben Carsey <jaben.carsey@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-06-21 12:46:26 +08:00
e918029fbc
ShellPkg/UefiHandleParsingLib.c: Unify EOL and remove trailing space
...
The patch doesn't change any code logic.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Cc: Jiewen Yao <jiewen.yao@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-06-17 15:43:11 +08:00
2528e47cb2
ShellPkg: Use ".." to indicate device path is partially displayed
...
The output of "dh <handle>" originally is like below:
12C: USBIO DevicePath(x0)/Pci(0x14,0x0)/USB(0x6,0x0))
The device path part is very confusing. Use ".." in front of the
partially displayed device path is better and it also aligns to
the example output in Shell spec.
12C: USBIO DevicePath(..)/Pci(0x14,0x0)/USB(0x6,0x0))
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-06-17 15:43:11 +08:00