ba601bddf8
ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin
...
Use explicit CopyMem to replace compiler builtin to do the structure
values assignment. This change is needed to pass CLANG38 build.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi <steven.shi@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-08-10 12:56:37 +08:00
46213c8eb4
ShellPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr
...
It is the follow up of 3ab41b7a32jiewen.yao@intel.com >
Cc: Jaben Carsey <jaben.carsey@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-06-21 12:46:26 +08:00
6987d7aa83
ShellPkg: Fix ARM build failure.
...
This patch fixes the ARM build failure introduced by
2be45bfe27siyuan.fu@intel.com >
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org >
2016-05-20 14:43:09 +08:00
2be45bfe27
ShellPkg: Add argument to set block size for tftp command.
...
TFTP block size has a big impact on the transmit performance, this patch is to
add new argument [-s <block size>] for shell "tftp" command to configure the
block size for file download.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
2016-05-20 11:30:47 +08:00
c617380446
ShellPkg: Refine code by initializing local variable and adding ASSERT statement.
...
Add ASSERT statement and initialize local variable to make code more readable.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18689 6f19259b-4bc3-4df7-8a09-765794883524
2015-10-28 01:14:34 +00:00
da6b8feb22
ShellPkg: Use safe string functions to refine 'Tftp.c' code.
...
Safe string functions can help avoid potential buffer overflow. This patch replaces the StrCpy with StCpyS.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18608 6f19259b-4bc3-4df7-8a09-765794883524
2015-10-15 02:19:14 +00:00
7367e66f8b
ShellPkg: UefiShellTftpCommandLib: fix incompatible pointer assignment
...
Add the missing EFIAPI calling convention to the CheckPacket() function.
Without it, the gcc build breaks due to the incompatible pointer
assignment in "Mtftp4Token.CheckPacket = CheckPacket".
Cc: Jaben Carsey <jaben.carsey@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18553 6f19259b-4bc3-4df7-8a09-765794883524
2015-09-25 17:22:53 +00:00
6add86ab59
ShellPkg: Update tftp to build with current tip
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Signed-off-by: Tapan Shah <tapandshah@hpe.com >
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com >
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18543 6f19259b-4bc3-4df7-8a09-765794883524
2015-09-24 20:44:59 +00:00
310b053a86
Revert 18541
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18542 6f19259b-4bc3-4df7-8a09-765794883524
2015-09-24 20:44:00 +00:00
0994fe6f81
ShellPkg: Update tftp to build with current tip
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Signed-off-by: Tapan Shah <tapandshah@hpe.com >
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com >
Reviewed-by: Qiu Shumin <shumin.qiu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18541 6f19259b-4bc3-4df7-8a09-765794883524
2015-09-24 19:48:58 +00:00
a0f2af3a74
ShellPkg\Tftp.c: Refine parameter name and use implicit comparison for BOOLEAN variable.
...
1. Refine parameter name to consistent with function headers.
2. To avoid potential bug BOOLEAN values should not use explicit comparisons to TRUE or FALSE.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18222 6f19259b-4bc3-4df7-8a09-765794883524
2015-08-14 07:20:09 +00:00
0fcf66a4b2
ShellPkg: Add function comments and refine code format to follow EDKII coding style.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18186 6f19259b-4bc3-4df7-8a09-765794883524
2015-08-07 05:42:02 +00:00
6807426071
ShellPkg: Add optional 'tftp' EFI Shell command
...
This 'tftp' command allows to download a file from a TFTP server.
A specific network interface can be chosen in case there are multiple
interfaces.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ronald Cron <Ronald.Cron@arm.com >
Reviewed-by: Olivier Martin <Olivier.Martin@arm.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18015 6f19259b-4bc3-4df7-8a09-765794883524
2015-07-15 15:39:53 +00:00
