sravan/system76-edk2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
13,986 Commits 13 Branches 33 Tags
93b7308337a145632abdd2f1684e9bba60ffb448
Commit Graph

59 Commits

Author SHA1 Message Date
Brendan Jackman
3877d0f581 ShellPkg/UefiShellLib.c: Execute: Return a Command status even in the old shell 
This means we can use ShellExecute without thinking which shell
environment is in use. However it still isn't ideal: if
mEfiShellEnvironment2->Execute returns EFI_INVALID_PARAMETER, we can't tell
whether Execute() received an invalid parameter (e.g. ParentImageHandle was
NULL), or whether we tried to execute a command with an invalid parameter
(for example CommandLine "ls -hurdygurdy").

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Brendan Jackman <Brendan.Jackman@arm.com>
Reviewed-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>



git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15183 6f19259b-4bc3-4df7-8a09-765794883524
 2014-01-24 22:31:07 +00:00
Brendan Jackman
708793148d ShellLib/UefiShellLib.c: Fix doc comment for ShellOpenFileMetaArg 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Brendan Jackman <Brendan.Jackman@arm.com>
Reviewed-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>



git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15182 6f19259b-4bc3-4df7-8a09-765794883524
 2014-01-24 22:29:53 +00:00
Jaben Carsey
31b018a663 ShellPkg: Remove ASSERT 
This change removes ASSERT statements and replaces them with logic to break out of the loop.  This both prevents spinning forever and prevents processing the returned data from the function that failed.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15133 6f19259b-4bc3-4df7-8a09-765794883524
 2014-01-16 16:52:39 +00:00
Jaben Carsey
75a5e2ef4e ShellPkg: remove potential memory leak with new apps on old shell 
This pointer never gets free when running new apps on the old shell.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15095 6f19259b-4bc3-4df7-8a09-765794883524
 2014-01-10 16:42:45 +00:00
Jaben Carsey
194ae48dae ShellPkg: Add support for CTRL-C within shell user prompting 
This allows for the user to get out of answering a question with CTRL-C

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14950 6f19259b-4bc3-4df7-8a09-765794883524
 2013-12-09 22:55:13 +00:00
Jaben Carsey
74b0fb8c87 ShellPkg: Add ShellHexStrToUintn to allow for simple conversion of hex numbers. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14893 6f19259b-4bc3-4df7-8a09-765794883524
 2013-11-22 21:37:34 +00:00
Jaben Carsey
d59fc24497 ShellPkg: clarify space limitation in comment. 
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14845 6f19259b-4bc3-4df7-8a09-765794883524
 2013-11-14 23:52:43 +00:00
jcarsey
365aa98a5d ShellPkg: Add ShellPrintHelp function to ShellLib. 
This function allows for easier access to printing standard command help.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Matt Stanbro <Matthew.A.Stanbro@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14159 6f19259b-4bc3-4df7-8a09-765794883524
 2013-03-04 21:54:02 +00:00
jcarsey
fb5278ef78 ShellPkg: Added function ShellDeleteByName which deletes a file by name. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Matthew Stanbro <matthew.a.stanbro@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14138 6f19259b-4bc3-4df7-8a09-765794883524
 2013-02-20 18:21:14 +00:00
ydong10
0b6cb335fa Fixed some alignment faults in IPF platform 
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Carsey Jaben <jaben.carsey@intel.com>




git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14081 6f19259b-4bc3-4df7-8a09-765794883524
 2013-01-25 02:00:22 +00:00
ydong10
f480fdc0f9 Fix always allocate memory issue. 
Signed-off-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13706 6f19259b-4bc3-4df7-8a09-765794883524
 2012-09-07 01:55:33 +00:00
ydong10
12ea46947d Roll back the change which caused build fail 
Signed-off-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13557 6f19259b-4bc3-4df7-8a09-765794883524
 2012-07-26 05:42:43 +00:00
jcarsey
05916c1532 ShellPkg: Update string to number conversion to correctly stop at spaces if so requested. 
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: jaben carsey <jaben.carsey@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13548 6f19259b-4bc3-4df7-8a09-765794883524
 2012-07-23 16:32:09 +00:00
jcarsey
06c355b42f correct removal of commit 12951. 
submitted-by: jaben.carsey@intel.com

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13141 6f19259b-4bc3-4df7-8a09-765794883524
 2012-03-26 21:00:39 +00:00
jcarsey
8bb7441edd ShellPkg: Allow for format character strings to be typed in editor without having effect on editor screen. 
signed-off-by: jcarsey
reviewed-by: leegrosenbaum

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12965 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-30 18:44:41 +00:00
jcarsey
49bd498dfe ShellPkg: parameters with spaces need quotes. 
signed-off-by: jcarsey
reviewed-by: leegrosenbaum

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12960 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-27 18:42:43 +00:00
jcarsey
28d903168c ShellPkg: This patch fixes the redirection support for a Shell2 application running in Shell1. 
signed-off-by: Richard_Chan@Dell.com
reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12951 6f19259b-4bc3-4df7-8a09-765794883524
 2012-01-20 21:58:15 +00:00
darylm503
b0934ac4b0 ShellPkg: Update comments for functions to clarify buffer origin. 
Signed-off-by: darylm503
Reviewed-by: jljusten



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12687 6f19259b-4bc3-4df7-8a09-765794883524
 2011-11-12 00:35:11 +00:00
jcarsey
c8c2259156 ShellPkg: Add checking for memory allocation and pointer returns from functions. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12542 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-17 17:49:21 +00:00
jcarsey
7a95efda40 SShellPkg: updating order of cast and addressing of a pointer (2 identical places). 
GCC build didn't like the original version.

sighed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12535 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-13 16:08:18 +00:00
ydong10
0c1950ba5e Check the pointer before use it to avoid potential access violation. 
Signed-off-by: ydong10
Reviewed-by: jcarsey

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12533 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-13 02:37:35 +00:00
jcarsey
beab0fc5e2 ShellPkg: Verify memory allocations without ASSERT. 
signed-off-by: jcarsey
reviewed-by: geekboy15a

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12522 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-10 17:26:25 +00:00
sfu5
02a758cb0b Add pointer check for NULL before dereference it. 
Signed-off-by: sfu5
Reviewed-by: xdu2
Reviewed-by: ydong10


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12514 6f19259b-4bc3-4df7-8a09-765794883524
 2011-10-08 02:55:30 +00:00
ydong10
4ff7e37b4f Refine comments and two code style. 
Signed-off-by: ydong10

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12263 6f19259b-4bc3-4df7-8a09-765794883524
 2011-09-02 08:05:34 +00:00
jcarsey
5d46f17ba7 ShellPkg: fix ShellPrint-functions to allow for escape character to prevent attribute changes. 
This allows for the editors to function easily.

signed-off-by: jcarsey
reviewed-by: kidzyoung

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12187 6f19259b-4bc3-4df7-8a09-765794883524
 2011-08-23 15:34:23 +00:00
jcarsey
4d0a4fcefe Move the 2 functions associated with reading whole lines at a single time from the shell command (internal) library to the ShellLib (external) library. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12000 6f19259b-4bc3-4df7-8a09-765794883524
 2011-07-06 22:28:36 +00:00
jcarsey
366f81a016 Clarify that the shared variables of the shell protocols are properly named. 
This removes the non-shared gEfiShellProtocol and gEfiShellParametersProtocol and renames the shared version to those names.

This removes the m-versions of those protocol pointers.

signed-off-by: jcarsey
reviewed-by: darylm503

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11900 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 21:04:22 +00:00
jcarsey
92a5447eda replace protocol presence ASSERTs with error returns. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11899 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 20:33:13 +00:00
jcarsey
8bd282bee9 allow for failure return when called without a shell present. 
signed-off-by: jcarsey
reviewed-by: lgrosenb

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11894 6f19259b-4bc3-4df7-8a09-765794883524
 2011-06-27 16:45:41 +00:00
jcarsey
f8d3e6898a check that memory allocation was successful. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11568 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-19 17:54:42 +00:00
jcarsey
89e8537acf change file global variable to function local. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11539 6f19259b-4bc3-4df7-8a09-765794883524
 2011-04-13 23:37:50 +00:00
jcarsey
252d945725 updated comments and added string-to-number conversion with return value to indicate success or failure. All parameter checking updated to non-case-sensitive. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11424 6f19259b-4bc3-4df7-8a09-765794883524
 2011-03-25 20:49:53 +00:00
jcarsey
3e082d5826 Verify more memory allocations. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10910 6f19259b-4bc3-4df7-8a09-765794883524
 2010-10-04 16:44:57 +00:00
jcarsey
a405b86d27 udk2010.up2.shell initial release. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10874 6f19259b-4bc3-4df7-8a09-765794883524
 2010-09-14 05:18:09 +00:00
xdu2
90bfa227ee Add some error checking. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10661 6f19259b-4bc3-4df7-8a09-765794883524
 2010-07-19 05:21:27 +00:00
jcarsey
c9d92df05f k8 fixes and moving prompting for responses into this file. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9922 6f19259b-4bc3-4df7-8a09-765794883524
 2010-02-03 15:37:54 +00:00
jcarsey
91876ff963 remove unnecessary PCD usage 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9921 6f19259b-4bc3-4df7-8a09-765794883524
 2010-02-03 14:59:00 +00:00
jcarsey
1cd45e787d fix K8 coding issues. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9862 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-29 15:07:44 +00:00
jcarsey
1e6e84c7af fixed license header / copyright date on all files. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9810 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-25 20:05:08 +00:00
jcarsey
9e926b693d git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9758 6f19259b-4bc3-4df7-8a09-765794883524 2010-01-14 20:26:39 +00:00
jcarsey
969c783b46 adding new parameter to search and replace function to allow for easy skipping of items preceded by ^ 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9726 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-13 16:46:33 +00:00
jcarsey
b3011f4041 updating comments mostly. also added some new lib functions. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9710 6f19259b-4bc3-4df7-8a09-765794883524
 2010-01-11 21:49:04 +00:00
jcarsey
ecd3d59f33 add ASSERT to 2 functions and fix issue with size difference between old and new shell versions. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9537 6f19259b-4bc3-4df7-8a09-765794883524
 2009-12-07 18:05:00 +00:00
jcarsey
5cb3637f0f remove extra variables 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9504 6f19259b-4bc3-4df7-8a09-765794883524
 2009-12-02 02:47:19 +00:00
jcarsey
e2f8297f9c updates from code review, buffer length, and correct use of StdOut for printing 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9499 6f19259b-4bc3-4df7-8a09-765794883524
 2009-12-01 05:40:24 +00:00
jcarsey
36a9d67261 build break fix and new function 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9461 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-20 21:13:41 +00:00
jcarsey
a31bd33cf8 comment repairs. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9460 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-20 18:21:03 +00:00
jcarsey
6c88029b45 specify operand order 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9451 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-19 21:10:41 +00:00
jcarsey
125c2cf4f1 updating headers from code review. 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9449 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-18 21:36:50 +00:00
jcarsey
2247dde4b6 Upgrade ShellLib and fix bug with param parsing 
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@9398 6f19259b-4bc3-4df7-8a09-765794883524
 2009-11-09 18:08:58 +00:00