5bd12b0555
ShellPkg: fix DmpStore for deleting
...
This change allows DmpStore command to delete all variables whereas before it would stop after a single deletion due to looping errors. It uses a recursive function and deletes the last item returned from GetNextVariableName() first and then goes "backwards" to the first items.
This can't delete authenticated variables.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15014 6f19259b-4bc3-4df7-8a09-765794883524
2013-12-20 22:33:01 +00:00
d4468cdf14
Rollback the change to EFI_BOOT_KEY_DATA structure since UEFI Spec adds the clarification that bitfields are ordered such that bit 0 is the least significant bit.
...
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15000 6f19259b-4bc3-4df7-8a09-765794883524
2013-12-18 05:51:22 +00:00
6855763eb2
ShellPkg: Fix pci command to parse seg, bus, dev, and func arguments as hex
...
- Added STR_GEN_PARAM_INV_HEX string
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14926 6f19259b-4bc3-4df7-8a09-765794883524
2013-12-02 21:45:28 +00:00
541ddf4436
ShellPkg: Fix pci command output of Max and Current Link Speed, and ASPM Support values to match PCIe Base Spec rev 3.0
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14892 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-22 21:17:25 +00:00
c37e0f16be
ShellPkg: Update pci command to use ShellPrintEx()
...
- Also minor simplification to the PciPrintClassCode() function.
- Remove invalid duplicate gShellDebug1HiiHandle argument in STR_PCI_NO_FIND print.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14880 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-21 17:21:59 +00:00
f79868cd18
ShellPkg: Change MM command output during script execution
...
- Automatically use non-interactive mode during script execution.
- Automatically use non-interactive mode when a specific value is read (omitting this behavior was a violation of the UEFI Shell Spec)
- Only output the value read in when reading a value in a script; this allows automated use of the MM command.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Chris Phillips <chrisp@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14874 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-20 17:25:02 +00:00
14b5e3fd78
ShellPkg pci command: Fix a typo; /r/n => \r\n
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14865 6f19259b-4bc3-4df7-8a09-765794883524
2013-11-19 23:02:59 +00:00
abbea36e3e
ShellPkg: Fixes ‘edit’ command to correctly display ASCII or UNICODE for the file type.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
reviewed-by: jaben carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14785 6f19259b-4bc3-4df7-8a09-765794883524
2013-10-18 18:11:52 +00:00
6b6aa6d136
ShellPkg: Handle pool allocation failure
...
If AllocateZeroPool() returns NULL,
GetVariable() will return EFI_BUFFER_TOO_SMALL,
FreePool() will receive NULL.
So check for NULL before FreePool().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Sergei Antonov <saproj@gmail.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14688 6f19259b-4bc3-4df7-8a09-765794883524
2013-09-19 17:23:10 +00:00
e3df6949e7
Fix GCC build failure.
...
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14519 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-30 06:41:43 +00:00
863986b3c8
Update all the code to consume the ConvertDevicePathToText, ConvertDevicePathNodeToText, ConvertTextToDevicePath and ConvertTextToDeviceNode APIs in DevicePathLib.
...
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Feng Tian <feng.tian@intel.com >
Reviewed-by: Elvin Li <elvin.li@intel.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14505 6f19259b-4bc3-4df7-8a09-765794883524
2013-07-26 03:14:08 +00:00
28981267c5
ShellPkg: Fix ARM build errors.
...
submitted-by: Olivier Martin olivier.martin@arm.com >
reviewed-by: Jaben Carsey <Jaben.Carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14400 6f19259b-4bc3-4df7-8a09-765794883524
2013-06-11 22:07:03 +00:00
d0cec2da21
Correct the incorrect Copyright or License in EDKII source files.
...
Signed-off-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Hess Chen (hesheng.chen@intel.com )
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14383 6f19259b-4bc3-4df7-8a09-765794883524
2013-05-22 02:19:16 +00:00
224e8e2f47
ShellPkg: Return an error when it happens
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.Carsey@intel.com >
Reviewed-by: Erik Bjorge <Erik.c.Bjorge@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14336 6f19259b-4bc3-4df7-8a09-765794883524
2013-05-09 16:16:21 +00:00
e755a4ca10
ShellPkg: Fixed build error 'variable set but not used'
...
GCC toolchain cannot build ShellPkg.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Harry Liebel <Harry.Liebel@arm.com >
Signed-off-by: Olivier Martin <Olivier.Martin@arm.com >
Reviewed-by: Jaben Carsey <Jaben.Carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14326 6f19259b-4bc3-4df7-8a09-765794883524
2013-05-07 17:57:58 +00:00
0b6cb335fa
Fixed some alignment faults in IPF platform
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Carsey Jaben <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14081 6f19259b-4bc3-4df7-8a09-765794883524
2013-01-25 02:00:22 +00:00
caa6c0cca2
ShellPkg: Minor change to EDIT and HEXEDIT commands to make the title bars consistent and remove unnecessary “2.0” string
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud elhaj@hp.com
reviewed-by: jaben carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14063 6f19259b-4bc3-4df7-8a09-765794883524
2013-01-17 19:04:02 +00:00
5904052aab
ShellPkg: Updates to DumpHex() and ‘dmem’ command for correct output format
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14010 6f19259b-4bc3-4df7-8a09-765794883524
2012-12-19 16:47:06 +00:00
d51088b764
ShellPkg: Updates to 'help' command
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13997 6f19259b-4bc3-4df7-8a09-765794883524
2012-12-13 21:26:22 +00:00
7ac133d002
ShellPkg: Updates to 'smbiosview' command
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13996 6f19259b-4bc3-4df7-8a09-765794883524
2012-12-13 21:11:21 +00:00
ce68d3bc68
Add missing braces around initializer.
...
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Qian Ouyang <qian.ouyang@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Feng Tian <feng.tian@intel.com >
Reviewed-by: Jeff Fan <jeff.fan@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13817 6f19259b-4bc3-4df7-8a09-765794883524
2012-10-11 02:15:23 +00:00
44890dbde6
Refine code to make it more safely.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13712 6f19259b-4bc3-4df7-8a09-765794883524
2012-09-10 09:35:43 +00:00
44c5d6b548
Refine coding style.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13700 6f19259b-4bc3-4df7-8a09-765794883524
2012-09-05 08:46:51 +00:00
99bb0f8dd7
Fix build fail.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13697 6f19259b-4bc3-4df7-8a09-765794883524
2012-09-04 08:35:16 +00:00
d6972185d0
Refine the code to make it more safely.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13696 6f19259b-4bc3-4df7-8a09-765794883524
2012-09-03 01:59:05 +00:00
3206b5e75d
Change Bcfg.c to use the new definition of EFI_KEY_OPTION.
...
Signed-off-by: Ruiyu Ni<ruiyu.ni@intel.com >
Reviewed-by: Eric Dong<eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13681 6f19259b-4bc3-4df7-8a09-765794883524
2012-08-27 10:09:34 +00:00
a7e57bd9e0
The format strings are using notations that require UINTNs (like "0x%02x") but a UINT64 type was being passed instead. This patch adds a typecast to UINTN so the print processing works correctly.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen eugene@hp.com
Reviewed-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13597 6f19259b-4bc3-4df7-8a09-765794883524
2012-08-07 00:54:29 +00:00
cd0842dc82
Refine code to follow coding style.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13595 6f19259b-4bc3-4df7-8a09-765794883524
2012-08-07 00:44:28 +00:00
c85c6de761
Fix build fail for GCC
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13559 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-26 07:44:26 +00:00
73c82041dc
Fixed issues:
...
1.Refine the logic about show different attribute.
2.Refine the logic about allocate memory for variable name and data.
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13558 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-26 07:15:31 +00:00
2c46dd239b
ShellPkg: update pci enumeration routine for platforms with multiple pci segments.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen eugene@hp.com
reviewed-by: jaben carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13524 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-11 19:08:40 +00:00
9d8fa791f5
ShellPkg: Fix recursion when deleting all variables.
...
Signed-off-by: Dong Eric <eric.dong@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13484 6f19259b-4bc3-4df7-8a09-765794883524
2012-07-04 01:14:07 +00:00
60448d9b8d
ShellPkg: Fix en-US characters that are outside the Basic Latin character set range
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Samer El-Haj-Mahmoud elhaj@hp.com
reviewed-by: Jaben Carsey jaben.carsey@intel.com
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13448 6f19259b-4bc3-4df7-8a09-765794883524
2012-06-12 17:22:19 +00:00
46cb4043a1
ShellPkg: Fix display of 64-bit BARs in PCI dump on 32-bit systems.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen eugene@hp.com
reviewed-by: jaben carsey jaben.carsey@intel.com
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13381 6f19259b-4bc3-4df7-8a09-765794883524
2012-05-30 17:38:23 +00:00
ea4fe84fe5
Update comments in DmpStore.c to be more suitable.
...
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13223 6f19259b-4bc3-4df7-8a09-765794883524
2012-04-27 01:18:41 +00:00
8d3000031d
Enhance code to more safely and follow coding style.
...
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13221 6f19259b-4bc3-4df7-8a09-765794883524
2012-04-26 02:00:30 +00:00
187cb3dd8d
Add SMBIOS 2.7.1 support to SmbiosView command.
...
Signed-off-by: lzeng14
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13101 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-15 08:29:49 +00:00
94020bb40f
Improve robustness when scanning PCI Option ROM.
...
Signed-off-by: rsun3
Reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13095 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-14 03:17:17 +00:00
50b43b1506
ShellPkg: Fix ICC11 build failure.
...
Eliminate SHELL_STATUS and EFI_STATUS mismatch.
Signed-off-by: jcarsey
Reviewed-by: lgao4
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13075 6f19259b-4bc3-4df7-8a09-765794883524
2012-03-05 17:51:52 +00:00
4641e70095
Fix type 19 print to match SBMIOS 2.7.
...
Note: Some one should port smbiosview to use the edk2 MdePkg/Include/IndustryStandard/SmBios.h and not carry it's own definitions, that are now out of date.
signed-off-by:andrewfish
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12971 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-31 00:18:25 +00:00
94753eb940
Fix clang compiler warning.
...
signed-off-by:andewfish
reviewed-by:jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12968 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-30 19:06:17 +00:00
8bb7441edd
ShellPkg: Allow for format character strings to be typed in editor without having effect on editor screen.
...
signed-off-by: jcarsey
reviewed-by: leegrosenbaum
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12965 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-30 18:44:41 +00:00
479f85bb72
ShellPkg: add more parenthesis to bcfg command.
...
signed-off-by: jcarsey
reviewed-by: mlmitchel
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12963 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-30 17:31:23 +00:00
cff7bffbb5
ShellPkg: Add support for adding optional data to the bcfg command in debug profile.
...
signed-off-by: jcarsey
reviewed-by: leegrosenbaum
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12961 6f19259b-4bc3-4df7-8a09-765794883524
2012-01-27 18:53:18 +00:00
2e5c97edcd
ShellPkg: Fix handling of empty files in Hexedit
...
Currently hexedit thinks all files that are non-existent (i.e. new) or empty must be a memory error since the pointer is checked, but the file size is not referenced.
Signed-off-by: jcarsey
Reviewed-by: jljusten
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12797 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-29 15:37:04 +00:00
d16efcae82
Shellpkg: Add support for filenames with spaces.
...
This patch changes the file redirection support to allow for quote delimited filenames that contain spaces and updates the edit command to allow spaces in the filename. This also properly fails for attempts to redirect to "" (empty quotes).
signed-off-by: jcarsey
reviewed-by: jliu66
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12685 6f19259b-4bc3-4df7-8a09-765794883524
2011-11-11 16:45:19 +00:00
532691c8ba
ShellPkg: Add checking for memory allocation and pointer returns from functions.
...
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12540 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-14 19:21:13 +00:00
4d10ab79d7
ShellPkg: Add checks for NULL pointers.
...
This adds lots of pointer verification with ASSERTs only used when the condition should be impossible and never for memory allocation.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12524 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-10 20:36:44 +00:00
ecae51177e
ShellPkg: Add checks for NULL pointers.
...
This adds lots of pointer verification with ASSERTs only used when the condition should be impossible and never for memory allocation.
signed-off-by: jcarsey
reviewed-by: geekboy15a
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12523 6f19259b-4bc3-4df7-8a09-765794883524
2011-10-10 20:32:17 +00:00
bca163ff11
Clean up the private GUID definition in module Level.
...
Signed-off-by: lgao4
Reviewed-by: jcarsey
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@12394 6f19259b-4bc3-4df7-8a09-765794883524
2011-09-21 01:56:00 +00:00