Qiu Shumin
c17c4a1ffd
ShellPkg\Application\Shell: Clean start row information after the console has been Reset or SetMode.
...
OriginalStartRow and CurrentStartRow should be initialized after new mode is set.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Signed-off-by: Eric Jin <eric.jin@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17584 6f19259b-4bc3-4df7-8a09-765794883524
2015-06-09 02:29:37 +00:00
Qiu Shumin
654a012ba5
ShellPkg: Refine the logic about allocating memory for variable name and data.
...
The run time service 'QueryVariableInfo' is not proper to be used to get the variable name size. This patch refine the logic about allocating memory for variable name and data.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17201 6f19259b-4bc3-4df7-8a09-765794883524
2015-04-27 03:09:34 +00:00
Olivier Martin
88ff5ba793
ShellPkg: Added newline at the end of source files
...
Some compilers (such as ARM toolchain) complain if there is
no new line at the end of a source file.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17105 6f19259b-4bc3-4df7-8a09-765794883524
2015-04-02 11:32:32 +00:00
Joe Peterson
d08a546471
Shellpkg: Fix spelling errors in Shell.c/Shell.h comments
...
This patch fixes spelling errors in comments. No functional change.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Joe Peterson <joe.peterson@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16816 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-06 22:25:05 +00:00
Jaben Carsey
a8f98806ed
ShellPkg: command help with -? flag is not working and it gives too many arguments error message.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16815 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-06 21:03:28 +00:00
Tapan Shah
c011b6c9e2
ShellPkg: Standardized HP Copyright Message String
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16759 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-04 22:25:01 +00:00
Jaben Carsey
fe8ec3dd93
ShellPkg: Revert 16720 and 16734.
...
I will submit a new patch.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16758 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-04 16:46:59 +00:00
Jaben Carsey
a95cf8f0f4
ShellPkg: Revert 16720 and 16734.
...
I will submit a new patch.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16757 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-04 16:39:04 +00:00
Jaben Carsey
432bf14cf1
ShellPkg: cast return value to correct type based on what we passed in.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Joe Peterson <joe.peterson@intel.com >
Reviewed-by: Shumin Qiu <shumin.qiu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16734 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-04 01:23:14 +00:00
Qiu Shumin
69c569bf55
ShellPkg: Fix typos.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16733 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-04 01:15:17 +00:00
Tapan Shah
7df7964379
ShellPkg: Update Shell.uni file with a better general command response output.
...
1. Updates to the general command response output.
2. Re-wording some of common shell messages.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16725 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-03 18:37:58 +00:00
Jaben Carsey
0a82f7af9b
ShellPkg: Refactor out a now-redundant function
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Joe Peterson <joe.peterson@intel.com >
Reviewed-by: Shumin Qiu <shumin.qiu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16720 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-03 16:50:12 +00:00
Jaben Carsey
5e737e835e
ShellPkg: Add quotes around NSH index argument replacement
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Joe Peterson <joe.peterson@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16699 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-02 21:02:56 +00:00
Qiu Shumin
3ab016b2a3
ShellPkg: Fix typos.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16683 6f19259b-4bc3-4df7-8a09-765794883524
2015-02-02 01:51:59 +00:00
Jaben Carsey
7cc7022dfc
ShellPkg: Refactor quote and escape search to use new function
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Signed-off-by: Joe Peterson <joe.peterson@intel.com >
Reviewed-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16682 6f19259b-4bc3-4df7-8a09-765794883524
2015-01-30 16:29:20 +00:00
Jaben Carsey
00534bc3e2
ShellPkg: Refactor Split search to generic function
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Signed-off-by: Joe Peterson <joe.peterson@intel.com >
Reviewed-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16681 6f19259b-4bc3-4df7-8a09-765794883524
2015-01-30 16:28:22 +00:00
Jaben Carsey
14030c5c85
ShellPkg: refine command line parsing
...
Correctly divide up parameters for Argc/Argv including quote ("), escape (^), and space ( ) processing.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Joe Peterson <joe.peterson@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16673 6f19259b-4bc3-4df7-8a09-765794883524
2015-01-27 18:56:36 +00:00
Jaben Carsey
fdd52bde51
ShellPkg: Always remove non-defined environment variable
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Joe Peterson <joe.peterson@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16672 6f19259b-4bc3-4df7-8a09-765794883524
2015-01-27 18:53:27 +00:00
Qiu Shumin
ecd07f3737
ShellPkg: Refine the fomat in INF/DEC files to follow spec.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16634 6f19259b-4bc3-4df7-8a09-765794883524
2015-01-22 01:44:11 +00:00
Daryl McDaniel
ae591c14b3
MdeModulePkg, MdePkg, NetworkPkg, OvmfPkg, PerformancePkg, ShellPkg: Library Migration.
...
Move libraries from ShellPkg into MdeModulePkg and MdePkg.
The following libraries are being migrated out of ShellPkg in order to make
their functionality more widely available.
• PathLib: Incorporate into MdePkg/Library/BaseLib
• FileHandleLib: MdePkg/Library/UefiFileHandleLib
• BaseSortLib: MdeModulePkg/Library/BaseSortLib
• UefiSortLib: MdeModulePkg/Library/UefiSortLib
Diffs showing file changes are in the attached file, LibMigration.patch.
A description of the changes follows:
• Move ShellPkg/Include/Library/FileHandleLib.h to MdePkg/Include/Library/FileHandleLib.h
• Move ShellPkg/Include/Library/SortLib.h to MdeModulePkg/Include/Library/SortLib.h
• Move ShellPkg/Library/BaseSortLib to MdeModulePkg/Library/BaseSortLib
• Move ShellPkg/Library/UefiSortLib to MdeModulePkg/Library/UefiSortLib
• Move ShellPkg/Library/BasePathLib/BasePathLib.c to MdePkg/Library/BaseLib/FilePaths.c
• Merge ShellPkg/Include/Library/PathLib.h into MdePkg/Include/Library/BaseLib.h
• Delete ShellPkg/Library/BasePathLib; Includes BasePathLib.c and BasePathLib.inf
• NetworkPkg/NetworkPkg.dsc
• PerformancePkg.dsc
• OvmfPkg/OvmfPkgX64.dsc
• OvmfPkg/OvmfPkgIa32X64.dsc
• OvmfPkg/OvmfPkgIa32.dsc
o Update SortLib and FileHandleLib library classes to point to the new library locations.
o Remove PathLib library class and make sure that BaseLib is described.
• MdeModulePkg/MdeModulePkg.dec
o Add SortLib library class
• MdePkg/MdePkg.dec
o Add FileHandleLib library class
o Add PcdUefiFileHandleLibPrintBufferSize PCD
• MdePkg/Library/BaseLib/BaseLib.inf
o Add FilePaths.c to [Sources]
• MdePkg/Include/Library/BaseLib.h
o Update file description to include "file path functions"
• ShellPkg/ShellPkg.dsc
o Change PACKAGE_GUID to { C1014BB7-4092-43D4-984F-0738EB424DBF }
o Update PACKAGE_VERSION to 1.0
o Update SortLib and FileHandleLib library classes to point to the new library locations.
o Remove PathLib library class and make sure that BaseLib is described.
o Remove ShellPkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf from [Components]
• ShellPkg/ShellPkg.dec
o Update PLATFORM_VERSION to 1.0
o Remove declarations of the FileHandleLib, SortLib, and PathLib Library Classes
o Update comment for the PcdShellPrintBufferSize PCD.
• ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
• ShellPkg/Application/Shell/Shell.inf
o Remove PathLib from [LibraryClasses]
• ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.h
• ShellPkg/Application/Shell/Shell.h
o Remove #include <Library/PathLib.h>
• ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
o Add PathLib to [LibraryClasses]
• ShellPkg/Library/UefiShellLevel1CommandsLib/If.c
o Remove #include <Library/PathLib.h>
• ShellPkg/Application/ShellSortTestApp/ShellSortTestApp.inf
o Add MdeModulePkg/MdeModulePkg.dec to [Packages]
• MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
• MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
o Replace ShellPkg.dec with MdeModulePkg.dec in [Packages]
• MdeModulePkg/Library/UefiSortLib/UefiSortLib.c
o Remove #include <ShellBase.h>
o Define USL_FREE_NON_NULL() to replace SHELL_FREE_NON_NULL()
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daryl McDaniel <daryl.mcdaniel@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16601 6f19259b-4bc3-4df7-8a09-765794883524
2015-01-13 01:04:07 +00:00
Qiu Shumin
4243567133
ShellPkg: Check the unrecognized environment variable name before it is removed from command line.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16563 6f19259b-4bc3-4df7-8a09-765794883524
2014-12-31 01:31:00 +00:00
Qiu Shumin
6f6792b820
ShellPkg: Add code to handle the split ('|') in a double-quoted string.
...
This patch update the code in function 'ContainsSplit', and make 'ContainsSplit' depend on 'FindNextInstance'. So we move 'FindNextInstance' in front of 'ContainsSplit'.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16560 6f19259b-4bc3-4df7-8a09-765794883524
2014-12-26 08:22:35 +00:00
Jaben Carsey
75e34de46c
ShellPkg: Fix Meta Data misspelling
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16195 6f19259b-4bc3-4df7-8a09-765794883524
2014-10-03 15:49:59 +00:00
Ruiyu Ni
a308e0588b
Roll back check in r15180 which caused the shell always returns EFI_ABORTED no matter what exit-code is specified for "exit" command.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Carsey Jaben <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16127 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-18 01:58:03 +00:00
Qiu Shumin
4b6b543e77
ShellPkg: Fix the support for command line comments.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16126 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-18 01:21:01 +00:00
Ni Ruiyu
75eb337f60
ShellPkg: Do TrimSpace again after StdIn, StdOut, and StdErr are set up.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ni Ruiyu <ruiyu.ni@intel.com >
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16123 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-17 08:41:31 +00:00
Qiu Shumin
323d3d1118
ShellPkg: Replace the usage of StrnCpy with CopyMem to avoid potential buffer overflow and refine the code style.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Signed-off-by: Yao Jiewen <jiewen.yao@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16083 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-10 01:03:43 +00:00
Qiu Shumin
cc72674b58
ShellPkg: Replace assignment statement with 'StrnCpy' to append terminal NULL character in a string.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16064 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-09 01:47:19 +00:00
Jaben Carsey
a753677e33
ShellPkg: Not add redundant quotes any longer to parameters with spaces.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: : Qiu Shumin <shumin.qiu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16062 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-05 02:05:16 +00:00
Qiu Shumin
33fe830841
ShellPkg: Refine the code style and comment.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: : Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16061 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-05 01:01:24 +00:00
Jaben Carsey
7f79b01e8e
ShellPkg: Refactor string manipulation
...
This patch replaces StrCpy with StrnCpy or refactors out the usage of StrCpy through some other means.
This patch replaces StrCat with StrnCat or refactors out the usage of StrCat through some other means.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16038 6f19259b-4bc3-4df7-8a09-765794883524
2014-09-02 20:17:38 +00:00
Qiu Shumin
de4caceb8b
ShellPkg: Remove 'STATIC' from function declarations to avoid source level debugging problem.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: : Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15975 6f19259b-4bc3-4df7-8a09-765794883524
2014-08-29 01:30:43 +00:00
Jaben Carsey
5eadb80f09
ShellPkg: leave quotes around params
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15875 6f19259b-4bc3-4df7-8a09-765794883524
2014-08-21 22:13:08 +00:00
Chris Phillips
d41a79a0da
ShellPkg: Add support for UEFI Shell 2.1 spec command line comments
...
Example:
Shell> echo "You are ^#1!" # Testing echo
You are #1 !
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15871 6f19259b-4bc3-4df7-8a09-765794883524
2014-08-21 20:18:47 +00:00
Chris Phillips
838b31a68c
ShellPkg: Fix EFI_SHELL_PROTOCOL to contain new members from UEFI Shell 2.1 spec
...
- Removes EFI_SHELL_PROTOCOL21
- Adds RegisterGuidName, GetGuidName, GetGuidFromName, and GetEnvEx to EFI_SHELL_PROTOCOL
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15818 6f19259b-4bc3-4df7-8a09-765794883524
2014-08-18 20:00:08 +00:00
Qiu Shumin
f5ba4007ae
ShellPkg: Fix comments. Refine code style.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15815 6f19259b-4bc3-4df7-8a09-765794883524
2014-08-18 00:48:22 +00:00
Jaben Carsey
09fd5328a4
Updates the UEFI Shell to produce the new protocol with additional 4 functions.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
Reviewed by: Daryl McDaniel <daryl.mcdaniel@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15764 6f19259b-4bc3-4df7-8a09-765794883524
2014-08-06 16:18:38 +00:00
Laszlo Ersek
5967886d58
ShellPkg: UpdateStdInStdOutStdErr(): append BOM to new unicode file
...
The >> operator redirects stdout to a file, using append mode and unicode
encoding. Write the BOM when redirection happens to a new file (which
starts out empty).
This makes the >> operator behave similarly to the > operator, when the
redirection target doesn't exist originally:
OutUnicode && OutAppend && FileSize == 0 // >> to new unicode file
vs.
OutUnicode && !OutAppend // > to any unicode file
(Note that (FileSize == 0) is equivalent to "new file" in this context,
due to the earlier "Check that filetypes (Unicode/Ascii) do not change
during an append".)
Reported-by: Lowell Dennis <Lowell_Dennis@Dell.com >
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15725 6f19259b-4bc3-4df7-8a09-765794883524
2014-07-31 15:44:43 +00:00
Laszlo Ersek
94c2a04449
ShellPkg: UpdateStdInStdOutStdErr(): extract WriteFileTag()
...
Drop TagBuffer in the process.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15724 6f19259b-4bc3-4df7-8a09-765794883524
2014-07-31 15:44:30 +00:00
Eric Dong
0d807dae4a
Update code to support VS2013 tool chain.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15704 6f19259b-4bc3-4df7-8a09-765794883524
2014-07-29 02:00:55 +00:00
Eric Dong
81cd2f536e
Refine code to make it more safely.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15593 6f19259b-4bc3-4df7-8a09-765794883524
2014-06-26 01:38:46 +00:00
Jaben Carsey
0c41d28e59
ShellPkg: replace unrecognized Environment Variables with empty quotes so commands or applications know something existed.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15547 6f19259b-4bc3-4df7-8a09-765794883524
2014-05-22 22:06:41 +00:00
Qiu Shumin
b5ce69c3da
Update the comments for function 'InternalShellExecuteDevicePath' in ShellProtocol.c to make it consistent with parameter names.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qiu Shumin <shumin.qiu@intel.com >
Reviewed-by: Jaben carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15546 6f19259b-4bc3-4df7-8a09-765794883524
2014-05-22 08:32:50 +00:00
Olivier Martin
cd39fe082c
ShellPkg: Do not mix status when executing a command
...
The function InternalShellExecuteDevicePath() did not differentiate an error occuring during the preparation of an image and an error occurring during its execution.
A use case of the issue was when a EFI application was called in a EFI Shell script. If the EFI application was returning an error then the NSH script stopped its execution. While the EFI Shell specification says the script should continue its execution (see 4.2 Error Handling).
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com >
Reviewed-by: Jaben Carsey <Jaben.Carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15523 6f19259b-4bc3-4df7-8a09-765794883524
2014-05-13 21:16:42 +00:00
Jaben Carsey
bbf904d154
ShellPkg: Fix using root of drive
...
This allows near complete use of drive roots “fs0:” and “fs0:\” as directories and arguments to commands.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
Reviewed-by: Tapan Shah <tapandshah@hp.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15463 6f19259b-4bc3-4df7-8a09-765794883524
2014-04-11 19:15:02 +00:00
Chris Phillips
e9d19a80af
ShellPkg: Fix command-line parsing to start with Argv[0] when comparing passed-in options
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-By: Olivier Martin <Olivier.Martin@arm.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15432 6f19259b-4bc3-4df7-8a09-765794883524
2014-04-04 13:45:36 +00:00
Jaben Carsey
d0a5723f50
ShellPkg: Allow opening of root drive nodes
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15424 6f19259b-4bc3-4df7-8a09-765794883524
2014-03-31 21:06:13 +00:00
Jaben Carsey
4b5168d852
ShellPkg: Fix potential memory leak when failing to fully create a structure
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com >
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15423 6f19259b-4bc3-4df7-8a09-765794883524
2014-03-31 20:43:04 +00:00
Chris Phillips
d6e88a6c60
ShellPkg: Fix file system change issue that results in ASSERT
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chris Phillips <chrisp@hp.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15406 6f19259b-4bc3-4df7-8a09-765794883524
2014-03-27 18:21:43 +00:00
Shumin Qiu
4f344fffc7
1.Add code to check the pointer 'CorrectedPath' in Ls.c line 460 before referenced. 2.Not use explicit comparisons to TRUE or FALSE for Boolean variable in Ls.c. 3.Add doxygen tags in comment and return type for 'ToLower' in ShellProtocol.c.
...
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shumin Qiu <shumin.qiu@intel.com >
Reviewed-by: Jaben Carsey <Jaben.carsey@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15320 6f19259b-4bc3-4df7-8a09-765794883524
2014-03-07 01:06:37 +00:00