Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						be409b6756 
					 
					
						
						
							
							BaseTools: Replace PCD type strings with predefined constant  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-05-02 14:59:25 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						eece4292ac 
					 
					
						
						
							
							BaseTools: DataType - cleanup list constants  
						
						 
						
						... 
						
						
						
						remove unused ones
convert lists used for membership testing to sets
use shared ones not local ones
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-05-02 14:59:20 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						88c6c1b64c 
					 
					
						
						
							
							BaseTools: Define and use a set for common list  
						
						 
						
						... 
						
						
						
						share a set for both PEI module types
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-05-02 14:56:33 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						8bb63e377b 
					 
					
						
						
							
							BaseTools: replace string constants used for module types  
						
						 
						
						... 
						
						
						
						replace raw strings in the code (note: except UPT) with constants.
SUP_MODULE_BASE was 'BASE'
SUP_MODULE_SEC was 'SEC'
SUP_MODULE_PEI_CORE was 'PEI_CORE'
SUP_MODULE_PEIM was 'PEIM'
SUP_MODULE_DXE_CORE was 'DXE_CORE'
SUP_MODULE_DXE_DRIVER was 'DXE_DRIVER'
SUP_MODULE_DXE_RUNTIME_DRIVER was 'DXE_RUNTIME_DRIVER'
SUP_MODULE_DXE_SAL_DRIVER was 'DXE_SAL_DRIVER'
SUP_MODULE_DXE_SMM_DRIVER was 'DXE_SMM_DRIVER'
SUP_MODULE_UEFI_DRIVER was 'UEFI_DRIVER'
SUP_MODULE_UEFI_APPLICATION was 'UEFI_APPLICATION'
SUP_MODULE_USER_DEFINED was 'USER_DEFINED'
SUP_MODULE_SMM_CORE was 'SMM_CORE'
SUP_MODULE_MM_STANDALONE was 'MM_STANDALONE'
SUP_MODULE_MM_CORE_STANDALONE was 'MM_CORE_STANDALONE'
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-05-02 14:56:31 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Yunhua Feng 
							
						 
					 
					
						
						
							
						
						4085777757 
					 
					
						
						
							
							BaseTools: Fix one invalid change in  6be94743 
						
						 
						
						... 
						
						
						
						Roll back one change in 6be94743 , it was updated incorrect.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-26 14:49:56 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						34c006cd47 
					 
					
						
						
							
							BaseTools: AutoGen - use defaultdict to auto initialize  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-26 14:44:36 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						992fbe3519 
					 
					
						
						
							
							BaseTools: AutoGen - use dafultdict instead of dict  
						
						 
						
						... 
						
						
						
						since we manually make each entry a set(), just use defaultdict(set)
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-26 14:44:35 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						6fcd911c32 
					 
					
						
						
							
							BaseTools: AutoGen - remove unused variables.  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-26 14:43:25 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						fe0a9af881 
					 
					
						
						
							
							BaseTools: AutoGen - remove dictionary populated, but never accessed  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-26 14:43:24 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						6b1f2cf41a 
					 
					
						
						
							
							BaseTools: Autogen - replace string constants with those from DataType  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-26 14:36:05 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						656d2539be 
					 
					
						
						
							
							BaseTools: replace 'UINT8','UINT16','UINT32','UINT64','VOID*' with shared constants.  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-23 11:11:20 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						9eb87141ec 
					 
					
						
						
							
							BaseTools: refactor and remove un-needed use of .keys() on dictionaries  
						
						 
						
						... 
						
						
						
						sometimes just delete it.
sometimes the loop needed .values() instead
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-18 22:15:36 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						55c84777ee 
					 
					
						
						
							
							BaseTools: use predefined constants instead of local strings  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-18 22:15:35 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						128d435f5e 
					 
					
						
						
							
							BaseTools: fix None comparisons  
						
						 
						
						... 
						
						
						
						when comparing a list/string against None and empty, just compare the object.
when comparing against None, dont use !=, ==, <>
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-17 20:49:32 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						72fbe88d72 
					 
					
						
						
							
							BaseTools: reduce list usage when not needed  
						
						 
						
						... 
						
						
						
						remove not needed lists.  some were just counted and others
should be sets.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-17 20:48:53 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						1563349a96 
					 
					
						
						
							
							BaseTools: use set instead of list for a variable to be used with in  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-17 20:48:53 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						066c71544e 
					 
					
						
						
							
							BaseTools: skip updating temporary variable.  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-17 20:48:52 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						1530ceda05 
					 
					
						
						
							
							BaseTools: no need to save the data  
						
						 
						
						... 
						
						
						
						It's never accessed.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-17 20:48:52 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						4d3b9389e7 
					 
					
						
						
							
							BaseTools: use existing shared variable  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-17 20:48:51 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Yonghong Zhu 
							
						 
					 
					
						
						
							
						
						8b0e67821b 
					 
					
						
						
							
							BaseTools: Fix the build error caused by  eca980c0c8 
						
						 
						
						... 
						
						
						
						Roll back the fixed at build pcd collection to include the pcd in
Module and Library.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com >
Tested-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Liming Gao <liming.gao@intel.com > 
						
						
					 
					
						2018-04-11 09:55:41 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Yonghong Zhu 
							
						 
					 
					
						
						
							
						
						f9fa014ee0 
					 
					
						
						
							
							BaseTools: Fix two cases that use GUID CName as PCD Value  
						
						 
						
						... 
						
						
						
						1. use CName format in components section:
  [Components]
   TestPkg/TestDriver.inf {
     <PcdsFixedAtBuild>
      PcdToken.PcdName |{GUID(TestGuid)}|VOID*|16
  }
2. Use Guid CName format in INF and the Guid is defined in the DEC
file but not write in driver's [Guids] section.
    PcdToken.PcdName  | {GUID(TestGuid)}
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com > 
						
						
					 
					
						2018-04-10 13:59:06 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Yonghong Zhu 
							
						 
					 
					
						
						
							
						
						c33081c912 
					 
					
						
						
							
							BaseTools: Fix the bug for VOID* pcd max size from component section  
						
						 
						
						... 
						
						
						
						When the Pcd defined in components section, its value's size is larger
than the value's size in [pcd] section, it cause build error, because
original code use the size get in [pcd] section as max size.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com > 
						
						
					 
					
						2018-04-10 13:58:14 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Yonghong Zhu 
							
						 
					 
					
						
						
							
						
						f7b31aa540 
					 
					
						
						
							
							BaseTools: Fix size override issue for Void* Patchable pcd  
						
						 
						
						... 
						
						
						
						when multiple driver link same library, and the drivers override the pcd
to different value in the DSC component section, it cause the pcd size
incorrect.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com > 
						
						
					 
					
						2018-04-10 13:56:43 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Yonghong Zhu 
							
						 
					 
					
						
						
							
						
						eca980c0c8 
					 
					
						
						
							
							BaseTools: Fix a bug for Size incorrect of Void* Fixatbuild Pcd  
						
						 
						
						... 
						
						
						
						when driver link library and there have pcd override in DSC component
section, in the library autogen file, the pcd's size is incorrect, the
size value is from DSC [pcd] section, but not from the override pcd
value that in the [component] section.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com > 
						
						
					 
					
						2018-04-10 13:55:52 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Yonghong Zhu 
							
						 
					 
					
						
						
							
						
						1bfcf64f39 
					 
					
						
						
							
							BaseTools: Fix a bug for VOID* type Fixatbuild Pcd in Library  
						
						 
						
						... 
						
						
						
						The case is a FixedAtBuild VOID* PCD is used from a lib, but is set to a
different sized value in a module INF scope <PcdsFixedAtBuild> section.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com > 
						
						
					 
					
						2018-04-10 13:54:13 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						98120f5fe2 
					 
					
						
						
							
							BaseTools: refactor and remove out of date use of .keys()  
						
						 
						
						... 
						
						
						
						this is no longer required to make dictionary objects iterable.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:16 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						674e2014ce 
					 
					
						
						
							
							BaseTools: GenC - move content from both parts of if/else  
						
						 
						
						... 
						
						
						
						move identical lines out of both if and else and move 1 level up.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:16 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						d0ef841c8e 
					 
					
						
						
							
							BaseTools: change more list to set  
						
						 
						
						... 
						
						
						
						potentially accelerate "in" testing
remove uncalled function
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:15 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						e1ed31e65e 
					 
					
						
						
							
							BaseTools: remove unneeded function call  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:15 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						29189291e5 
					 
					
						
						
							
							BaseTools: change another list to set  
						
						 
						
						... 
						
						
						
						potentially accelerate "in" testing which is the use for this variable
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:14 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						339fe8dd6a 
					 
					
						
						
							
							BaseTools: optimize buildoptions loop  
						
						 
						
						... 
						
						
						
						change a dict to a double defaultdict to prevent needing to seed innter values.
move "Value" determination under a conditional continue statement
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:14 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						6be947438f 
					 
					
						
						
							
							BaseTools: simplify testing for existance and containing data  
						
						 
						
						... 
						
						
						
						and remove a duplicate "if" block from 6 lines up.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:13 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						ac55e47818 
					 
					
						
						
							
							BaseTools: change list to set  
						
						 
						
						... 
						
						
						
						Order is irelevant
duplication is auto-prevented
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:13 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						d98cce8e63 
					 
					
						
						
							
							BaseTools: remove unused variables  
						
						 
						
						... 
						
						
						
						some were populated, but never used after.
some were never used.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:12 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						6b26dd7165 
					 
					
						
						
							
							BaseTools: replace a dict with a set  
						
						 
						
						... 
						
						
						
						As we never use the values, just keep the keys in a set.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:12 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						b74b419a01 
					 
					
						
						
							
							BaseTools: sets are faster to check via "in" due to hashing  
						
						 
						
						... 
						
						
						
						switch list to set:
1)we dont care about order
2)we only check for membership.
then remove ".keys()" from dict looping:
allow generators opportunity to optimize
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:11 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						a993dc03ab 
					 
					
						
						
							
							BaseTools: defaultdict(set) allows us to just add to the set  
						
						 
						
						... 
						
						
						
						New sets will get created automatically when needed
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-10 10:05:11 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						f8c0a004a5 
					 
					
						
						
							
							BaseTools: small cleanup  
						
						 
						
						... 
						
						
						
						just deleting else: then pass as they have no effect.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-08 16:33:04 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						ff5635e9ac 
					 
					
						
						
							
							BaseTools: Autogen - change from list to set  
						
						 
						
						... 
						
						
						
						by changing from list to set(), we can skip all the preprocessing
to prevent duplication and we dont need to convert to a set() later
on for each use
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-08 16:33:03 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						bfc8f5667a 
					 
					
						
						
							
							BaseTools: remove redundant check  
						
						 
						
						... 
						
						
						
						The RegEx matches begining and end of the string, dont then check length.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-08 15:34:12 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						1f26f5fdb9 
					 
					
						
						
							
							BaseTools: AutoGen - use the new shared RegEx  
						
						 
						
						... 
						
						
						
						Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-08 15:34:11 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						c8802c3dcc 
					 
					
						
						
							
							BaseTools: Autogen - move RegEx compile  
						
						 
						
						... 
						
						
						
						compile each RegEx once not in loops/functions
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-08 15:34:10 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						9006a2c6a3 
					 
					
						
						
							
							BaseTools - AutoGen - replace custom dictionary class with python standard one  
						
						 
						
						... 
						
						
						
						We have a custom ordered dictionary class.  works fine with python OrderedDict version.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-08 14:50:16 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						5060928b12 
					 
					
						
						
							
							BaseTools: Use local variable for list of constants.  
						
						 
						
						... 
						
						
						
						instead of listing in multiple places, use a single list.
Cc: Liming Gao <liming.gao@intel.com >
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-04-08 14:50:14 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						0944818a19 
					 
					
						
						
							
							BaseTools: no need to do int() API work for it  
						
						 
						
						... 
						
						
						
						int() with base=0 will already auto determine base from preceeding 0x/0X
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-03-30 09:16:01 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						4231a8193e 
					 
					
						
						
							
							BaseTools: Remove equality operator with None  
						
						 
						
						... 
						
						
						
						replace "== None" with "is None" and "!= None" with "is not None"
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-03-30 08:25:13 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						018f7b827f 
					 
					
						
						
							
							BaseTools: Use precompiled RegExp  
						
						 
						
						... 
						
						
						
						avoid recompiling the regular expression for each use in a while loop
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-03-29 16:20:22 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						b24e99f7c4 
					 
					
						
						
							
							BaseTools: Autogen - modify to use standard parent/child class relationships  
						
						 
						
						... 
						
						
						
						use __new__ and __init__ to create/manage/initialize objects in standard flow.
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-03-27 09:02:30 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								BobCF 
							
						 
					 
					
						
						
							
						
						0a4f2d4869 
					 
					
						
						
							
							BaseTool: Fixed the issue of empty PcdDB.  
						
						 
						
						... 
						
						
						
						If there is no dynamic pcds, there should be DB header
in the Pcd DataBase.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bob Feng <bob.c.feng@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com > 
						
						
					 
					
						2018-03-23 11:23:50 +08:00  
					
					
						 
						
						
							
							
							 
							
							
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Carsey, Jaben 
							
						 
					 
					
						
						
							
						
						4d83616f9d 
					 
					
						
						
							
							BaseTools: StrGather remove functions no one calls  
						
						 
						
						... 
						
						
						
						simplify the code and remove functions not called anymore
Cc: Yonghong Zhu <yonghong.zhu@intel.com >
Cc: Liming Gao <liming.gao@intel.com >
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com > 
						
						
					 
					
						2018-03-21 13:39:23 +08:00