Dong Guo 
							
						 
					 
					
						
						
							
						
						e3ff137e36 
					 
					
						
						
							
							Add missing parameter comment in AddPubKeyInStore()  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Dong, Eric <eric.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15426  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-04-01 06:02:10 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						3a4b498ee1 
					 
					
						
						
							
							SecurityPkg Variable: Add NULL pointer check.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15409  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-03-28 02:47:46 +00:00 
						 
				 
			
				
					
						
							
							
								Dong Guo 
							
						 
					 
					
						
						
							
						
						9a12e5825a 
					 
					
						
						
							
							Calculate enough space for 2 variables (public key and variable data) instead of directly setting them 1 by 1.  
						
						... 
						
						
						
						Fixed a bug in public key reclaim().
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Yao Jiewen <jiewen.yao@intel.com >
Reviewed-by: Zeng, Star <star.zeng@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15404  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-03-27 10:54:23 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						b2bd493edb 
					 
					
						
						
							
							MdeModulePkg/SecurityPkg Variable: Calculate enough space for PlatformLang and Lang variables and use PcdUefiVariableDefaultLangDeprecate to turn off auto update between PlatformLang and Lang variables.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15388  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-03-25 06:56:55 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						9bc5dabb10 
					 
					
						
						
							
							MdeModulePkg/SecurityPkg Variable: Return error status to avoid inconsistency between PlatformLang and Lang.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15340  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-03-20 02:07:48 +00:00 
						 
				 
			
				
					
						
							
							
								Dong Guo 
							
						 
					 
					
						
						
							
						
						25da08c8b2 
					 
					
						
						
							
							Fix the return value bug when updating public key database variable failure.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Yao Jiewen <jiewen.yao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15339  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-03-19 03:12:57 +00:00 
						 
				 
			
				
					
						
							
							
								Dong Guo 
							
						 
					 
					
						
						
							
						
						4345d16427 
					 
					
						
						
							
							Remove unnecessary dependency in variable driver.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dong Guo <guo.dong@intel.com >
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Gao, Liming <liming.gao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15332  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-03-17 08:23:54 +00:00 
						 
				 
			
				
					
						
							
							
								Gao, Liming 
							
						 
					 
					
						
						
							
						
						201edad327 
					 
					
						
						
							
							Update Module BaseName to avoid the same name.  
						
						... 
						
						
						
						Signed-off-by: Gao, Liming <liming.gao@intel.com >
Reviewed-by: Dong, Guo <guo.dong@intel.com >
Reviewed-by: Fu, Siyuan <siyuan.fu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15175  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-01-24 09:32:30 +00:00 
						 
				 
			
				
					
						
							
							
								Eric Dong 
							
						 
					 
					
						
						
							
						
						c93bcb7ef4 
					 
					
						
						
							
							Return to BMM page if parse the file info failed.  
						
						... 
						
						
						
						Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15067  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-01-09 05:59:53 +00:00 
						 
				 
			
				
					
						
							
							
								Eric Dong 
							
						 
					 
					
						
						
							
						
						0b716fd764 
					 
					
						
						
							
							Rollback the patch 15054.  
						
						... 
						
						
						
						Signed-off-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15059  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-01-08 08:21:22 +00:00 
						 
				 
			
				
					
						
							
							
								Eric Dong 
							
						 
					 
					
						
						
							
						
						eff077992a 
					 
					
						
						
							
							Not update the status until parse the file info success.  
						
						... 
						
						
						
						Signed-off-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15054  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2014-01-07 07:34:20 +00:00 
						 
				 
			
				
					
						
							
							
								Fu Siyuan 
							
						 
					 
					
						
						
							
						
						742d9b3a38 
					 
					
						
						
							
							Refine the Secure Boot UI driver to input the GUID and varstroe name when using HiiSetBrowserData/HiiGetBrowserData.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Dong, Eric <eric.dong@intel.com >
Reviewed-by: Dong, Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14897  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-11-25 06:40:34 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						fddbbc661e 
					 
					
						
						
							
							SecurityPkg Variable: Remove mStorageData buffer allocation and use Scratch buffer instead to reduce SMRAM consumption.  
						
						... 
						
						
						
						It can reduce MAX (PcdGet32 (PcdMaxVariableSize), PcdGet32 (PcdMaxHardwareErrorVariableSize)) size of SMRAM consumption.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14855  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-11-18 02:56:04 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						128ef095b0 
					 
					
						
						
							
							MdeModulePkg and SecurityPkg Variable: Optimize the code to reduce some SMRAM consumption during variable reclaiming.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14832  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-11-12 13:31:43 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						7baf3c69c5 
					 
					
						
						
							
							MdeModulePkg and SecurityPkg Variable: Enhance code to use the new variable data instead of old variable data when variable reclaim.  
						
						... 
						
						
						
						It can fix the potential failure to return EFI_OUT_OF_RESOURCES of the second variable set of large variable.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14822  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-11-04 03:13:54 +00:00 
						 
				 
			
				
					
						
							
							
								Fu Siyuan 
							
						 
					 
					
						
						
							
						
						5ecc20b553 
					 
					
						
						
							
							Fix coding style issue.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14755  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-10-09 03:46:46 +00:00 
						 
				 
			
				
					
						
							
							
								Fu Siyuan 
							
						 
					 
					
						
						
							
						
						44446d10b0 
					 
					
						
						
							
							Fix a bug about the “VendorKey” variable update logic.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14746  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-10-08 05:31:28 +00:00 
						 
				 
			
				
					
						
							
							
								jyao1 
							
						 
					 
					
						
						
							
						
						c1d932429e 
					 
					
						
						
							
							Add TPM2 implementation.  
						
						... 
						
						
						
						signed off by: jiewen.yao@intel.com 
reviewed by: guo.dong@intel.com 
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14687  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-09-18 05:31:18 +00:00 
						 
				 
			
				
					
						
							
							
								Fu Siyuan 
							
						 
					 
					
						
						
							
						
						3a186b06f1 
					 
					
						
						
							
							Return EFI_WRITE_PROTECTED when setting KEKDefault, PKDefault, dbDefault, dbxDefault and dbtDefault variable.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14662  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-09-12 05:31:26 +00:00 
						 
				 
			
				
					
						
							
							
								Fu Siyuan 
							
						 
					 
					
						
						
							
						
						74b5fd7a11 
					 
					
						
						
							
							Update the chaining requirements with regards to the Platform Key.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14661  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-09-12 05:26:15 +00:00 
						 
				 
			
				
					
						
							
							
								Fu Siyuan 
							
						 
					 
					
						
						
							
						
						a555940b2d 
					 
					
						
						
							
							Add “VendorKeys” variable for indicating out of band key modification.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14660  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-09-12 05:23:28 +00:00 
						 
				 
			
				
					
						
							
							
								Fu Siyuan 
							
						 
					 
					
						
						
							
						
						a365eed476 
					 
					
						
						
							
							Fix a bug in secure boot configuration driver: Enroll DB/KEK will disable Attempt Secure Boot option.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14590  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-08-22 09:46:03 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						6675a21f14 
					 
					
						
						
							
							MdePkg/MdeModulePkg/SecurityPkg Variable: Forbid creation of non-spec variables in EFI_GLOBAL_VARIABLE namespace.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14560  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-08-19 05:16:45 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						6e67fec07f 
					 
					
						
						
							
							MdeModulePkg/SecurityPkg Variable: If a preexisting variable is rewritten with different attributes, SetVariable() shall not modify the variable and shall return EFI_INVALID_PARAMETER.  
						
						... 
						
						
						
						Two exceptions to this rule:
1. No access attributes specified
2. The only attribute differing is EFI_VARIABLE_APPEND_WRITE
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14552  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-08-16 03:19:45 +00:00 
						 
				 
			
				
					
						
							
							
								Gary Ching-Pang Lin 
							
						 
					 
					
						
						
							
						
						fd64f84f23 
					 
					
						
						
							
							Checks the length of the file name to avoid illegal access.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Ching-Pang Lin <glin@suse.com >
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14531  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-08-08 02:41:37 +00:00 
						 
				 
			
				
					
						
							
							
								Ruiyu Ni 
							
						 
					 
					
						
						
							
						
						863986b3c8 
					 
					
						
						
							
							Update all the code to consume the ConvertDevicePathToText, ConvertDevicePathNodeToText, ConvertTextToDevicePath and ConvertTextToDeviceNode APIs in DevicePathLib.  
						
						... 
						
						
						
						Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Feng Tian <feng.tian@intel.com >
Reviewed-by: Elvin Li <elvin.li@intel.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
Reviewed-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com >
Reviewed-by: Guo Dong <guo.dong@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14505  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-07-26 03:14:08 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						41982ebbc5 
					 
					
						
						
							
							SecurityPkg Variable: Add the check for PcdFlashNvStorageVariableSize <= PcdFlashNvStorageFtwSpareSize.  
						
						... 
						
						
						
						Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14464  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-07-11 08:18:56 +00:00 
						 
				 
			
				
					
						
							
							
								Star Zeng 
							
						 
					 
					
						
						
							
						
						039a40aa3b 
					 
					
						
						
							
							SecurityPkg: Variable drivers robustly handle crashes during Reclaim().  
						
						... 
						
						
						
						PEI variable implementation checks only the variable header signature for validity. This does not seem robust if system crash occurred during previous Reclaim() operation. If the crash occurred while FTW was rewriting the variable FV, the signature could be valid even though the rest of the FV isn't valid.
Solution: PEI variable and early phase(before FTW protocol ready) of DXE variable can check the FTW last write status provided by FaultTolerantWritePei and determine if all or partial variable data has been backed up in spare block, and then use the backed up data.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Liming Gao <liming.gao@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14455  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-07-03 09:09:42 +00:00 
						 
				 
			
				
					
						
							
							
								Laszlo Ersek 
							
						 
					 
					
						
						
							
						
						328e5d8c19 
					 
					
						
						
							
							The list of locked variables is traversed at runtime, hence we must  
						
						... 
						
						
						
						convert the list when transferring from physical to virtual mode.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14425  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-06-17 02:30:42 +00:00 
						 
				 
			
				
					
						
							
							
								Ruiyu Ni 
							
						 
					 
					
						
						
							
						
						e4b7e2c94f 
					 
					
						
						
							
							Revert the changes made in 14403 because it incorrectly changed the EOL.  
						
						... 
						
						
						
						Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14424  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-06-17 02:18:58 +00:00 
						 
				 
			
				
					
						
							
							
								Laszlo Ersek 
							
						 
					 
					
						
						
							
						
						9199cb9c02 
					 
					
						
						
							
							The list of locked variables is traversed at runtime, hence we must  
						
						... 
						
						
						
						convert the list when transferring from physical to virtual mode.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@14403  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-06-14 01:55:12 +00:00 
						 
				 
			
				
					
						
							
							
								lzeng14 
							
						 
					 
					
						
						
							
						
						164a9b6752 
					 
					
						
						
							
							Fix the TOCTOU issue of CommBufferSize itself for SMM communicate handler input.  
						
						... 
						
						
						
						Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14379  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-05-21 02:22:02 +00:00 
						 
				 
			
				
					
						
							
							
								niruiyu 
							
						 
					 
					
						
						
							
						
						6ab9f44138 
					 
					
						
						
							
							Add the EDKII_VARIABLE_LOCK_PROTOCOL implementation in SecurityPkg variable drivers.  
						
						... 
						
						
						
						Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com >
Reviewed-by: Star Zeng <star.zeng@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14378  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-05-20 07:10:10 +00:00 
						 
				 
			
				
					
						
							
							
								sfu5 
							
						 
					 
					
						
						
							
						
						0ba17ade47 
					 
					
						
						
							
							Fix a bug that “SecureBoot” varaible will be updated to NV+AT attribute incorrectly.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ni Ruiyu <ruiyu.ni@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14375  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-05-17 08:05:01 +00:00 
						 
				 
			
				
					
						
							
							
								sfu5 
							
						 
					 
					
						
						
							
						
						ee79ac8d0e 
					 
					
						
						
							
							Pop up error message when user tries to enroll an invalid certificate file into KEK/DB/DBX.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Yao Jiewen <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14373  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-05-17 07:03:49 +00:00 
						 
				 
			
				
					
						
							
							
								lzeng14 
							
						 
					 
					
						
						
							
						
						5e5bb2a9ba 
					 
					
						
						
							
							1. Fix TOCTOU issue in VariableSmm, FtwSmm, FpdtSmm, SmmCorePerformance SMM handler. For VariableSmm, pre-allocate a mVariableBufferPayload buffer with mVariableBufferPayloadSize(match with mVariableBufferPayloadSize in VariableSmmRuntimeDxe) to hold communicate buffer payload to avoid TOCTOU issue.  
						
						... 
						
						
						
						2. Add check to ensure CommBufferPayloadSize not exceed mVariableBufferPayloadSize or is enough to hold function structure in VariableSmm and FtwSmm.
3. Align FtwGetLastWrite() in FaultTolerantWriteSmmDxe.c to FtwGetLastWrite() in FaultTolerantWrite.c.
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14325  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-05-07 05:38:32 +00:00 
						 
				 
			
				
					
						
							
							
								czhang46 
							
						 
					 
					
						
						
							
						
						732d199d8f 
					 
					
						
						
							
							Fix memory overflow & VariableSize check issue for SetVariable append write.  
						
						... 
						
						
						
						Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by  : Fu Siyuan  <siyuan.fu@intel.com >
Reviewed-by  : Dong Guo   <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14323  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-05-02 01:42:39 +00:00 
						 
				 
			
				
					
						
							
							
								lzeng14 
							
						 
					 
					
						
						
							
						
						9d00d20ed4 
					 
					
						
						
							
							1. Use the check IsAddressValid() to prevent SMM communication buffer overflow in SmmVariable, FtwSmm, FpdtSmm, SmmCorePerformance and SmmBaseHelper, and add check to prevent InfoSize overflows in SmmVariableHandler.  
						
						... 
						
						
						
						2. Refine the debug message.
3. Add check to make sure the input VariableName is A Null-terminated string.
4. Use local variable to hold StrSize (VariableName) to avoid duplicated StrSize calculation.
Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com >
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14317  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-25 10:49:45 +00:00 
						 
				 
			
				
					
						
							
							
								sfu5 
							
						 
					 
					
						
						
							
						
						968e143192 
					 
					
						
						
							
							Check for NULL pointer before free it.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting  <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14316  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-25 01:38:06 +00:00 
						 
				 
			
				
					
						
							
							
								czhang46 
							
						 
					 
					
						
						
							
						
						56251c669f 
					 
					
						
						
							
							Fix potential overflow for SetVariable interface  
						
						... 
						
						
						
						Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by  : Guo Dong   <dong.guo@intel.com >
Reviewed-by  : Siyuan Fu  <siyuan.fu@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14305  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-22 08:52:58 +00:00 
						 
				 
			
				
					
						
							
							
								czhang46 
							
						 
					 
					
						
						
							
						
						d17c4eac56 
					 
					
						
						
							
							Fix a potential SMM memory dump issue. If pass communication buffer with DataBuffer to SMM SetVariable which is big enough to cover SMM range. Then GetVariable can dump SMM memory contents. Add more range check for SetVariable  
						
						... 
						
						
						
						Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by  : Dong Guo   <guo.dong@intel.com >
Reviewed-by  : Jiewen Yao <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14292  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-19 01:35:02 +00:00 
						 
				 
			
				
					
						
							
							
								czhang46 
							
						 
					 
					
						
						
							
						
						3a146f2a7d 
					 
					
						
						
							
							Fix SMM Variable driver stack GetVariable return INVALID_PARAMETER when DataSize is bigger than SMM communication buffer.  
						
						... 
						
						
						
						Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by  : Dong Guo   <guo.dong@intel.com >
Reviewed-by  : Fu Siyuan  <siyuan.fu@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14276  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-15 01:56:31 +00:00 
						 
				 
			
				
					
						
							
							
								czhang46 
							
						 
					 
					
						
						
							
						
						0c55190f40 
					 
					
						
						
							
							Update SMM variable DXE driver GetNextVariable interface to comply with UEFI spec  
						
						... 
						
						
						
						VariableNameSize is the returned buffer size. GetNextVariable should behavior correct if it is bigger than SMM communication buffer or less than string size of VariableName. 
Signed-off-by: Chao Zhang <chao.b.zhang@intel.com >
Reviewed-by  : Dong Guo   <guo.dong@intel.com >
Reviewed-by  : Fu Siyuan  <siyuan.fu@intel.com >
Reviewed-by  : Zeng Star  <star.zeng@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14258  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-12 05:59:11 +00:00 
						 
				 
			
				
					
						
							
							
								sfu5 
							
						 
					 
					
						
						
							
						
						a2f2c258d4 
					 
					
						
						
							
							Update secure boot UI driver to handle “reset to default” hot key.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting <ting.ye@intel.com >
Reviewed-by: Yao Jiewen <jiewen.yao@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14257  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-12 01:44:54 +00:00 
						 
				 
			
				
					
						
							
							
								lzeng14 
							
						 
					 
					
						
						
							
						
						3588bb3529 
					 
					
						
						
							
							If DataSize or VariableNameSize is near MAX_ADDRESS, this can cause the computed PayLoadSize to overflow to a small value and pass the check in InitCommunicateBuffer(). To protect against this vulnerability, check DataSize and VariableNameSize to make sure PayloadSize doesn't overflow.  
						
						... 
						
						
						
						Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14252  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-04-08 06:56:08 +00:00 
						 
				 
			
				
					
						
							
							
								sfu5 
							
						 
					 
					
						
						
							
						
						ca5a7d87e3 
					 
					
						
						
							
							Add error handling code to prevent variable store corruption in release build.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting  <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14139  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-02-21 01:35:22 +00:00 
						 
				 
			
				
					
						
							
							
								sfu5 
							
						 
					 
					
						
						
							
						
						5767f22fca 
					 
					
						
						
							
							Check the input VaraibleName for db/dbx when appending variables with formatted as EFI_SIGNATURE_LIST.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting  <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14087  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-01-25 07:14:43 +00:00 
						 
				 
			
				
					
						
							
							
								sfu5 
							
						 
					 
					
						
						
							
						
						12cbe23257 
					 
					
						
						
							
							Check for NULL pointer before dereference it.  
						
						... 
						
						
						
						Signed-off-by: Fu Siyuan <siyuan.fu@intel.com >
Reviewed-by: Ye Ting  <ting.ye@intel.com >
Reviewed-by: Dong Guo <guo.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14086  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-01-25 07:12:25 +00:00 
						 
				 
			
				
					
						
							
							
								lzeng14 
							
						 
					 
					
						
						
							
						
						932e0f6628 
					 
					
						
						
							
							Variables with state VAR_ADDED&VAR_IN_DELETED_TRANSITION should be considered as valid variables if there is no duplicated ones with VAR_ADDED state.  
						
						... 
						
						
						
						Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14085  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-01-25 06:17:43 +00:00 
						 
				 
			
				
					
						
							
							
								lzeng14 
							
						 
					 
					
						
						
							
						
						0cc565deac 
					 
					
						
						
							
							Add NULL pointer check.  
						
						... 
						
						
						
						Signed-off-by: Star Zeng <star.zeng@intel.com >
Reviewed-by: Eric Dong <eric.dong@intel.com >
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@14084  6f19259b-4bc3-4df7-8a09-765794883524 
						
						
					 
					
						2013-01-25 04:48:41 +00:00