The SpinLock functions in the SynchronicationLib use volatile parameters to keep compiler from optimizing these functions too much. The volatile keyword is missing from the Interlocked*() functions in this same library instance. Update the library instance to consistently use volatile on all functions in the SynchronizationLib class. Cc: Liming Gao <liming.gao@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Andrew Fish <afish@apple.com> Cc: Jeff Fan <jeff.fan@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney <michael.d.kinney@intel.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Liming Gao <liming.gao@intel.com>
44 lines
1.4 KiB
NASM
44 lines
1.4 KiB
NASM
;------------------------------------------------------------------------------
|
|
;
|
|
; Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
|
|
; Copyright (c) 2015, Linaro Ltd. All rights reserved.<BR>
|
|
; This program and the accompanying materials
|
|
; are licensed and made available under the terms and conditions of the BSD License
|
|
; which accompanies this distribution. The full text of the license may be found at
|
|
; http://opensource.org/licenses/bsd-license.php.
|
|
;
|
|
; THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
|
|
; WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
|
|
;
|
|
; Module Name:
|
|
;
|
|
; InterlockedCompareExchange16.Asm
|
|
;
|
|
; Abstract:
|
|
;
|
|
; InterlockedCompareExchange16 function
|
|
;
|
|
; Notes:
|
|
;
|
|
;------------------------------------------------------------------------------
|
|
|
|
SECTION .text
|
|
|
|
;------------------------------------------------------------------------------
|
|
; UINT16
|
|
; EFIAPI
|
|
; InternalSyncCompareExchange16 (
|
|
; IN volatile UINT16 *Value,
|
|
; IN UINT16 CompareValue,
|
|
; IN UINT16 ExchangeValue
|
|
; );
|
|
;------------------------------------------------------------------------------
|
|
global ASM_PFX(InternalSyncCompareExchange16)
|
|
ASM_PFX(InternalSyncCompareExchange16):
|
|
mov ecx, [esp + 4]
|
|
mov ax, [esp + 8]
|
|
mov dx, [esp + 12]
|
|
lock cmpxchg [ecx], dx
|
|
ret
|
|
|