61a7b0ec63
Currently, the GIC driver has a static dependency on the CPU arch protocol driver, so it can register its IRQ handler at init time. This means there is a window between dispatch of the CPU driver and dispatch of the GIC driver where any unexpected GIC state may trigger an interrupt which we are not set up to handle yet. Note that this is even the case if we enter UEFI with interrupts disabled at the CPU, given that any TPL manipulation involving TPL_HIGH_LEVEL will unconditionally enable IRQs at the CPU side regardless of whether they were enabled to begin with (but only as soon as the CPU arch protocol is actually installed) So let's reorder the GIC driver with the CPU driver, and let it run its initialization that puts the GIC into a known state before enabling interrupts. Move its installation of its IRQ handler to a protocol notify callback on the CPU arch protocol so that it runs as soon as it becomes available. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> Tested-by: Marc Zyngier <marc.zyngier@arm.com>
63 lines
1.6 KiB
INI
63 lines
1.6 KiB
INI
#/** @file
|
|
#
|
|
# Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.<BR>
|
|
# Copyright (c) 2012 - 2017, ARM Ltd. All rights reserved.<BR>
|
|
#
|
|
# This program and the accompanying materials
|
|
# are licensed and made available under the terms and conditions of the BSD License
|
|
# which accompanies this distribution. The full text of the license may be found at
|
|
# http://opensource.org/licenses/bsd-license.php
|
|
#
|
|
# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
|
|
#
|
|
#**/
|
|
|
|
[Defines]
|
|
INF_VERSION = 0x00010005
|
|
BASE_NAME = ArmGicDxe
|
|
FILE_GUID = DE371F7C-DEC4-4D21-ADF1-593ABCC15882 # gArmGicDxeFileGuid
|
|
MODULE_TYPE = DXE_DRIVER
|
|
VERSION_STRING = 1.0
|
|
|
|
ENTRY_POINT = InterruptDxeInitialize
|
|
|
|
[Sources.common]
|
|
ArmGicDxe.c
|
|
ArmGicCommonDxe.c
|
|
|
|
GicV2/ArmGicV2Dxe.c
|
|
GicV3/ArmGicV3Dxe.c
|
|
|
|
[Packages]
|
|
MdePkg/MdePkg.dec
|
|
EmbeddedPkg/EmbeddedPkg.dec
|
|
ArmPkg/ArmPkg.dec
|
|
|
|
[LibraryClasses]
|
|
ArmGicLib
|
|
BaseLib
|
|
UefiLib
|
|
UefiBootServicesTableLib
|
|
DebugLib
|
|
PrintLib
|
|
MemoryAllocationLib
|
|
UefiDriverEntryPoint
|
|
IoLib
|
|
PcdLib
|
|
UefiLib
|
|
|
|
[Protocols]
|
|
gHardwareInterruptProtocolGuid
|
|
gHardwareInterrupt2ProtocolGuid
|
|
gEfiCpuArchProtocolGuid
|
|
|
|
[Pcd.common]
|
|
gArmTokenSpaceGuid.PcdGicDistributorBase
|
|
gArmTokenSpaceGuid.PcdGicRedistributorsBase
|
|
gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase
|
|
gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy
|
|
|
|
[Depex]
|
|
TRUE
|