The DXE & MM standalone variant of AcpiTimerLib defines a global named mPerformanceCounterFrequency. A global with an identical name is also present in MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c Since XhciDxe has a dependency on TimerLib, this can cause link errors due to the same symbol being defined twice if the platform DSC chooses to use AcpiTimerLib as the TimerLib implementation for any given platform. To resolve this, I have changed made the definition of mPerformanceCounterFrequency to static and renamed it to mAcpiTimerLibTscFrequency. Since this variable is not used outside of the DxeStandaloneMmAcpiTimerLib.c compilation unit, there is no reason to have it exported as a global. Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
102 lines
2.3 KiB
C
102 lines
2.3 KiB
C
/** @file
|
|
ACPI Timer implements one instance of Timer Library.
|
|
|
|
Copyright (c) 2013 - 2023, Intel Corporation. All rights reserved.<BR>
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
|
|
**/
|
|
|
|
#include <PiDxe.h>
|
|
#include <Library/TimerLib.h>
|
|
#include <Library/BaseLib.h>
|
|
#include <Library/HobLib.h>
|
|
|
|
//
|
|
// Cached performance counter frequency
|
|
//
|
|
static UINT64 mAcpiTimerLibTscFrequency = 0;
|
|
|
|
extern GUID mFrequencyHobGuid;
|
|
|
|
/**
|
|
The constructor function enables ACPI IO space.
|
|
|
|
If ACPI I/O space not enabled, this function will enable it.
|
|
It will always return RETURN_SUCCESS.
|
|
|
|
@retval EFI_SUCCESS The constructor always returns RETURN_SUCCESS.
|
|
|
|
**/
|
|
RETURN_STATUS
|
|
EFIAPI
|
|
AcpiTimerLibConstructor (
|
|
VOID
|
|
);
|
|
|
|
/**
|
|
Calculate TSC frequency.
|
|
|
|
The TSC counting frequency is determined by comparing how far it counts
|
|
during a 101.4 us period as determined by the ACPI timer.
|
|
The ACPI timer is used because it counts at a known frequency.
|
|
The TSC is sampled, followed by waiting 363 counts of the ACPI timer,
|
|
or 101.4 us. The TSC is then sampled again. The difference multiplied by
|
|
9861 is the TSC frequency. There will be a small error because of the
|
|
overhead of reading the ACPI timer. An attempt is made to determine and
|
|
compensate for this error.
|
|
|
|
@return The number of TSC counts per second.
|
|
|
|
**/
|
|
UINT64
|
|
InternalCalculateTscFrequency (
|
|
VOID
|
|
);
|
|
|
|
/**
|
|
Internal function to retrieves the 64-bit frequency in Hz.
|
|
|
|
Internal function to retrieves the 64-bit frequency in Hz.
|
|
|
|
@return The frequency in Hz.
|
|
|
|
**/
|
|
UINT64
|
|
InternalGetPerformanceCounterFrequency (
|
|
VOID
|
|
)
|
|
{
|
|
return mAcpiTimerLibTscFrequency;
|
|
}
|
|
|
|
/**
|
|
The constructor function enables ACPI IO space, and caches PerformanceCounterFrequency.
|
|
|
|
@retval EFI_SUCCESS The constructor always returns RETURN_SUCCESS.
|
|
|
|
**/
|
|
EFI_STATUS
|
|
CommonAcpiTimerLibConstructor (
|
|
VOID
|
|
)
|
|
{
|
|
EFI_HOB_GUID_TYPE *GuidHob;
|
|
|
|
//
|
|
// Enable ACPI IO space.
|
|
//
|
|
AcpiTimerLibConstructor ();
|
|
|
|
//
|
|
// Initialize PerformanceCounterFrequency
|
|
//
|
|
GuidHob = GetFirstGuidHob (&mFrequencyHobGuid);
|
|
if (GuidHob != NULL) {
|
|
mAcpiTimerLibTscFrequency = *(UINT64 *)GET_GUID_HOB_DATA (GuidHob);
|
|
} else {
|
|
mAcpiTimerLibTscFrequency = InternalCalculateTscFrequency ();
|
|
}
|
|
|
|
return EFI_SUCCESS;
|
|
}
|