9108fc17b0
During normal boot, when EFI_DXE_SMM_READY_TO_LOCK_PROTOCOL is installed by platform BDS, the SMM IPL locks SMRAM (TSEG) through EFI_SMM_ACCESS2_PROTOCOL.Lock(). See SmmIplReadyToLockEventNotify() in "MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c". During S3 resume, S3Resume2Pei locks SMRAM (TSEG) through PEI_SMM_ACCESS_PPI.Lock(), before executing the boot script. See S3ResumeExecuteBootScript() in "UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c". Those are precisely the places where the SMRAM at the default SMBASE should be locked too. Add such an action to SmramAccessLock(). Notes: - The SMRAM at the default SMBASE doesn't support the "closed and unlocked" state (and so it can't be closed without locking it, and it cannot be opened after closing it). - The SMRAM at the default SMBASE isn't (and shouldn't) be exposed with another EFI_SMRAM_DESCRIPTOR in the GetCapabilities() members of EFI_SMM_ACCESS2_PROTOCOL / PEI_SMM_ACCESS_PPI. That's because the SMRAM in question is not "general purpose"; it's only QEMU's solution to protect the initial SMI handler from the OS, when a VCPU is hot-plugged. Consequently, the state of the SMRAM at the default SMBASE is not reflected in the "OpenState" / "LockState" fields of the protocol and PPI. - An alternative to extending SmramAccessLock() would be to register an EFI_DXE_SMM_READY_TO_LOCK_PROTOCOL notify in SmmAccess2Dxe (for locking at normal boot), and an EDKII_S3_SMM_INIT_DONE_GUID PPI notify in SmmAccessPei (for locking at S3 resume). Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Jordan Justen <jordan.l.justen@intel.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com> Message-Id: <20200129214412.2361-10-lersek@redhat.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
105 lines
2.7 KiB
C
105 lines
2.7 KiB
C
/** @file
|
|
|
|
Functions and types shared by the SMM accessor PEI and DXE modules.
|
|
|
|
Copyright (C) 2015, Red Hat, Inc.
|
|
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
|
|
**/
|
|
|
|
#include <Pi/PiMultiPhase.h>
|
|
|
|
//
|
|
// We'll have two SMRAM ranges.
|
|
//
|
|
// The first is a tiny one that hosts an SMM_S3_RESUME_STATE object, to be
|
|
// filled in by the CPU SMM driver during normal boot, for the PEI instance of
|
|
// the LockBox library (which will rely on the object during S3 resume).
|
|
//
|
|
// The other SMRAM range is the main one, for the SMM core and the SMM drivers.
|
|
//
|
|
typedef enum {
|
|
DescIdxSmmS3ResumeState = 0,
|
|
DescIdxMain = 1,
|
|
DescIdxCount = 2
|
|
} DESCRIPTOR_INDEX;
|
|
|
|
//
|
|
// The value of PcdQ35TsegMbytes is saved into this variable at module startup.
|
|
//
|
|
extern UINT16 mQ35TsegMbytes;
|
|
|
|
/**
|
|
Save PcdQ35TsegMbytes into mQ35TsegMbytes.
|
|
**/
|
|
VOID
|
|
InitQ35TsegMbytes (
|
|
VOID
|
|
);
|
|
|
|
/**
|
|
Save PcdQ35SmramAtDefaultSmbase into mQ35SmramAtDefaultSmbase.
|
|
**/
|
|
VOID
|
|
InitQ35SmramAtDefaultSmbase (
|
|
VOID
|
|
);
|
|
|
|
/**
|
|
Read the MCH_SMRAM and ESMRAMC registers, and update the LockState and
|
|
OpenState fields in the PEI_SMM_ACCESS_PPI / EFI_SMM_ACCESS2_PROTOCOL object,
|
|
from the D_LCK and T_EN bits.
|
|
|
|
PEI_SMM_ACCESS_PPI and EFI_SMM_ACCESS2_PROTOCOL member functions can rely on
|
|
the LockState and OpenState fields being up-to-date on entry, and they need
|
|
to restore the same invariant on exit, if they touch the bits in question.
|
|
|
|
@param[out] LockState Reflects the D_LCK bit on output; TRUE iff SMRAM is
|
|
locked.
|
|
@param[out] OpenState Reflects the inverse of the T_EN bit on output; TRUE
|
|
iff SMRAM is open.
|
|
**/
|
|
VOID
|
|
GetStates (
|
|
OUT BOOLEAN *LockState,
|
|
OUT BOOLEAN *OpenState
|
|
);
|
|
|
|
//
|
|
// The functions below follow the PEI_SMM_ACCESS_PPI and
|
|
// EFI_SMM_ACCESS2_PROTOCOL member declarations. The PeiServices and This
|
|
// pointers are removed (TSEG doesn't depend on them), and so is the
|
|
// DescriptorIndex parameter (TSEG doesn't support range-wise locking).
|
|
//
|
|
// The LockState and OpenState members that are common to both
|
|
// PEI_SMM_ACCESS_PPI and EFI_SMM_ACCESS2_PROTOCOL are taken and updated in
|
|
// isolation from the rest of the (non-shared) members.
|
|
//
|
|
|
|
EFI_STATUS
|
|
SmramAccessOpen (
|
|
OUT BOOLEAN *LockState,
|
|
OUT BOOLEAN *OpenState
|
|
);
|
|
|
|
EFI_STATUS
|
|
SmramAccessClose (
|
|
OUT BOOLEAN *LockState,
|
|
OUT BOOLEAN *OpenState
|
|
);
|
|
|
|
EFI_STATUS
|
|
SmramAccessLock (
|
|
OUT BOOLEAN *LockState,
|
|
IN OUT BOOLEAN *OpenState
|
|
);
|
|
|
|
EFI_STATUS
|
|
SmramAccessGetCapabilities (
|
|
IN BOOLEAN LockState,
|
|
IN BOOLEAN OpenState,
|
|
IN OUT UINTN *SmramMapSize,
|
|
IN OUT EFI_SMRAM_DESCRIPTOR *SmramMap
|
|
);
|