The OvmfXen platform specifies the dynamic access method for "PcdPciDisableBusEnumeration" needlessly. After the DSC file sets the PCD to TRUE by default, the InitializeXen() function in XenPlatformPei superfluously sets the PCD to TRUE again. There are no other writes to the PCD in the platform. Make the PCD Fixed-At-Build, and remove the access (in fact, the whole InitializeXen() function) from XenPlatformPei. Cc: Anthony Perard <anthony.perard@citrix.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Jordan Justen <jordan.l.justen@intel.com> Cc: Julien Grall <julien@xen.org> Cc: Philippe Mathieu-Daudé <philmd@redhat.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210526201446.12554-20-lersek@redhat.com> Reviewed-by: Ard Biesheuvel <ardb@kernel.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
		
			
				
	
	
		
			464 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			464 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /**@file
 | |
|   Platform PEI driver
 | |
| 
 | |
|   Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
 | |
|   Copyright (c) 2011, Andrei Warkentin <andreiw@motorola.com>
 | |
|   Copyright (c) 2019, Citrix Systems, Inc.
 | |
| 
 | |
|   SPDX-License-Identifier: BSD-2-Clause-Patent
 | |
| 
 | |
| **/
 | |
| 
 | |
| //
 | |
| // The package level header files this module uses
 | |
| //
 | |
| #include <PiPei.h>
 | |
| 
 | |
| //
 | |
| // The Library classes this module consumes
 | |
| //
 | |
| #include <Library/BaseLib.h>
 | |
| #include <Library/DebugLib.h>
 | |
| #include <Library/HobLib.h>
 | |
| #include <Library/IoLib.h>
 | |
| #include <Library/MemoryAllocationLib.h>
 | |
| #include <Library/PcdLib.h>
 | |
| #include <Library/PciLib.h>
 | |
| #include <Library/PeimEntryPoint.h>
 | |
| #include <Library/PeiServicesLib.h>
 | |
| #include <Library/ResourcePublicationLib.h>
 | |
| #include <Guid/MemoryTypeInformation.h>
 | |
| #include <Ppi/MasterBootMode.h>
 | |
| #include <IndustryStandard/Pci22.h>
 | |
| #include <OvmfPlatforms.h>
 | |
| 
 | |
| #include "Platform.h"
 | |
| #include "Cmos.h"
 | |
| 
 | |
| EFI_MEMORY_TYPE_INFORMATION mDefaultMemoryTypeInformation[] = {
 | |
|   { EfiACPIMemoryNVS,       0x004 },
 | |
|   { EfiACPIReclaimMemory,   0x008 },
 | |
|   { EfiReservedMemoryType,  0x004 },
 | |
|   { EfiRuntimeServicesData, 0x024 },
 | |
|   { EfiRuntimeServicesCode, 0x030 },
 | |
|   { EfiBootServicesCode,    0x180 },
 | |
|   { EfiBootServicesData,    0xF00 },
 | |
|   { EfiMaxMemoryType,       0x000 }
 | |
| };
 | |
| 
 | |
| 
 | |
| EFI_PEI_PPI_DESCRIPTOR   mPpiBootMode[] = {
 | |
|   {
 | |
|     EFI_PEI_PPI_DESCRIPTOR_PPI | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,
 | |
|     &gEfiPeiMasterBootModePpiGuid,
 | |
|     NULL
 | |
|   }
 | |
| };
 | |
| 
 | |
| 
 | |
| UINT16 mHostBridgeDevId;
 | |
| 
 | |
| EFI_BOOT_MODE mBootMode = BOOT_WITH_FULL_CONFIGURATION;
 | |
| 
 | |
| 
 | |
| VOID
 | |
| AddIoMemoryBaseSizeHob (
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryBase,
 | |
|   UINT64                      MemorySize
 | |
|   )
 | |
| {
 | |
|   BuildResourceDescriptorHob (
 | |
|     EFI_RESOURCE_MEMORY_MAPPED_IO,
 | |
|       EFI_RESOURCE_ATTRIBUTE_PRESENT     |
 | |
|       EFI_RESOURCE_ATTRIBUTE_INITIALIZED |
 | |
|       EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |
 | |
|       EFI_RESOURCE_ATTRIBUTE_TESTED,
 | |
|     MemoryBase,
 | |
|     MemorySize
 | |
|     );
 | |
| }
 | |
| 
 | |
| VOID
 | |
| AddReservedMemoryBaseSizeHob (
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryBase,
 | |
|   UINT64                      MemorySize,
 | |
|   BOOLEAN                     Cacheable
 | |
|   )
 | |
| {
 | |
|   BuildResourceDescriptorHob (
 | |
|     EFI_RESOURCE_MEMORY_RESERVED,
 | |
|       EFI_RESOURCE_ATTRIBUTE_PRESENT     |
 | |
|       EFI_RESOURCE_ATTRIBUTE_INITIALIZED |
 | |
|       EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |
 | |
|       (Cacheable ?
 | |
|        EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |
 | |
|        EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |
 | |
|        EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE :
 | |
|        0
 | |
|        ) |
 | |
|       EFI_RESOURCE_ATTRIBUTE_TESTED,
 | |
|     MemoryBase,
 | |
|     MemorySize
 | |
|     );
 | |
| }
 | |
| 
 | |
| VOID
 | |
| AddReservedMemoryRangeHob (
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryBase,
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryLimit,
 | |
|   BOOLEAN                     Cacheable
 | |
|   )
 | |
| {
 | |
|   AddReservedMemoryBaseSizeHob (MemoryBase,
 | |
|     (UINT64)(MemoryLimit - MemoryBase), Cacheable);
 | |
| }
 | |
| 
 | |
| VOID
 | |
| AddIoMemoryRangeHob (
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryBase,
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryLimit
 | |
|   )
 | |
| {
 | |
|   AddIoMemoryBaseSizeHob (MemoryBase, (UINT64)(MemoryLimit - MemoryBase));
 | |
| }
 | |
| 
 | |
| 
 | |
| VOID
 | |
| AddMemoryBaseSizeHob (
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryBase,
 | |
|   UINT64                      MemorySize
 | |
|   )
 | |
| {
 | |
|   BuildResourceDescriptorHob (
 | |
|     EFI_RESOURCE_SYSTEM_MEMORY,
 | |
|       EFI_RESOURCE_ATTRIBUTE_PRESENT |
 | |
|       EFI_RESOURCE_ATTRIBUTE_INITIALIZED |
 | |
|       EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |
 | |
|       EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |
 | |
|       EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |
 | |
|       EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE |
 | |
|       EFI_RESOURCE_ATTRIBUTE_TESTED,
 | |
|     MemoryBase,
 | |
|     MemorySize
 | |
|     );
 | |
| }
 | |
| 
 | |
| 
 | |
| VOID
 | |
| AddMemoryRangeHob (
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryBase,
 | |
|   EFI_PHYSICAL_ADDRESS        MemoryLimit
 | |
|   )
 | |
| {
 | |
|   AddMemoryBaseSizeHob (MemoryBase, (UINT64)(MemoryLimit - MemoryBase));
 | |
| }
 | |
| 
 | |
| 
 | |
| VOID
 | |
| MemMapInitialization (
 | |
|   VOID
 | |
|   )
 | |
| {
 | |
|   UINT64        PciIoBase;
 | |
|   UINT64        PciIoSize;
 | |
|   RETURN_STATUS PcdStatus;
 | |
| 
 | |
|   PciIoBase = 0xC000;
 | |
|   PciIoSize = 0x4000;
 | |
| 
 | |
|   //
 | |
|   // Create Memory Type Information HOB
 | |
|   //
 | |
|   BuildGuidDataHob (
 | |
|     &gEfiMemoryTypeInformationGuid,
 | |
|     mDefaultMemoryTypeInformation,
 | |
|     sizeof(mDefaultMemoryTypeInformation)
 | |
|     );
 | |
| 
 | |
|   //
 | |
|   // Video memory + Legacy BIOS region
 | |
|   //
 | |
|   AddIoMemoryRangeHob (0x0A0000, BASE_1MB);
 | |
| 
 | |
|   //
 | |
|   // Add PCI IO Port space available for PCI resource allocations.
 | |
|   //
 | |
|   BuildResourceDescriptorHob (
 | |
|     EFI_RESOURCE_IO,
 | |
|     EFI_RESOURCE_ATTRIBUTE_PRESENT     |
 | |
|     EFI_RESOURCE_ATTRIBUTE_INITIALIZED,
 | |
|     PciIoBase,
 | |
|     PciIoSize
 | |
|     );
 | |
|   PcdStatus = PcdSet64S (PcdPciIoBase, PciIoBase);
 | |
|   ASSERT_RETURN_ERROR (PcdStatus);
 | |
|   PcdStatus = PcdSet64S (PcdPciIoSize, PciIoSize);
 | |
|   ASSERT_RETURN_ERROR (PcdStatus);
 | |
| }
 | |
| 
 | |
| VOID
 | |
| PciExBarInitialization (
 | |
|   VOID
 | |
|   )
 | |
| {
 | |
|   union {
 | |
|     UINT64 Uint64;
 | |
|     UINT32 Uint32[2];
 | |
|   } PciExBarBase;
 | |
| 
 | |
|   //
 | |
|   // We only support the 256MB size for the MMCONFIG area:
 | |
|   // 256 buses * 32 devices * 8 functions * 4096 bytes config space.
 | |
|   //
 | |
|   // The masks used below enforce the Q35 requirements that the MMCONFIG area
 | |
|   // be (a) correctly aligned -- here at 256 MB --, (b) located under 64 GB.
 | |
|   //
 | |
|   // Note that (b) also ensures that the minimum address width we have
 | |
|   // determined in AddressWidthInitialization(), i.e., 36 bits, will suffice
 | |
|   // for DXE's page tables to cover the MMCONFIG area.
 | |
|   //
 | |
|   PciExBarBase.Uint64 = FixedPcdGet64 (PcdPciExpressBaseAddress);
 | |
|   ASSERT ((PciExBarBase.Uint32[1] & MCH_PCIEXBAR_HIGHMASK) == 0);
 | |
|   ASSERT ((PciExBarBase.Uint32[0] & MCH_PCIEXBAR_LOWMASK) == 0);
 | |
| 
 | |
|   //
 | |
|   // Clear the PCIEXBAREN bit first, before programming the high register.
 | |
|   //
 | |
|   PciWrite32 (DRAMC_REGISTER_Q35 (MCH_PCIEXBAR_LOW), 0);
 | |
| 
 | |
|   //
 | |
|   // Program the high register. Then program the low register, setting the
 | |
|   // MMCONFIG area size and enabling decoding at once.
 | |
|   //
 | |
|   PciWrite32 (DRAMC_REGISTER_Q35 (MCH_PCIEXBAR_HIGH), PciExBarBase.Uint32[1]);
 | |
|   PciWrite32 (
 | |
|     DRAMC_REGISTER_Q35 (MCH_PCIEXBAR_LOW),
 | |
|     PciExBarBase.Uint32[0] | MCH_PCIEXBAR_BUS_FF | MCH_PCIEXBAR_EN
 | |
|     );
 | |
| }
 | |
| 
 | |
| VOID
 | |
| MiscInitialization (
 | |
|   VOID
 | |
|   )
 | |
| {
 | |
|   UINTN         PmCmd;
 | |
|   UINTN         Pmba;
 | |
|   UINT32        PmbaAndVal;
 | |
|   UINT32        PmbaOrVal;
 | |
|   UINTN         AcpiCtlReg;
 | |
|   UINT8         AcpiEnBit;
 | |
|   RETURN_STATUS PcdStatus;
 | |
| 
 | |
|   //
 | |
|   // Disable A20 Mask
 | |
|   //
 | |
|   IoOr8 (0x92, BIT1);
 | |
| 
 | |
|   //
 | |
|   // Build the CPU HOB with guest RAM size dependent address width and 16-bits
 | |
|   // of IO space. (Side note: unlike other HOBs, the CPU HOB is needed during
 | |
|   // S3 resume as well, so we build it unconditionally.)
 | |
|   //
 | |
|   BuildCpuHob (mPhysMemAddressWidth, 16);
 | |
| 
 | |
|   //
 | |
|   // Determine platform type and save Host Bridge DID to PCD
 | |
|   //
 | |
|   switch (mHostBridgeDevId) {
 | |
|     case INTEL_82441_DEVICE_ID:
 | |
|       PmCmd      = POWER_MGMT_REGISTER_PIIX4 (PCI_COMMAND_OFFSET);
 | |
|       Pmba       = POWER_MGMT_REGISTER_PIIX4 (PIIX4_PMBA);
 | |
|       PmbaAndVal = ~(UINT32)PIIX4_PMBA_MASK;
 | |
|       PmbaOrVal  = PIIX4_PMBA_VALUE;
 | |
|       AcpiCtlReg = POWER_MGMT_REGISTER_PIIX4 (PIIX4_PMREGMISC);
 | |
|       AcpiEnBit  = PIIX4_PMREGMISC_PMIOSE;
 | |
|       break;
 | |
|     case INTEL_Q35_MCH_DEVICE_ID:
 | |
|       PmCmd      = POWER_MGMT_REGISTER_Q35 (PCI_COMMAND_OFFSET);
 | |
|       Pmba       = POWER_MGMT_REGISTER_Q35 (ICH9_PMBASE);
 | |
|       PmbaAndVal = ~(UINT32)ICH9_PMBASE_MASK;
 | |
|       PmbaOrVal  = ICH9_PMBASE_VALUE;
 | |
|       AcpiCtlReg = POWER_MGMT_REGISTER_Q35 (ICH9_ACPI_CNTL);
 | |
|       AcpiEnBit  = ICH9_ACPI_CNTL_ACPI_EN;
 | |
|       break;
 | |
|     default:
 | |
|       if (XenPvhDetected ()) {
 | |
|         //
 | |
|         // There is no PCI bus in this case
 | |
|         //
 | |
|         return;
 | |
|       }
 | |
|       DEBUG ((DEBUG_ERROR, "%a: Unknown Host Bridge Device ID: 0x%04x\n",
 | |
|         __FUNCTION__, mHostBridgeDevId));
 | |
|       ASSERT (FALSE);
 | |
|       return;
 | |
|   }
 | |
|   PcdStatus = PcdSet16S (PcdOvmfHostBridgePciDevId, mHostBridgeDevId);
 | |
|   ASSERT_RETURN_ERROR (PcdStatus);
 | |
| 
 | |
|   //
 | |
|   // If the appropriate IOspace enable bit is set, assume the ACPI PMBA
 | |
|   // has been configured (e.g., by Xen) and skip the setup here.
 | |
|   // This matches the logic in AcpiTimerLibConstructor ().
 | |
|   //
 | |
|   if ((PciRead8 (AcpiCtlReg) & AcpiEnBit) == 0) {
 | |
|     //
 | |
|     // The PEI phase should be exited with fully accessibe ACPI PM IO space:
 | |
|     // 1. set PMBA
 | |
|     //
 | |
|     PciAndThenOr32 (Pmba, PmbaAndVal, PmbaOrVal);
 | |
| 
 | |
|     //
 | |
|     // 2. set PCICMD/IOSE
 | |
|     //
 | |
|     PciOr8 (PmCmd, EFI_PCI_COMMAND_IO_SPACE);
 | |
| 
 | |
|     //
 | |
|     // 3. set ACPI PM IO enable bit (PMREGMISC:PMIOSE or ACPI_CNTL:ACPI_EN)
 | |
|     //
 | |
|     PciOr8 (AcpiCtlReg, AcpiEnBit);
 | |
|   }
 | |
| 
 | |
|   if (mHostBridgeDevId == INTEL_Q35_MCH_DEVICE_ID) {
 | |
|     //
 | |
|     // Set Root Complex Register Block BAR
 | |
|     //
 | |
|     PciWrite32 (
 | |
|       POWER_MGMT_REGISTER_Q35 (ICH9_RCBA),
 | |
|       ICH9_ROOT_COMPLEX_BASE | ICH9_RCBA_EN
 | |
|       );
 | |
| 
 | |
|     //
 | |
|     // Set PCI Express Register Range Base Address
 | |
|     //
 | |
|     PciExBarInitialization ();
 | |
|   }
 | |
| }
 | |
| 
 | |
| 
 | |
| VOID
 | |
| BootModeInitialization (
 | |
|   VOID
 | |
|   )
 | |
| {
 | |
|   EFI_STATUS    Status;
 | |
| 
 | |
|   if (CmosRead8 (0xF) == 0xFE) {
 | |
|     mBootMode = BOOT_ON_S3_RESUME;
 | |
|   }
 | |
|   CmosWrite8 (0xF, 0x00);
 | |
| 
 | |
|   Status = PeiServicesSetBootMode (mBootMode);
 | |
|   ASSERT_EFI_ERROR (Status);
 | |
| 
 | |
|   Status = PeiServicesInstallPpi (mPpiBootMode);
 | |
|   ASSERT_EFI_ERROR (Status);
 | |
| }
 | |
| 
 | |
| 
 | |
| VOID
 | |
| ReserveEmuVariableNvStore (
 | |
|   )
 | |
| {
 | |
|   EFI_PHYSICAL_ADDRESS VariableStore;
 | |
|   RETURN_STATUS        PcdStatus;
 | |
| 
 | |
|   //
 | |
|   // Allocate storage for NV variables early on so it will be
 | |
|   // at a consistent address.  Since VM memory is preserved
 | |
|   // across reboots, this allows the NV variable storage to survive
 | |
|   // a VM reboot.
 | |
|   //
 | |
|   VariableStore =
 | |
|     (EFI_PHYSICAL_ADDRESS)(UINTN)
 | |
|       AllocateRuntimePages (
 | |
|         EFI_SIZE_TO_PAGES (2 * PcdGet32 (PcdFlashNvStorageFtwSpareSize))
 | |
|         );
 | |
|   DEBUG ((DEBUG_INFO,
 | |
|           "Reserved variable store memory: 0x%lX; size: %dkb\n",
 | |
|           VariableStore,
 | |
|           (2 * PcdGet32 (PcdFlashNvStorageFtwSpareSize)) / 1024
 | |
|         ));
 | |
|   PcdStatus = PcdSet64S (PcdEmuVariableNvStoreReserved, VariableStore);
 | |
|   ASSERT_RETURN_ERROR (PcdStatus);
 | |
| }
 | |
| 
 | |
| 
 | |
| VOID
 | |
| DebugDumpCmos (
 | |
|   VOID
 | |
|   )
 | |
| {
 | |
|   UINT32 Loop;
 | |
| 
 | |
|   DEBUG ((DEBUG_INFO, "CMOS:\n"));
 | |
| 
 | |
|   for (Loop = 0; Loop < 0x80; Loop++) {
 | |
|     if ((Loop % 0x10) == 0) {
 | |
|       DEBUG ((DEBUG_INFO, "%02x:", Loop));
 | |
|     }
 | |
|     DEBUG ((DEBUG_INFO, " %02x", CmosRead8 (Loop)));
 | |
|     if ((Loop % 0x10) == 0xf) {
 | |
|       DEBUG ((DEBUG_INFO, "\n"));
 | |
|     }
 | |
|   }
 | |
| }
 | |
| 
 | |
| 
 | |
| 
 | |
| /**
 | |
|   Perform Platform PEI initialization.
 | |
| 
 | |
|   @param  FileHandle      Handle of the file being invoked.
 | |
|   @param  PeiServices     Describes the list of possible PEI Services.
 | |
| 
 | |
|   @return EFI_SUCCESS     The PEIM initialized successfully.
 | |
| 
 | |
| **/
 | |
| EFI_STATUS
 | |
| EFIAPI
 | |
| InitializeXenPlatform (
 | |
|   IN       EFI_PEI_FILE_HANDLE  FileHandle,
 | |
|   IN CONST EFI_PEI_SERVICES     **PeiServices
 | |
|   )
 | |
| {
 | |
|   DEBUG ((DEBUG_INFO, "Platform PEIM Loaded\n"));
 | |
| 
 | |
|   DebugDumpCmos ();
 | |
| 
 | |
|   if (!XenDetect ()) {
 | |
|     DEBUG ((DEBUG_ERROR, "ERROR: Xen isn't detected\n"));
 | |
|     ASSERT (FALSE);
 | |
|     CpuDeadLoop ();
 | |
|   }
 | |
| 
 | |
|   XenConnect ();
 | |
| 
 | |
|   BootModeInitialization ();
 | |
|   AddressWidthInitialization ();
 | |
| 
 | |
|   //
 | |
|   // Query Host Bridge DID
 | |
|   //
 | |
|   mHostBridgeDevId = PciRead16 (OVMF_HOSTBRIDGE_DID);
 | |
| 
 | |
|   PublishPeiMemory ();
 | |
| 
 | |
|   InitializeRamRegions ();
 | |
| 
 | |
|   CalibrateLapicTimer ();
 | |
| 
 | |
|   if (mBootMode != BOOT_ON_S3_RESUME) {
 | |
|     ReserveEmuVariableNvStore ();
 | |
|     PeiFvInitialization ();
 | |
|     MemMapInitialization ();
 | |
|   }
 | |
| 
 | |
|   InstallClearCacheCallback ();
 | |
|   AmdSevInitialize ();
 | |
|   MiscInitialization ();
 | |
| 
 | |
|   return EFI_SUCCESS;
 | |
| }
 |