sravan/system76-embedded-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tool: Support downcasting generic Ec

Browse Source 
Removes the `impl Access for &mut dyn Access` I added earlier. But that
hasn't proven too useful.
This commit is contained in:
Ian Douglas Scott
2021-02-19 07:41:25 -08:00
committed by Jeremy Soller
parent 171257916c
commit 2768925ec6
4 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tool/src/access/mod.rs
View File

@ -1,4 +1,5 @@
use crate::Error;
use downcast_rs::Downcast;
#[cfg(feature = "hidapi")]
pub use self::hid::AccessHid;
@ -17,7 +18,7 @@ pub use self::lpc::*;
mod lpc;
/// Access method for running an EC command
pub trait Access {
pub trait Access: Downcast {
/// Sends a command using the access method. Only internal use is recommended
unsafe fn command(&mut self, cmd: u8, data: &mut [u8]) -> Result<u8, Error>;
@ -31,16 +32,6 @@ pub trait Access {
}
}
impl Access for &mut dyn Access {
unsafe fn command(&mut self, cmd: u8, data: &mut [u8]) -> Result<u8, Error> {
(**self).command(cmd, data)
}
fn data_size(&self) -> usize {
(**self).data_size()
}
}
impl Access for Box<dyn Access> {
unsafe fn command(&mut self, cmd: u8, data: &mut [u8]) -> Result<u8, Error> {
(**self).command(cmd, data)
@ -50,3 +41,5 @@ impl Access for Box<dyn Access> {
(**self).data_size()
}
}
downcast_rs::impl_downcast!(Access);