sravan/system76-embedded-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i2c: Use u16 for data length

Browse Source 
The length will never be negative.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
This commit is contained in:
Tim Crawford
2021-08-02 11:56:47 -06:00
committed by Jeremy Soller
parent 784202383e
commit 2a3830fb57
4 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/arch/avr/i2c.c
View File

@ -46,8 +46,8 @@ void i2c_stop(struct I2C * i2c) {
TWCR = BIT(TWINT) | BIT(TWEN) | BIT(TWSTO);
}
int16_t i2c_write(struct I2C * i2c, uint8_t * data, int16_t length) {
int16_t i;
int16_t i2c_write(struct I2C * i2c, uint8_t * data, uint16_t length) {
uint16_t i;
for (i = 0; i < length; i++) {
// load data into data register
TWDR = data[i];
@ -65,8 +65,8 @@ int16_t i2c_write(struct I2C * i2c, uint8_t * data, int16_t length) {
return i;
}
int16_t i2c_read(struct I2C * i2c, uint8_t * data, int16_t length) {
int16_t i;
int16_t i2c_read(struct I2C * i2c, uint8_t * data, uint16_t length) {
uint16_t i;
for (i = 0; i < length; i++) {
if ((i + 1) < length) {
// start TWI module and acknowledge data after reception