From 2a4255ce15333389258b22c52843443aa617eb5b Mon Sep 17 00:00:00 2001
From: Jeremy Soller <jeremy@system76.com>
Date: Wed, 12 Feb 2020 14:25:18 -0700
Subject: [PATCH] Do not hold super-p when using display mode hotkey

---
 src/board/system76/darp5/kbscan.c   | 16 ++++++++--------
 src/board/system76/galp3-c/kbscan.c | 16 ++++++++--------
 src/board/system76/lemp9/kbscan.c   | 16 ++++++++--------
 3 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/src/board/system76/darp5/kbscan.c b/src/board/system76/darp5/kbscan.c
index 275acab..9659320 100644
--- a/src/board/system76/darp5/kbscan.c
+++ b/src/board/system76/darp5/kbscan.c
@@ -49,22 +49,22 @@ bool kbscan_press(uint16_t key, bool pressed, uint8_t * layer) {
                 case COMBO_DISPLAY_MODE:
                     if (kbscan_enabled) {
                         if (pressed) {
-                            kbc_scancode(&KBC, K_LEFT_SUPER, pressed);
-                            kbc_scancode(&KBC, K_P, pressed);
+                            kbc_scancode(&KBC, K_LEFT_SUPER, true);
+                            kbc_scancode(&KBC, K_P, true);
+                            kbc_scancode(&KBC, K_P, false);
                         } else {
-                            kbc_scancode(&KBC, K_P, pressed);
-                            kbc_scancode(&KBC, K_LEFT_SUPER, pressed);
+                            kbc_scancode(&KBC, K_LEFT_SUPER, false);
                         }
                     }
                     break;
                 case COMBO_PRINT_SCREEN:
                     if (kbscan_enabled) {
                         if (pressed) {
-                            kbc_scancode(&KBC, K_E0 | 0x12, pressed);
-                            kbc_scancode(&KBC, K_E0 | 0x7C, pressed);
+                            kbc_scancode(&KBC, K_E0 | 0x12, true);
+                            kbc_scancode(&KBC, K_E0 | 0x7C, true);
                         } else {
-                            kbc_scancode(&KBC, K_E0 | 0x7C, pressed);
-                            kbc_scancode(&KBC, K_E0 | 0x12, pressed);
+                            kbc_scancode(&KBC, K_E0 | 0x7C, false);
+                            kbc_scancode(&KBC, K_E0 | 0x12, false);
                         }
                     }
                     break;
diff --git a/src/board/system76/galp3-c/kbscan.c b/src/board/system76/galp3-c/kbscan.c
index 05a7446..a14be2d 100644
--- a/src/board/system76/galp3-c/kbscan.c
+++ b/src/board/system76/galp3-c/kbscan.c
@@ -50,22 +50,22 @@ bool kbscan_press(uint16_t key, bool pressed, uint8_t * layer) {
                 case COMBO_DISPLAY_MODE:
                     if (kbscan_enabled) {
                         if (pressed) {
-                            kbc_scancode(&KBC, K_LEFT_SUPER, pressed);
-                            kbc_scancode(&KBC, K_P, pressed);
+                            kbc_scancode(&KBC, K_LEFT_SUPER, true);
+                            kbc_scancode(&KBC, K_P, true);
+                            kbc_scancode(&KBC, K_P, false);
                         } else {
-                            kbc_scancode(&KBC, K_P, pressed);
-                            kbc_scancode(&KBC, K_LEFT_SUPER, pressed);
+                            kbc_scancode(&KBC, K_LEFT_SUPER, false);
                         }
                     }
                     break;
                 case COMBO_PRINT_SCREEN:
                     if (kbscan_enabled) {
                         if (pressed) {
-                            kbc_scancode(&KBC, K_E0 | 0x12, pressed);
-                            kbc_scancode(&KBC, K_E0 | 0x7C, pressed);
+                            kbc_scancode(&KBC, K_E0 | 0x12, true);
+                            kbc_scancode(&KBC, K_E0 | 0x7C, true);
                         } else {
-                            kbc_scancode(&KBC, K_E0 | 0x7C, pressed);
-                            kbc_scancode(&KBC, K_E0 | 0x12, pressed);
+                            kbc_scancode(&KBC, K_E0 | 0x7C, false);
+                            kbc_scancode(&KBC, K_E0 | 0x12, false);
                         }
                     }
                     break;
diff --git a/src/board/system76/lemp9/kbscan.c b/src/board/system76/lemp9/kbscan.c
index 05a7446..a14be2d 100644
--- a/src/board/system76/lemp9/kbscan.c
+++ b/src/board/system76/lemp9/kbscan.c
@@ -50,22 +50,22 @@ bool kbscan_press(uint16_t key, bool pressed, uint8_t * layer) {
                 case COMBO_DISPLAY_MODE:
                     if (kbscan_enabled) {
                         if (pressed) {
-                            kbc_scancode(&KBC, K_LEFT_SUPER, pressed);
-                            kbc_scancode(&KBC, K_P, pressed);
+                            kbc_scancode(&KBC, K_LEFT_SUPER, true);
+                            kbc_scancode(&KBC, K_P, true);
+                            kbc_scancode(&KBC, K_P, false);
                         } else {
-                            kbc_scancode(&KBC, K_P, pressed);
-                            kbc_scancode(&KBC, K_LEFT_SUPER, pressed);
+                            kbc_scancode(&KBC, K_LEFT_SUPER, false);
                         }
                     }
                     break;
                 case COMBO_PRINT_SCREEN:
                     if (kbscan_enabled) {
                         if (pressed) {
-                            kbc_scancode(&KBC, K_E0 | 0x12, pressed);
-                            kbc_scancode(&KBC, K_E0 | 0x7C, pressed);
+                            kbc_scancode(&KBC, K_E0 | 0x12, true);
+                            kbc_scancode(&KBC, K_E0 | 0x7C, true);
                         } else {
-                            kbc_scancode(&KBC, K_E0 | 0x7C, pressed);
-                            kbc_scancode(&KBC, K_E0 | 0x12, pressed);
+                            kbc_scancode(&KBC, K_E0 | 0x7C, false);
+                            kbc_scancode(&KBC, K_E0 | 0x12, false);
                         }
                     }
                     break;