From 59c386ec12bd5ca325aa419481bf70e59f57c2bd Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Wed, 18 Jan 2023 16:30:39 -0700 Subject: [PATCH] Move gpio_debug from board to EC code The gpio_debug() functionality depends on the ITE registers and not anything board-specific. Signed-off-by: Tim Crawford --- src/board/system76/addw1/gpio.c | 39 +----------------- src/board/system76/addw1/include/board/gpio.h | 1 - src/board/system76/addw2/gpio.c | 39 +----------------- src/board/system76/addw2/include/board/gpio.h | 1 - src/board/system76/bonw14/gpio.c | 39 +----------------- .../system76/bonw14/include/board/gpio.h | 1 - src/board/system76/common/main.c | 2 +- src/board/system76/darp5/gpio.c | 39 +----------------- src/board/system76/darp5/include/board/gpio.h | 1 - src/board/system76/darp7/gpio.c | 41 ------------------- src/board/system76/darp7/include/board/gpio.h | 1 - src/board/system76/darp8/gpio.c | 41 ------------------- src/board/system76/darp8/include/board/gpio.h | 1 - src/board/system76/galp3-c/gpio.c | 39 +----------------- .../system76/galp3-c/include/board/gpio.h | 1 - src/board/system76/galp5/gpio.c | 41 ------------------- src/board/system76/galp5/include/board/gpio.h | 1 - src/board/system76/galp6/gpio.c | 41 ------------------- src/board/system76/galp6/include/board/gpio.h | 1 - src/board/system76/gaze15/gpio.c | 39 +----------------- .../system76/gaze15/include/board/gpio.h | 1 - src/board/system76/gaze16-3050/gpio.c | 39 +----------------- .../system76/gaze16-3050/include/board/gpio.h | 1 - src/board/system76/gaze16-3060/gpio.c | 39 +----------------- .../system76/gaze16-3060/include/board/gpio.h | 1 - src/board/system76/gaze17-3050/gpio.c | 39 +----------------- .../system76/gaze17-3050/include/board/gpio.h | 1 - src/board/system76/gaze17-3060/gpio.c | 39 +----------------- .../system76/gaze17-3060/include/board/gpio.h | 1 - src/board/system76/lemp10/gpio.c | 41 ------------------- .../system76/lemp10/include/board/gpio.h | 1 - src/board/system76/lemp11/gpio.c | 41 ------------------- .../system76/lemp11/include/board/gpio.h | 1 - src/board/system76/lemp9/gpio.c | 39 +----------------- src/board/system76/lemp9/include/board/gpio.h | 1 - src/board/system76/oryp5/gpio.c | 39 +----------------- src/board/system76/oryp5/include/board/gpio.h | 1 - src/board/system76/oryp6/gpio.c | 38 ----------------- src/board/system76/oryp6/include/board/gpio.h | 1 - src/board/system76/oryp7/gpio.c | 38 ----------------- src/board/system76/oryp7/include/board/gpio.h | 1 - src/board/system76/oryp8/gpio.c | 39 +----------------- src/board/system76/oryp8/include/board/gpio.h | 1 - src/board/system76/oryp9/gpio.c | 41 ------------------- src/board/system76/oryp9/include/board/gpio.h | 1 - src/ec/ite/gpio.c | 41 +++++++++++++++++++ src/ec/ite/include/ec/gpio.h | 4 ++ 47 files changed, 59 insertions(+), 880 deletions(-) diff --git a/src/board/system76/addw1/gpio.c b/src/board/system76/addw1/gpio.c index fccca53..88a8d03 100644 --- a/src/board/system76/addw1/gpio.c +++ b/src/board/system76/addw1/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 6); @@ -239,40 +239,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/addw1/include/board/gpio.h b/src/board/system76/addw1/include/board/gpio.h index 4b1c4eb..5895c08 100644 --- a/src/board/system76/addw1/include/board/gpio.h +++ b/src/board/system76/addw1/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/addw2/gpio.c b/src/board/system76/addw2/gpio.c index c8a2f67..e40f6d1 100644 --- a/src/board/system76/addw2/gpio.c +++ b/src/board/system76/addw2/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -243,40 +243,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/addw2/include/board/gpio.h b/src/board/system76/addw2/include/board/gpio.h index 83ee931..b2a70f7 100644 --- a/src/board/system76/addw2/include/board/gpio.h +++ b/src/board/system76/addw2/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/bonw14/gpio.c b/src/board/system76/bonw14/gpio.c index 77ae15c..523dad9 100644 --- a/src/board/system76/bonw14/gpio.c +++ b/src/board/system76/bonw14/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -237,40 +237,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/bonw14/include/board/gpio.h b/src/board/system76/bonw14/include/board/gpio.h index 2469404..be21ee3 100644 --- a/src/board/system76/bonw14/include/board/gpio.h +++ b/src/board/system76/bonw14/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/common/main.c b/src/board/system76/common/main.c index 5fc77d2..2266b9e 100644 --- a/src/board/system76/common/main.c +++ b/src/board/system76/common/main.c @@ -90,7 +90,7 @@ void main(void) { INFO("\n"); -#if GPIO_DEBUG +#ifdef GPIO_DEBUG gpio_debug(); #endif diff --git a/src/board/system76/darp5/gpio.c b/src/board/system76/darp5/gpio.c index fbc60f7..84ff19e 100644 --- a/src/board/system76/darp5/gpio.c +++ b/src/board/system76/darp5/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 6); @@ -239,40 +239,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/darp5/include/board/gpio.h b/src/board/system76/darp5/include/board/gpio.h index 45c89fb..7f7ed19 100644 --- a/src/board/system76/darp5/include/board/gpio.h +++ b/src/board/system76/darp5/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/darp7/gpio.c b/src/board/system76/darp7/gpio.c index 6d2e286..4d600a7 100644 --- a/src/board/system76/darp7/gpio.c +++ b/src/board/system76/darp7/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -248,43 +247,3 @@ void gpio_init() { // ALERT# GPCRM6 = 0x86; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d: data %d mirror %d pot %d control %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#define GPOTM 0 - bank(M); -#undef GPOTM -#undef bank -} -#endif diff --git a/src/board/system76/darp7/include/board/gpio.h b/src/board/system76/darp7/include/board/gpio.h index e87303d..144dc1b 100644 --- a/src/board/system76/darp7/include/board/gpio.h +++ b/src/board/system76/darp7/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/darp8/gpio.c b/src/board/system76/darp8/gpio.c index 2605a6b..70ab0a9 100644 --- a/src/board/system76/darp8/gpio.c +++ b/src/board/system76/darp8/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -255,43 +254,3 @@ void gpio_init(void) { // ESPI_ALRT0# GPCRM6 = GPIO_IN | GPIO_UP | GPIO_DOWN; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d: data %d mirror %d pot %d control %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#define GPOTM 0 - bank(M); -#undef GPOTM -#undef bank -} -#endif diff --git a/src/board/system76/darp8/include/board/gpio.h b/src/board/system76/darp8/include/board/gpio.h index 03a28c5..7afea28 100644 --- a/src/board/system76/darp8/include/board/gpio.h +++ b/src/board/system76/darp8/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/galp3-c/gpio.c b/src/board/system76/galp3-c/gpio.c index 187383b..9d76eb6 100644 --- a/src/board/system76/galp3-c/gpio.c +++ b/src/board/system76/galp3-c/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 6); @@ -239,40 +239,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/galp3-c/include/board/gpio.h b/src/board/system76/galp3-c/include/board/gpio.h index 45c89fb..7f7ed19 100644 --- a/src/board/system76/galp3-c/include/board/gpio.h +++ b/src/board/system76/galp3-c/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/galp5/gpio.c b/src/board/system76/galp5/gpio.c index 371e5d4..8c935c7 100644 --- a/src/board/system76/galp5/gpio.c +++ b/src/board/system76/galp5/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -250,43 +249,3 @@ void gpio_init() { // ALERT# GPCRM6 = GPIO_IN | GPIO_UP; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d: data %d mirror %d pot %d control %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#define GPOTM 0 - bank(M); -#undef GPOTM -#undef bank -} -#endif diff --git a/src/board/system76/galp5/include/board/gpio.h b/src/board/system76/galp5/include/board/gpio.h index 66999cc..ecd00e4 100644 --- a/src/board/system76/galp5/include/board/gpio.h +++ b/src/board/system76/galp5/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/galp6/gpio.c b/src/board/system76/galp6/gpio.c index 5351809..fb8d2b3 100644 --- a/src/board/system76/galp6/gpio.c +++ b/src/board/system76/galp6/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -259,43 +258,3 @@ void gpio_init(void) { // ESPI_ALRT0# GPCRM6 = GPIO_IN | GPIO_UP | GPIO_DOWN; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d: data %d mirror %d pot %d control %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#define GPOTM 0 - bank(M); -#undef GPOTM -#undef bank -} -#endif diff --git a/src/board/system76/galp6/include/board/gpio.h b/src/board/system76/galp6/include/board/gpio.h index 02e19e4..297fc1c 100644 --- a/src/board/system76/galp6/include/board/gpio.h +++ b/src/board/system76/galp6/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/gaze15/gpio.c b/src/board/system76/gaze15/gpio.c index d3d3374..9f0f36c 100644 --- a/src/board/system76/gaze15/gpio.c +++ b/src/board/system76/gaze15/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -238,40 +238,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/gaze15/include/board/gpio.h b/src/board/system76/gaze15/include/board/gpio.h index 38ee071..a19bc09 100644 --- a/src/board/system76/gaze15/include/board/gpio.h +++ b/src/board/system76/gaze15/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/gaze16-3050/gpio.c b/src/board/system76/gaze16-3050/gpio.c index 6c72626..4230cf2 100644 --- a/src/board/system76/gaze16-3050/gpio.c +++ b/src/board/system76/gaze16-3050/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -243,40 +243,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_IN | GPIO_UP; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/gaze16-3050/include/board/gpio.h b/src/board/system76/gaze16-3050/include/board/gpio.h index 268c533..b90227f 100644 --- a/src/board/system76/gaze16-3050/include/board/gpio.h +++ b/src/board/system76/gaze16-3050/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); extern struct Gpio __code ACIN_N; extern struct Gpio __code AC_PRESENT; diff --git a/src/board/system76/gaze16-3060/gpio.c b/src/board/system76/gaze16-3060/gpio.c index f555ab8..db48347 100644 --- a/src/board/system76/gaze16-3060/gpio.c +++ b/src/board/system76/gaze16-3060/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -243,40 +243,3 @@ void gpio_init() { // ESPI_ALRT0# GPCRM6 = GPIO_IN | GPIO_UP; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/gaze16-3060/include/board/gpio.h b/src/board/system76/gaze16-3060/include/board/gpio.h index 50af040..38ef955 100644 --- a/src/board/system76/gaze16-3060/include/board/gpio.h +++ b/src/board/system76/gaze16-3060/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); extern struct Gpio __code ACIN_N; extern struct Gpio __code AC_PRESENT; diff --git a/src/board/system76/gaze17-3050/gpio.c b/src/board/system76/gaze17-3050/gpio.c index 55d0eac..7438ddb 100644 --- a/src/board/system76/gaze17-3050/gpio.c +++ b/src/board/system76/gaze17-3050/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -241,40 +241,3 @@ void gpio_init() { // ESPI_ALRT0# GPCRM6 = GPIO_IN | GPIO_UP; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/gaze17-3050/include/board/gpio.h b/src/board/system76/gaze17-3050/include/board/gpio.h index e6a325f..b94319c 100644 --- a/src/board/system76/gaze17-3050/include/board/gpio.h +++ b/src/board/system76/gaze17-3050/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); extern struct Gpio __code ACIN_N; extern struct Gpio __code AC_PRESENT; diff --git a/src/board/system76/gaze17-3060/gpio.c b/src/board/system76/gaze17-3060/gpio.c index ceace92..3ca7eb5 100644 --- a/src/board/system76/gaze17-3060/gpio.c +++ b/src/board/system76/gaze17-3060/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -247,40 +247,3 @@ void gpio_init() { // ESPI_ALRT0# GPCRM6 = GPIO_IN | GPIO_UP; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/gaze17-3060/include/board/gpio.h b/src/board/system76/gaze17-3060/include/board/gpio.h index e6a325f..b94319c 100644 --- a/src/board/system76/gaze17-3060/include/board/gpio.h +++ b/src/board/system76/gaze17-3060/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); extern struct Gpio __code ACIN_N; extern struct Gpio __code AC_PRESENT; diff --git a/src/board/system76/lemp10/gpio.c b/src/board/system76/lemp10/gpio.c index 7e9ec31..318bb89 100644 --- a/src/board/system76/lemp10/gpio.c +++ b/src/board/system76/lemp10/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -247,43 +246,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_IN | GPIO_UP | GPIO_DOWN; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d: data %d mirror %d pot %d control %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#define GPOTM 0 - bank(M); -#undef GPOTM -#undef bank -} -#endif diff --git a/src/board/system76/lemp10/include/board/gpio.h b/src/board/system76/lemp10/include/board/gpio.h index 7cbe749..d801ba0 100644 --- a/src/board/system76/lemp10/include/board/gpio.h +++ b/src/board/system76/lemp10/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/lemp11/gpio.c b/src/board/system76/lemp11/gpio.c index 654b9ae..1820941 100644 --- a/src/board/system76/lemp11/gpio.c +++ b/src/board/system76/lemp11/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -259,43 +258,3 @@ void gpio_init(void) { // ESPI_ALRT0# GPCRM6 = GPIO_IN | GPIO_UP | GPIO_DOWN; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d: data %d mirror %d pot %d control %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#define GPOTM 0 - bank(M); -#undef GPOTM -#undef bank -} -#endif diff --git a/src/board/system76/lemp11/include/board/gpio.h b/src/board/system76/lemp11/include/board/gpio.h index 76eb5c5..a78dd94 100644 --- a/src/board/system76/lemp11/include/board/gpio.h +++ b/src/board/system76/lemp11/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/lemp9/gpio.c b/src/board/system76/lemp9/gpio.c index 1ef9ec1..c02f071 100644 --- a/src/board/system76/lemp9/gpio.c +++ b/src/board/system76/lemp9/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -237,40 +237,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/lemp9/include/board/gpio.h b/src/board/system76/lemp9/include/board/gpio.h index 5aa774a..2089040 100644 --- a/src/board/system76/lemp9/include/board/gpio.h +++ b/src/board/system76/lemp9/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/oryp5/gpio.c b/src/board/system76/oryp5/gpio.c index 287d903..66ed277 100644 --- a/src/board/system76/oryp5/gpio.c +++ b/src/board/system76/oryp5/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 6); @@ -244,40 +244,3 @@ void gpio_init(void) { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/oryp5/include/board/gpio.h b/src/board/system76/oryp5/include/board/gpio.h index 2b34e56..4831366 100644 --- a/src/board/system76/oryp5/include/board/gpio.h +++ b/src/board/system76/oryp5/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/oryp6/gpio.c b/src/board/system76/oryp6/gpio.c index 9a408f6..fdd97fc 100644 --- a/src/board/system76/oryp6/gpio.c +++ b/src/board/system76/oryp6/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -242,40 +241,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/oryp6/include/board/gpio.h b/src/board/system76/oryp6/include/board/gpio.h index cb206d4..44144c4 100644 --- a/src/board/system76/oryp6/include/board/gpio.h +++ b/src/board/system76/oryp6/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/oryp7/gpio.c b/src/board/system76/oryp7/gpio.c index 6d461f9..8b2f142 100644 --- a/src/board/system76/oryp7/gpio.c +++ b/src/board/system76/oryp7/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -241,40 +240,3 @@ void gpio_init() { // SERIRQ GPCRM6 = GPIO_ALT; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/oryp7/include/board/gpio.h b/src/board/system76/oryp7/include/board/gpio.h index f432b9b..39e7d98 100644 --- a/src/board/system76/oryp7/include/board/gpio.h +++ b/src/board/system76/oryp7/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/board/system76/oryp8/gpio.c b/src/board/system76/oryp8/gpio.c index 69fc20a..ca00cbd 100644 --- a/src/board/system76/oryp8/gpio.c +++ b/src/board/system76/oryp8/gpio.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include +#include // clang-format off struct Gpio __code ACIN_N = GPIO(B, 0); @@ -243,40 +243,3 @@ void gpio_init() { // SERIRQ_ESPI_ALERT0 GPCRM6 = GPIO_IN | GPIO_UP; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d:\n\tdata %d\n\tmirror %d\n\tpot %d\n\tcontrol %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#undef bank -} -#endif diff --git a/src/board/system76/oryp8/include/board/gpio.h b/src/board/system76/oryp8/include/board/gpio.h index a244e5c..080be9e 100644 --- a/src/board/system76/oryp8/include/board/gpio.h +++ b/src/board/system76/oryp8/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); extern struct Gpio __code ACIN_N; extern struct Gpio __code AC_PRESENT; diff --git a/src/board/system76/oryp9/gpio.c b/src/board/system76/oryp9/gpio.c index 83117ed..e7eec9e 100644 --- a/src/board/system76/oryp9/gpio.c +++ b/src/board/system76/oryp9/gpio.c @@ -1,7 +1,6 @@ // SPDX-License-Identifier: GPL-3.0-only #include -#include #include // clang-format off @@ -258,43 +257,3 @@ void gpio_init(void) { // ESPI_ALRT0# GPCRM6 = GPIO_IN | GPIO_UP | GPIO_DOWN; } - -#if GPIO_DEBUG -void gpio_debug_bank( - char *bank, - uint8_t data, - uint8_t mirror, - uint8_t pot, - volatile uint8_t *control -) { - for (char i = 0; i < 8; i++) { - DEBUG( - "%s%d: data %d mirror %d pot %d control %02X\n", - bank, - i, - (data >> i) & 1, - (mirror >> i) & 1, - (pot >> i) & 1, - *(control + i) - ); - } -} - -void gpio_debug(void) { -#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) - bank(A); - bank(B); - bank(C); - bank(D); - bank(E); - bank(F); - bank(G); - bank(H); - bank(I); - bank(J); -#define GPOTM 0 - bank(M); -#undef GPOTM -#undef bank -} -#endif diff --git a/src/board/system76/oryp9/include/board/gpio.h b/src/board/system76/oryp9/include/board/gpio.h index 10b338c..172626e 100644 --- a/src/board/system76/oryp9/include/board/gpio.h +++ b/src/board/system76/oryp9/include/board/gpio.h @@ -6,7 +6,6 @@ #include void gpio_init(void); -void gpio_debug(void); // clang-format off extern struct Gpio __code ACIN_N; diff --git a/src/ec/ite/gpio.c b/src/ec/ite/gpio.c index d4ec4f4..5e2c15d 100644 --- a/src/ec/ite/gpio.c +++ b/src/ec/ite/gpio.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-3.0-only #include +#include bool gpio_get(struct Gpio *gpio) { if (*(gpio->data) & gpio->value) { @@ -17,3 +18,43 @@ void gpio_set(struct Gpio *gpio, bool value) { *(gpio->data) &= ~(gpio->value); } } + +#ifdef GPIO_DEBUG +static void gpio_debug_bank( + char *bank, + uint8_t data, + uint8_t mirror, + uint8_t pot, + volatile uint8_t *control +) { + for (char i = 0; i < 8; i++) { + DEBUG( + "%s%d: data %d mirror %d pot %d control %02X\n", + bank, + i, + (data >> i) & 1, + (mirror >> i) & 1, + (pot >> i) & 1, + *(control + i) + ); + } +} + +void gpio_debug(void) { +#define bank(BANK) gpio_debug_bank(#BANK, GPDR##BANK, GPDMR##BANK, GPOT##BANK, &GPCR##BANK##0) + bank(A); + bank(B); + bank(C); + bank(D); + bank(E); + bank(F); + bank(G); + bank(H); + bank(I); + bank(J); +#define GPOTM 0 + bank(M); +#undef GPOTM +#undef bank +} +#endif // GPIO_DEBUG diff --git a/src/ec/ite/include/ec/gpio.h b/src/ec/ite/include/ec/gpio.h index 175c4f2..e821b63 100644 --- a/src/ec/ite/include/ec/gpio.h +++ b/src/ec/ite/include/ec/gpio.h @@ -35,6 +35,10 @@ struct Gpio { bool gpio_get(struct Gpio *gpio); void gpio_set(struct Gpio *gpio, bool value); +#ifdef GPIO_DEBUG +void gpio_debug(void); +#endif + volatile uint8_t __xdata __at(0x1600) GCR; volatile uint8_t __xdata __at(0x16F0) GCR1; volatile uint8_t __xdata __at(0x16F1) GCR2;