sravan/system76-embedded-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary sleeps from parallel_transaction

Browse Source
This commit is contained in:
Jeremy Soller 2020-03-14 20:38:52 -06:00
parent 8f3588ef6b
commit abcc8c00e0
No known key found for this signature in database
GPG Key ID: E988B49EE78A7FB1
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/board/arduino/mega2560/parallel.c
View File

@ -267,7 +267,6 @@ int parallel_transaction(struct Parallel * port, uint8_t * data, int length, boo
if (!read) { if (!read) {
byte = data[i]; byte = data[i];
parallel_write_data(port, byte); parallel_write_data(port, byte);
_delay_us(1);
} }
if (addr) { if (addr) {
@ -277,9 +276,8 @@ int parallel_transaction(struct Parallel * port, uint8_t * data, int length, boo
// Set data strobe low // Set data strobe low
gpio_set(port->data_n, false); gpio_set(port->data_n, false);
} }
_delay_us(1);
// Wait for peripheral to indicate it's ready // Wait for peripheral to indicate it's processing
while (!gpio_get(port->wait_n)) {} while (!gpio_get(port->wait_n)) {}
if (read) { if (read) {
@ -293,8 +291,9 @@ int parallel_transaction(struct Parallel * port, uint8_t * data, int length, boo
// Set data strobe high // Set data strobe high
gpio_set(port->data_n, true); gpio_set(port->data_n, true);
} }
// XXX: Arduino peripheral not fast enough to get the data?
_delay_us(5); // Wait for peripheral to indicate it's ready for next cycle
while (gpio_get(port->wait_n)) {}
if (!read) { if (!read) {
// Reset data lines to high // Reset data lines to high