sravan/system76-embedded-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix stalls in getting PECI information over eSPI

Browse Source
This commit is contained in:
Jeremy Soller
2023-02-22 11:00:33 -07:00
parent 9abd9d853a
commit cda67e6d1e
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/board/system76/common/peci.c
View File

@ -73,8 +73,7 @@ void peci_init(void) {}
// Returns true on success, false on error // Returns true on success, false on error
bool peci_get_temp(int16_t * data) { bool peci_get_temp(int16_t * data) {
// Wait for completion //TODO: Wait for completion?
while (ESUCTRL0 & ESUCTRL0_BUSY) {}
// Clear upstream status // Clear upstream status
ESUCTRL0 = ESUCTRL0; ESUCTRL0 = ESUCTRL0;
// Clear OOB status // Clear OOB status
@ -109,18 +108,11 @@ bool peci_get_temp(int16_t * data) {
// Set upstream go // Set upstream go
ESUCTRL0 |= ESUCTRL0_GO; ESUCTRL0 |= ESUCTRL0_GO;
// Wait while upstream busy // Wait until upstream done
while (ESUCTRL0 & ESUCTRL0_BUSY) {} while (!(ESUCTRL0 & ESUCTRL0_DONE)) {}
uint8_t status = ESUCTRL0;
if (status & ESUCTRL0_DONE) {
// Upstream is done
} else {
//TODO: Upstream not done, how do we get error message?
}
// Wait for response // Wait for response
//TODO: do this asynchronously to avoid delays //TODO: do this asynchronously to avoid delays?
while (!(ESOCTRL0 & ESOCTRL0_STATUS)) {} while (!(ESOCTRL0 & ESOCTRL0_STATUS)) {}
// Read response length // Read response length
@ -143,6 +135,7 @@ bool peci_get_temp(int16_t * data) {
// negative (0x1000 | status register) on PECI hardware error // negative (0x1000 | status register) on PECI hardware error
int16_t peci_wr_pkg_config(uint8_t index, uint16_t param, uint32_t data) { int16_t peci_wr_pkg_config(uint8_t index, uint16_t param, uint32_t data) {
//TODO: IMPLEMENT THIS STUB //TODO: IMPLEMENT THIS STUB
DEBUG("peci_wr_pkg_config %02X, %04X, %08X\n", index, param, data);
index = index; index = index;
param = param; param = param;
data = data; data = data;