sravan/system76-embedded-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve handling of second fan

Browse Source 
Replace hard-coded PWM channels with defines so the second fan on darp10
can be handled like the second fan on units with a dGPU.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
This commit is contained in:
Tim Crawford
2024-07-03 17:32:44 -06:00
committed by Tim Crawford
parent f8697a7ec4
commit e75a2f1e10
46 changed files with 125 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/board/system76/common/smfi.c
View File

@ -123,15 +123,16 @@ static enum Result cmd_print(void) {
static enum Result cmd_fan_get(void) {
switch (smfi_cmd[SMFI_CMD_DATA]) {
case 0:
// Get duty of fan 0
smfi_cmd[SMFI_CMD_DATA + 1] = DCR2;
return RES_OK;
case 1:
// Get duty of fan 1
//TODO: only allow on platforms like addw2
smfi_cmd[SMFI_CMD_DATA + 1] = DCR4;
// Get duty of FAN1
smfi_cmd[SMFI_CMD_DATA + 1] = FAN1_PWM;
return RES_OK;
#ifdef FAN2_PWM
case 2:
// Get duty of FAN2
smfi_cmd[SMFI_CMD_DATA + 1] = FAN2_PWM;
return RES_OK;
#endif
}
// Failed if fan not found
@ -140,15 +141,16 @@ static enum Result cmd_fan_get(void) {
static enum Result cmd_fan_set(void) {
switch (smfi_cmd[SMFI_CMD_DATA]) {
case 0:
// Set duty cycle of fan 0
DCR2 = smfi_cmd[SMFI_CMD_DATA + 1];
return RES_OK;
case 1:
// Set duty cycle of fan 1
//TODO: only allow on platforms like addw2
DCR4 = smfi_cmd[SMFI_CMD_DATA + 1];
// Set duty cycle of FAN1
FAN1_PWM = smfi_cmd[SMFI_CMD_DATA + 1];
return RES_OK;
#ifdef FAN2_PWM
case 2:
// Set duty cycle of FAN2
FAN2_PWM = smfi_cmd[SMFI_CMD_DATA + 1];
return RES_OK;
#endif
}
// Failed if fan not found