sravan/system76-embedded-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pwm: Reload counters when they reach 0

Browse Source 
Add IT5570E register that controls when the down counters are updated.
Set them to update when they reach 0, instead of immediately when DCRi
is written.

Fixes keyboard color changing when changing brightness levels if not
using 0xFF for an RGB value.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
This commit is contained in:
Tim Crawford
2022-10-11 13:18:14 -06:00
committed by Tim Crawford
parent 76019bdb61
commit f8d1123934
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/board/system76/common/pwm.c
View File

@ -26,6 +26,11 @@ void pwm_init(void) {
// Turn off CPU fan (temperature control in peci_get_fan_duty) // Turn off CPU fan (temperature control in peci_get_fan_duty)
DCR2 = 0; DCR2 = 0;
#ifdef it5570e
// Reload counters when they reach 0 instead of immediately
PWMLCCR = 0xFF;
#endif
// Enable PWM // Enable PWM
ZTIER = BIT(1); ZTIER = BIT(1);
} }

5
src/ec/ite/include/ec/pwm.h
View File

@ -62,4 +62,9 @@ volatile uint8_t __xdata __at(0x1823) ZTIER;
// Tachometer switch control register // Tachometer switch control register
volatile uint8_t __xdata __at(0x1848) TSWCTLR; volatile uint8_t __xdata __at(0x1848) TSWCTLR;
#ifdef it5570e
// PWM Load Counter Control Register
volatile uint8_t __xdata __at(0x185A) PWMLCCR;
#endif
#endif // _EC_PWM_H #endif // _EC_PWM_H