sravan/system76-embedded-controller
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary PMC burst loop

Browse Source
This commit is contained in:
Jeremy Soller 2020-02-17 14:38:01 -07:00
parent ebcb6af3f5
commit fa8447cd4d
No known key found for this signature in database
GPG Key ID: E988B49EE78A7FB1
3 changed files with 249 additions and 270 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/board/system76/darp5/pmc.c
View File

@ -54,8 +54,6 @@ void pmc_event(struct Pmc * pmc) {
static enum PmcState state = PMC_STATE_DEFAULT; static enum PmcState state = PMC_STATE_DEFAULT;
static uint8_t state_data = 0; static uint8_t state_data = 0;
uint8_t burst_timeout;
for (burst_timeout = 1; burst_timeout > 0; burst_timeout--) {
uint8_t sts = pmc_status(pmc); uint8_t sts = pmc_status(pmc);
if (!(sts & PMC_STS_OBF)) { if (!(sts & PMC_STS_OBF)) {
switch (state) { switch (state) {
@ -88,8 +86,6 @@ void pmc_event(struct Pmc * pmc) {
break; break;
case 0x82: case 0x82:
DEBUG(" burst enable\n"); DEBUG(" burst enable\n");
// Run pmc_event in a tight loop for more iterations
burst_timeout = 100;
// Set burst bit // Set burst bit
pmc_set_status(pmc, sts | (1 << 4)); pmc_set_status(pmc, sts | (1 << 4));
// Send acknowledgement byte // Send acknowledgement byte
@ -98,8 +94,6 @@ void pmc_event(struct Pmc * pmc) {
break; break;
case 0x83: case 0x83:
DEBUG(" burst disable\n"); DEBUG(" burst disable\n");
// Exit pmc_event tight loop
burst_timeout = 0;
// Clear burst bit // Clear burst bit
pmc_set_status(pmc, sts & ~(1 << 4)); pmc_set_status(pmc, sts & ~(1 << 4));
// Send SCI for IBF=0 // Send SCI for IBF=0
@ -150,4 +144,3 @@ void pmc_event(struct Pmc * pmc) {
} }
} }
} }
}

7
src/board/system76/galp3-c/pmc.c
View File

@ -54,8 +54,6 @@ void pmc_event(struct Pmc * pmc) {
static enum PmcState state = PMC_STATE_DEFAULT; static enum PmcState state = PMC_STATE_DEFAULT;
static uint8_t state_data = 0; static uint8_t state_data = 0;
uint8_t burst_timeout;
for (burst_timeout = 1; burst_timeout > 0; burst_timeout--) {
uint8_t sts = pmc_status(pmc); uint8_t sts = pmc_status(pmc);
if (!(sts & PMC_STS_OBF)) { if (!(sts & PMC_STS_OBF)) {
switch (state) { switch (state) {
@ -88,8 +86,6 @@ void pmc_event(struct Pmc * pmc) {
break; break;
case 0x82: case 0x82:
DEBUG(" burst enable\n"); DEBUG(" burst enable\n");
// Run pmc_event in a tight loop for more iterations
burst_timeout = 100;
// Set burst bit // Set burst bit
pmc_set_status(pmc, sts | (1 << 4)); pmc_set_status(pmc, sts | (1 << 4));
// Send acknowledgement byte // Send acknowledgement byte
@ -98,8 +94,6 @@ void pmc_event(struct Pmc * pmc) {
break; break;
case 0x83: case 0x83:
DEBUG(" burst disable\n"); DEBUG(" burst disable\n");
// Exit pmc_event tight loop
burst_timeout = 0;
// Clear burst bit // Clear burst bit
pmc_set_status(pmc, sts & ~(1 << 4)); pmc_set_status(pmc, sts & ~(1 << 4));
// Send SCI for IBF=0 // Send SCI for IBF=0
@ -150,4 +144,3 @@ void pmc_event(struct Pmc * pmc) {
} }
} }
} }
}

7
src/board/system76/lemp9/pmc.c
View File

@ -54,8 +54,6 @@ void pmc_event(struct Pmc * pmc) {
static enum PmcState state = PMC_STATE_DEFAULT; static enum PmcState state = PMC_STATE_DEFAULT;
static uint8_t state_data = 0; static uint8_t state_data = 0;
uint8_t burst_timeout;
for (burst_timeout = 1; burst_timeout > 0; burst_timeout--) {
uint8_t sts = pmc_status(pmc); uint8_t sts = pmc_status(pmc);
if (!(sts & PMC_STS_OBF)) { if (!(sts & PMC_STS_OBF)) {
switch (state) { switch (state) {
@ -88,8 +86,6 @@ void pmc_event(struct Pmc * pmc) {
break; break;
case 0x82: case 0x82:
DEBUG(" burst enable\n"); DEBUG(" burst enable\n");
// Run pmc_event in a tight loop for more iterations
burst_timeout = 100;
// Set burst bit // Set burst bit
pmc_set_status(pmc, sts | (1 << 4)); pmc_set_status(pmc, sts | (1 << 4));
// Send acknowledgement byte // Send acknowledgement byte
@ -98,8 +94,6 @@ void pmc_event(struct Pmc * pmc) {
break; break;
case 0x83: case 0x83:
DEBUG(" burst disable\n"); DEBUG(" burst disable\n");
// Exit pmc_event tight loop
burst_timeout = 0;
// Clear burst bit // Clear burst bit
pmc_set_status(pmc, sts & ~(1 << 4)); pmc_set_status(pmc, sts & ~(1 << 4));
// Send SCI for IBF=0 // Send SCI for IBF=0
@ -150,4 +144,3 @@ void pmc_event(struct Pmc * pmc) {
} }
} }
} }
}