Files
system76-embedded-controller/tool/src/spi.rs
Tim Crawford 43e5cf4ba3 Fix or silence clippy warnings on nightly
Fix:
- dead_code
- clippy::if_then_panic
- clippy::manual_memcpy
- clippy::needless_borrow

Silence:
- clippy::missing_safety_doc
- clippy::needless_range_loop
- clippy::single_match

Signed-off-by: Tim Crawford <tcrawford@system76.com>
2021-10-26 11:35:48 -06:00

219 lines
5.7 KiB
Rust

// SPDX-License-Identifier: MIT
use crate::{
Error,
Timeout,
};
/// SPI bus transactions
pub trait Spi {
/// Return the target of the SPI bus
fn target(&self) -> SpiTarget;
/// Reset the SPI bus
unsafe fn reset(&mut self) -> Result<(), Error>;
/// Read data from the SPI bus
unsafe fn read(&mut self, data: &mut [u8]) -> Result<usize, Error>;
/// Write data to the SPI bus
unsafe fn write(&mut self, data: &[u8]) -> Result<usize, Error>;
}
/// Target which will receive SPI commands
#[derive(Clone, Copy)]
pub enum SpiTarget {
/// The ROM normally used by the EC
Main,
/// The ROM used by the EC should the main ROM be invalid
Backup,
}
/// SPI ROM transactions
pub struct SpiRom<'a, S: Spi, T: Timeout> {
spi: &'a mut S,
timeout: T,
}
impl<'a, S: Spi, T: Timeout> SpiRom<'a, S, T> {
/// Create a SPI ROM using the specified SPI bus and timeout
pub fn new(spi: &'a mut S, timeout: T) -> Self {
Self {
spi,
timeout,
}
}
/// Get sector size in bytes
pub fn sector_size(&self) -> usize {
//TODO: can this be determined automatically?
match self.spi.target() {
SpiTarget::Main => 1024,
SpiTarget::Backup => 4096,
}
}
/// Read the status register
pub unsafe fn status(&mut self) -> Result<u8, Error> {
let mut status = [0];
self.spi.reset()?;
self.spi.write(&[0x05])?;
self.spi.read(&mut status)?;
Ok(status[0])
}
/// Wait for the status register to have `mask` bits set to `value`
pub unsafe fn status_wait(&mut self, mask: u8, value: u8) -> Result<(), Error> {
self.timeout.reset();
while self.timeout.running() {
if self.status()? & mask == value {
return Ok(());
}
}
Err(Error::Timeout)
}
/// Disable writes
pub unsafe fn write_disable(&mut self) -> Result<(), Error> {
self.spi.reset()?;
self.spi.write(&[0x04])?;
// Poll status for busy unset and write enable unset
self.status_wait(3, 0)?;
Ok(())
}
/// Enable writes
pub unsafe fn write_enable(&mut self) -> Result<(), Error> {
self.spi.reset()?;
self.spi.write(&[0x06])?;
// Poll status for busy unset and write enable set
self.status_wait(3, 2)?;
Ok(())
}
/// Erase a sector with the specified address
pub unsafe fn erase_sector(&mut self, address: u32) -> Result<(), Error> {
if (address & 0xFF00_0000) > 0 {
return Err(Error::Parameter);
}
let instruction = match self.spi.target() {
SpiTarget::Main => 0xD7,
SpiTarget::Backup => 0x20,
};
self.write_enable()?;
self.spi.reset()?;
self.spi.write(&[
instruction,
(address >> 16) as u8,
(address >> 8) as u8,
address as u8,
])?;
// Poll status for busy unset
self.status_wait(1, 0)?;
self.write_disable()?;
Ok(())
}
/// Read at a specific address
pub unsafe fn read_at(&mut self, address: u32, data: &mut [u8]) -> Result<usize, Error> {
if (address & 0xFF00_0000) > 0 {
return Err(Error::Parameter);
}
self.spi.reset()?;
self.spi.write(&[
0x0B,
(address >> 16) as u8,
(address >> 8) as u8,
address as u8,
0,
])?;
self.spi.read(data)
}
/// Write at a specific address
pub unsafe fn write_at(&mut self, address: u32, data: &[u8]) -> Result<usize, Error> {
if (address & 0xFF00_0000) > 0 {
return Err(Error::Parameter);
}
self.write_enable()?;
//TODO: automatically detect write command
match self.spi.target() {
SpiTarget::Main => for (i, word) in data.chunks(2).enumerate() {
let low = *word.get(0).unwrap_or(&0xFF);
let high = *word.get(1).unwrap_or(&0xFF);
self.spi.reset()?;
if i == 0 {
self.spi.write(&[
0xAD,
(address >> 16) as u8,
(address >> 8) as u8,
address as u8,
low,
high
])?;
} else {
self.spi.write(&[
0xAD,
low,
high
])?;
}
// Poll status for busy unset
self.status_wait(1, 0)?;
},
SpiTarget::Backup => for (i, page) in data.chunks(256).enumerate() {
let page_address = address + i as u32 * 256;
if page_address % 256 != 0 {
return Err(Error::Parameter);
}
if i > 0 {
// Write enable clears after each page is written
self.write_enable()?;
}
self.spi.reset()?;
self.spi.write(&[
0xF2,
(page_address >> 16) as u8,
(page_address >> 8) as u8,
page_address as u8,
])?;
self.spi.write(page)?;
// Poll status for busy unset
self.status_wait(1, 0)?;
},
}
self.write_disable()?;
Ok(data.len())
}
}
impl<'a, S: Spi, T: Timeout> Drop for SpiRom<'a, S, T> {
fn drop(&mut self) {
unsafe {
let _ = self.write_disable();
}
}
}