sravan/system76-firmware-open
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scripts: Version EC separately from SBIOS

Browse Source 
The original rationale for having the EC version match the SBIOS version
was to ensure that compatible versions of each were installed. So we set
the EC version to the SBIOS version and always flash both of them, even
if only one actually changed.

At some point, a mechanism should be implemented that checks for a
minimum supported/compatible version. This would be comparable to the
LVFS MetaInfo's "requires" field.

Ref: f4f4d5b61dbe ("Build EC as a submodule, specifying version")
Signed-off-by: Tim Crawford <tcrawford@system76.com>
This commit is contained in:
Tim Crawford 2024-01-23 08:46:15 -07:00
parent 7a2d4da31f
commit 1d973574fe
No known key found for this signature in database
GPG Key ID: 68E558D2BBD856E3
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -21,6 +21,7 @@ features apply to your model and firmware version, see the
- adl: Fixed PCIe 4.0 drives in PCIe 3.0 slot failing to initialize on resume - adl: Fixed PCIe 4.0 drives in PCIe 3.0 slot failing to initialize on resume
- rpl: Fixed PCIe 4.0 drives in PCIe 3.0 slot failing to initialize on resume - rpl: Fixed PCIe 4.0 drives in PCIe 3.0 slot failing to initialize on resume
- rpl: Fixed TCSS ACPI access - rpl: Fixed TCSS ACPI access
- Changed the EC version to be distinct from the SBIOS version
## 2024-01-18 ## 2024-01-18

2
scripts/_build/ec.sh
View File

@ -20,5 +20,5 @@ done < "$1"
BUILD_DIR="build" BUILD_DIR="build"
make -C ec BUILD="$BUILD_DIR" clean make -C ec BUILD="$BUILD_DIR" clean
make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)" make -C ec "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
cp "ec/$BUILD_DIR/ec.rom" "$2" cp "ec/$BUILD_DIR/ec.rom" "$2"

1
scripts/build.sh
View File

@ -87,7 +87,6 @@ KERNELVERSION="${VERSION}" \
# Rebuild EC firmware for System76 EC models # Rebuild EC firmware for System76 EC models
if [ ! -e "${MODEL_DIR}/ec.rom" ] && [ -e "${MODEL_DIR}/ec.config" ] if [ ! -e "${MODEL_DIR}/ec.rom" ] && [ -e "${MODEL_DIR}/ec.config" ]
then then
env VERSION="${VERSION}" \
./scripts/_build/ec.sh \ ./scripts/_build/ec.sh \
"${MODEL_DIR}/ec.config" \ "${MODEL_DIR}/ec.config" \
"${BUILD}/ec.rom" "${BUILD}/ec.rom"