The original rationale for having the EC version match the SBIOS version
was to ensure that compatible versions of each were installed. So we set
the EC version to the SBIOS version and always flash both of them, even
if only one actually changed.
At some point, a mechanism should be implemented that checks for a
minimum supported/compatible version. This would be comparable to the
LVFS MetaInfo's "requires" field.
Ref: f4f4d5b61dbe ("Build EC as a submodule, specifying version")
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Report issues by shell files with:
git ls-files '*.sh' | xargs shellcheck --exclude=SC2162
Address the following:
- SC1087: Use braces when expanding arrays
- SC1091: Not following
- SC2004: `$`/`${}` is unnecessary on arithmetic variables
- SC2024: `sudo` doesn't affect redirects
- SC2034: foo appears unused. Verify it or export it
- SC2086: Double quote to prevent globbing and word splitting
- SC2087: Quote `EOF`
- SC2115: Use `"${var:?}"` to ensure this never expands to `/*`
- SC2148: Add a shebang
Addresses (at least partially) some POSIX/dash issues:
- SC2113: `function` keyword is non-standard
- SC3010: In POSIX sh, `[[` `]]` is undefined
- SC3014: In POSIX sh, `==` in place of `=` is undefined
- SC3020: In POSIX sh, `&>` is undefined
- SC3046: In POSIX sh, `source` in place of `.` is undefined
Does not address:
- SC2162: `read` without `-r` will mangle backslashes
- Any other POSIX/dash-specific issues
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Specify dependencies specifically for building coreboot toolchains in
the file, so they are not conflated with the dependencies required for
building firmware-open.
Remove building the toolchain when building firmware, so that the new
script is the single source for building coreboot toolchains.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Allow overriding the coreboot toolchain location with `XGCCPATH` so
that xgcc can be installed to a separate location, such as `/opt`.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Building EC was broken as the build output from the previous board was
not being cleaned. `BUILD` is now always set, defaulting to "build",
instead of only when `BOARD` is specified. For good measure, add it
to the clean command in case a custom path is used.
Fixes: 569321f9ac79 ("scripts: Set EC build dir")
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Specify the EC build directory so that it does not require the model or
version to be determined in the script.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Rebase on coreboot/coreboot@decbf7b4d9.
The following boards have been upstreamed:
- darp8
- galp6
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Set options in edk2.config for each board.
PCIE_BASE is no longer an edk2 option. The value is expected to be in
AcpiBoardInfo HOB, generated from the bootloader's ACPI table.
Signed-off-by: Tim Crawford <tcrawford@system76.com>
If a board in models/ does not exist in coreboot, coreboot will emit a
warning and select the first available board for the vendor instead.
This may result in building and being able to flash coreboot with an
addw1 configuration on another board.
If a board in models/ does not exist in coreboot, coreboot will emit a
warning and select the first available board for the vendor instead.
This may result in building and being able to flash coreboot with an
addw1 configuration on another board.
Use minimal set of config selections and let coreboot generate the
default values for the rest of them.
The only differences are the following models selecting
CONFIG_CPU_MICROCODE_CBFS_DEFAULT_BINS instead of *_EXTERNAL_BINS:
- darp5
- darp6
- galp3-c
- galp4
- lemp9
* Add script for updating coreboot config
* Update coreboot and coreboot config
* Update coreboot and configs
* Pass board and version when running make clean in ec
* Add addw2 chip.txt
* Update coreboot
* Update coreboot
