ec/acpi/ec: replace misleading "recv_ec_data_timeout" console output

In the non-timeout case in recv_ec_data_timeout, a message like this one
will get printed at BIOS_SPEW log level: "recv_ec_data_timeout: 0x00".
The "timeout" part of the function name corresponds to what the function
does, but the message will only be printed when not running into the
timeout which is a bit misleading and might suggest a problem when there
is none. To avoid this possible confusion, don't use the function name
in the printk, but use "Data from EC:" instead.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I521f67517f64fc64e24853d96730c3f9459f1ccc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74381
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Felix Held
2023-04-13 20:06:22 +02:00
parent e39a3e3920
commit 0854f67cae

View File

@@ -88,7 +88,7 @@ int recv_ec_data_timeout(int timeout_us)
}
data = inb(ec_data_reg);
printk(BIOS_SPEW, "%s: 0x%02x\n", __func__, data);
printk(BIOS_SPEW, "Data from EC: 0x%02x\n", data);
return data;
}