skl mainboards/dt: Drop SsicPortEnable setting if disabled
The attributes are initialized with 0 and thus setting them to 0 makes them superfluous. Remove them. Change-Id: Ic16d568c38d708da27efa7229e23019e71c0019b Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83173 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marvin Evers <marvin.n.evers@gmail.com> Reviewed-by: Erik van den Bogaert <ebogaert@eltan.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
@@ -44,7 +44,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsDevSlp[2]" = "1"
|
||||
register "DspEnable" = "0"
|
||||
register "IoBufferOwnership" = "0"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "0"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -41,7 +41,6 @@ chip soc/intel/skylake
|
||||
device ref igpu on end
|
||||
device ref sa_thermal on end
|
||||
device ref south_xhci on
|
||||
register "SsicPortEnable" = "0"
|
||||
# USB2
|
||||
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A, right
|
||||
register "usb2_ports[1]" = "USB2_PORT_FLEX(OC_SKIP)" # 3G / LTE
|
||||
|
@@ -197,8 +197,6 @@ chip soc/intel/skylake
|
||||
[3] = USB3_PORT_DEFAULT(OC_SKIP), /* USB-C Port 1 */
|
||||
}"
|
||||
|
||||
register "SsicPortEnable" = "0"
|
||||
|
||||
# Must leave UART0 enabled or SD/eMMC will not work as PCI
|
||||
register "SerialIoDevMode" = "{
|
||||
[PchSerialIoIndexI2C0] = PchSerialIoDisabled,
|
||||
|
@@ -40,7 +40,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -71,7 +71,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsDevSlp[1]" = "1"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "0"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -39,7 +39,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -47,7 +47,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -35,7 +35,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -43,7 +43,6 @@ chip soc/intel/skylake
|
||||
register "SataSalpSupport" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -44,7 +44,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -40,7 +40,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -47,7 +47,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -44,7 +44,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsEnable[0]" = "0"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "3"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "1"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -47,7 +47,6 @@ chip soc/intel/skylake
|
||||
register "SataSpeedLimit" = "2"
|
||||
register "DspEnable" = "1"
|
||||
register "IoBufferOwnership" = "0"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "0"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -31,7 +31,6 @@ chip soc/intel/skylake
|
||||
register "SataSalpSupport" = "0"
|
||||
register "DspEnable" = "0"
|
||||
register "IoBufferOwnership" = "0"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "0"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -49,7 +49,6 @@ chip soc/intel/skylake
|
||||
register "SataPortsDevSlp[2]" = "0"
|
||||
register "DspEnable" = "0"
|
||||
register "IoBufferOwnership" = "0"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "0"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
@@ -30,7 +30,6 @@ chip soc/intel/skylake
|
||||
}"
|
||||
register "DspEnable" = "0"
|
||||
register "IoBufferOwnership" = "0"
|
||||
register "SsicPortEnable" = "0"
|
||||
register "ScsEmmcHs400Enabled" = "0"
|
||||
register "SkipExtGfxScan" = "1"
|
||||
register "SaGv" = "SaGv_Enabled"
|
||||
|
Reference in New Issue
Block a user