mb/system76: Enable SrcClk pin for CPU PCIe RPs
This reverts commit bd9b044a96
("mb/system76: rtd3: Remove SrcClk pin
on CPU RP").
Previously, RTD3 expected a PCH index for the root port and did not work
with the CPU PCIe RP present on TGL, so SrcClk pin was disabled.
Set them now that RTD3 supports mapping the index for the CPU RP.
Change-Id: Ia7519b9f5a2be52cd5575615c28d20371a26996b
Signed-off-by: Tim Crawford <tcrawford@system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60914
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Jeremy Soller <jeremy@system76.com>
This commit is contained in:
@ -113,8 +113,7 @@ chip soc/intel/tigerlake
|
|||||||
chip soc/intel/common/block/pcie/rtd3
|
chip soc/intel/common/block/pcie/rtd3
|
||||||
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B16)" # SSD1_PWR_EN
|
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B16)" # SSD1_PWR_EN
|
||||||
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D13)" # GPP_D13_SSD1_PLT_RST#
|
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D13)" # GPP_D13_SSD1_PLT_RST#
|
||||||
# TODO: Support disable/enable CPU RP clock
|
register "srcclk_pin" = "0" # SSD1_CLKREQ#
|
||||||
register "srcclk_pin" = "-1" # SSD1_CLKREQ#
|
|
||||||
device generic 0 on end
|
device generic 0 on end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -113,8 +113,7 @@ chip soc/intel/tigerlake
|
|||||||
chip soc/intel/common/block/pcie/rtd3
|
chip soc/intel/common/block/pcie/rtd3
|
||||||
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D14)" # SSD1_PWR_DN#
|
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D14)" # SSD1_PWR_DN#
|
||||||
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0)" # GPP_H0_RTD3
|
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0)" # GPP_H0_RTD3
|
||||||
# TODO: Support disable/enable CPU RP clock
|
register "srcclk_pin" = "0" # SSD1_CLKREQ#
|
||||||
register "srcclk_pin" = "-1" # SSD1_CLKREQ#
|
|
||||||
device generic 0 on end
|
device generic 0 on end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -13,8 +13,7 @@ chip soc/intel/tigerlake
|
|||||||
register "enable_off_delay_ms" = "4"
|
register "enable_off_delay_ms" = "4"
|
||||||
register "reset_delay_ms" = "10"
|
register "reset_delay_ms" = "10"
|
||||||
register "reset_off_delay_ms" = "4"
|
register "reset_off_delay_ms" = "4"
|
||||||
# TODO: Support disable/enable CPU RP clock
|
register "srcclk_pin" = "0" # GFX_CLKREQ0#
|
||||||
register "srcclk_pin" = "-1" # GFX_CLKREQ0#
|
|
||||||
device generic 0 on end
|
device generic 0 on end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -13,8 +13,7 @@ chip soc/intel/tigerlake
|
|||||||
register "enable_off_delay_ms" = "4"
|
register "enable_off_delay_ms" = "4"
|
||||||
register "reset_delay_ms" = "10"
|
register "reset_delay_ms" = "10"
|
||||||
register "reset_off_delay_ms" = "4"
|
register "reset_off_delay_ms" = "4"
|
||||||
# TODO: Support disable/enable CPU RP clock
|
register "srcclk_pin" = "9" # PEG_CLKREQ#
|
||||||
register "srcclk_pin" = "-1" # PEG_CLKREQ#
|
|
||||||
device generic 0 on end
|
device generic 0 on end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -114,8 +114,7 @@ chip soc/intel/tigerlake
|
|||||||
chip soc/intel/common/block/pcie/rtd3
|
chip soc/intel/common/block/pcie/rtd3
|
||||||
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C13)" # SSD1_PWR_DN#
|
register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C13)" # SSD1_PWR_DN#
|
||||||
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C22)" # GPP_C12_RTD3 (labeled incorrectly)
|
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C22)" # GPP_C12_RTD3 (labeled incorrectly)
|
||||||
# TODO: Support disable/enable CPU RP clock
|
register "srcclk_pin" = "3" # SSD2_CLKREQ#
|
||||||
register "srcclk_pin" = "-1" # SSD2_CLKREQ#
|
|
||||||
device generic 0 on end
|
device generic 0 on end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
@ -99,8 +99,7 @@ chip soc/intel/tigerlake
|
|||||||
register "enable_off_delay_ms" = "4"
|
register "enable_off_delay_ms" = "4"
|
||||||
register "reset_delay_ms" = "10"
|
register "reset_delay_ms" = "10"
|
||||||
register "reset_off_delay_ms" = "4"
|
register "reset_off_delay_ms" = "4"
|
||||||
# TODO: Support disable/enable CPU RP clock
|
register "srcclk_pin" = "9" # PEG_CLKREQ#
|
||||||
register "srcclk_pin" = "-1" # PEG_CLKREQ#
|
|
||||||
device generic 0 on end
|
device generic 0 on end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
Reference in New Issue
Block a user