sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/intel/kblrvp: Make use of chipset devicetree

Browse Source 
Use the references from the chipset devicetree as this makes the
comments superfluous and remove devices which are turned off.

Built all variants with BUILD_TIMELESS=1 and the resulting binaries
remain the same.

Change-Id: I1fd5f2a1c8adb5f379d7f3d0b54dca9c3ee6e2b3
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Signed-off-by: Marvin Evers <marvin.evers@stud.hs-bochum.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79325
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Felix Singer
2023-11-16 01:17:31 +01:00
committed by Felix Singer
parent 6b02a20f17
commit 2dff4f0688
5 changed files with 59 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb
View File

@@ -111,50 +111,23 @@ chip soc/intel/skylake
device cpu_cluster 0 on end device cpu_cluster 0 on end
device domain 0 on device domain 0 on
device pci 00.0 on end # Host Bridge device ref igpu on end
device pci 02.0 on end # Integrated Graphics Device device ref sa_thermal on end
device pci 04.0 on end # SA thermal subsystem device ref south_xhci on end
device pci 14.0 on end # USB xHCI device ref thermal on end
device pci 14.1 off end # USB xDCI (OTG) device ref i2c0 on end
device pci 14.2 on end # Thermal Subsystem device ref i2c1 on end
device pci 15.0 on end # I2C #0 device ref i2c2 on end
device pci 15.1 on end # I2C #1 device ref i2c3 on end
device pci 15.2 on end # I2C #2 device ref heci1 on end
device pci 15.3 on end # I2C #3 device ref uart2 on end
device pci 16.0 on end # Management Engine Interface 1 device ref i2c4 on end
device pci 16.1 off end # Management Engine Interface 2 device ref pcie_rp1 on end
device pci 16.2 off end # Management Engine IDE-R device ref pcie_rp9 on end
device pci 16.3 off end # Management Engine KT Redirection device ref uart0 on end
device pci 16.4 off end # Management Engine Interface 3 device ref emmc on end
device pci 17.0 off end # SATA device ref sdxc on end
device pci 19.0 on end # UART #2 device ref smbus on end
device pci 19.1 off end # I2C #5 device ref fast_spi on end
device pci 19.2 on end # I2C #4
device pci 1c.0 on end # PCI Express Port 1
device pci 1c.1 off end # PCI Express Port 2
device pci 1c.2 off end # PCI Express Port 3
device pci 1c.3 off end # PCI Express Port 4
device pci 1c.4 off end # PCI Express Port 5
device pci 1c.5 off end # PCI Express Port 6
device pci 1c.6 off end # PCI Express Port 7
device pci 1c.7 off end # PCI Express Port 8
device pci 1d.0 on end # PCI Express Port 9
device pci 1d.1 off end # PCI Express Port 10
device pci 1d.2 off end # PCI Express Port 11
device pci 1d.3 off end # PCI Express Port 12
device pci 1e.0 on end # UART #0
device pci 1e.1 off end # UART #1
device pci 1e.2 off end # GSPI #0
device pci 1e.3 off end # GSPI #1
device pci 1e.4 on end # eMMC
device pci 1e.5 off end # SDIO
device pci 1e.6 on end # SDCard
device pci 1f.0 on end # LPC Interface
device pci 1f.1 on end # P2SB
device pci 1f.2 on end # Power Management Controller
device pci 1f.3 off end # Intel HDA
device pci 1f.4 on end # SMBus
device pci 1f.5 on end # PCH SPI
device pci 1f.6 off end # GbE
end end
end end

18
src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb
View File

@@ -107,14 +107,14 @@ chip soc/intel/skylake
}" }"
device domain 0 on device domain 0 on
device pci 04.0 off end # SA thermal subsystem device ref sa_thermal off end
device pci 15.2 off end # I2C #2 device ref i2c2 off end
device pci 15.3 off end # I2C #3 device ref i2c3 off end
device pci 17.0 on end # SATA device ref sata on end
device pci 19.2 off end # I2C #4 device ref i2c4 off end
device pci 1e.4 off end # eMMC device ref emmc off end
device pci 1e.6 off end # SDCard device ref sdxc off end
device pci 1f.3 on end # Intel HDA device ref hda on end
device pci 1f.6 on end # GbE device ref gbe on end
end end
end end

20
src/mainboard/intel/kblrvp/variants/rvp3/overridetree.cb
View File

@@ -113,18 +113,18 @@ chip soc/intel/skylake
}" }"
device domain 0 on device domain 0 on
device pci 05.0 on end # SA IMGU device ref imgu on end
device pci 14.3 on end # Camera device ref cio on end
device pci 1c.0 on end # PCI Express Port 1 x4 SLOT1 device ref pcie_rp1 on end # x4 SLOT1
device pci 1c.4 on end # PCI Express Port 5 x1 SLOT2/LAN device ref pcie_rp5 on end # x1 SLOT2/LAN
device pci 1c.5 on end # PCI Express Port 6 x1 SLOT3 device ref pcie_rp6 on end # x1 SLOT3
device pci 1d.0 on end # PCI Express Port 9 x1 WLAN device ref pcie_rp9 on end # x1 WLAN
device pci 1d.1 on end # PCI Express Port 10 x1 WIGIG device ref pcie_rp10 on end # x1 WIGIG
device pci 1f.0 on device ref lpc_espi on
chip drivers/pc80/tpm chip drivers/pc80/tpm
device pnp 0c31.0 on end device pnp 0c31.0 on end
end end
end # LPC Interface end
device pci 1f.3 on end # Intel HDA device ref hda on end
end end
end end

18
src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb
View File

@@ -155,17 +155,17 @@ chip soc/intel/skylake
device cpu_cluster 0 on end device cpu_cluster 0 on end
device domain 0 on device domain 0 on
device pci 15.2 off end # I2C #2 device ref i2c2 off end
device pci 15.3 off end # I2C #3 device ref i2c3 off end
device pci 17.0 on end # SATA device ref sata on end
device pci 1c.2 on end # PCI Express Port 3 device ref pcie_rp3 on end
device pci 1c.3 on end # PCI Express Port 4 device ref pcie_rp4 on end
device pci 1c.4 on end # PCI Express Port 5 device ref pcie_rp5 on end
device pci 1c.5 on end # PCI Express Port 6 device ref pcie_rp6 on end
device pci 1f.0 on device ref lpc_espi on
chip drivers/pc80/tpm chip drivers/pc80/tpm
device pnp 0c31.0 on end device pnp 0c31.0 on end
end end
end # LPC Interface end
end end
end end

26
src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb
View File

@@ -160,21 +160,21 @@ chip soc/intel/skylake
}" }"
device domain 0 on device domain 0 on
device pci 15.2 off end # I2C #2 device ref i2c2 off end
device pci 15.3 off end # I2C #3 device ref i2c3 off end
device pci 17.0 on end # SATA device ref sata on end
device pci 19.2 off end # I2C #4 device ref i2c4 off end
device pci 1c.0 off end # PCI Express Port 1 device ref pcie_rp1 off end
device pci 1c.2 on end # PCI Express Port 3 device ref pcie_rp3 on end
device pci 1c.3 on end # PCI Express Port 4 device ref pcie_rp4 on end
device pci 1c.4 on end # PCI Express Port 5 device ref pcie_rp5 on end
device pci 1e.4 off end # eMMC device ref emmc off end
device pci 1e.6 off end # SDXC device ref sdxc off end
device pci 1f.0 on device ref lpc_espi on
#chip drivers/pc80/tpm #chip drivers/pc80/tpm
# device pnp 0c31.0 on end # device pnp 0c31.0 on end
#end #end
end # LPC Interface end
device pci 1f.6 on end # GbE device ref gbe on end
end end
end end