sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/supermicro/x11-lga1151-series: Fix CMOS options

Browse Source 
The `hyper_threading` CMOS option was hooked up to the wrong enumeration
and lacked a default value in `cmos.default`. Thus, use the correct enum
for the `hyper_threading` option, remove the now-unused "backwards" enum
and provide a default value in `cmos.default`.

Change-Id: I2ee9ced2881ed5e348e84a35e8abd6b7a363d936
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69491
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2022-11-12 22:26:13 +01:00 committed by Felix Held
parent 8e679f72e9
commit 2e9849aa02
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/supermicro/x11-lga1151-series/cmos.default
View File

@ -1,3 +1,4 @@
boot_option=Fallback boot_option=Fallback
debug_level=Debug debug_level=Debug
hyper_threading=Enable
power_on_after_fail=Enable power_on_after_fail=Enable

4
src/mainboard/supermicro/x11-lga1151-series/cmos.layout
View File

@ -17,7 +17,7 @@ entries
# ----------------------------------------------------------------- # -----------------------------------------------------------------
# coreboot config options: cpu # coreboot config options: cpu
400 1 e 2 hyper_threading 400 1 e 1 hyper_threading
# ----------------------------------------------------------------- # -----------------------------------------------------------------
# coreboot config options: southbridge # coreboot config options: southbridge
@ -38,8 +38,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency