sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/intel/model_206ax: Allow package power limit clamping

Browse Source 
Setting the clamp bit allows the CPU to operate below the highest
non-turbo frequency in order to obey the power limit.

Tested on ThinkPad T420 with the i7-3940XM.

Change-Id: Id0c0aedc29aca121d0fd1d8f8826089e13a026be
Signed-off-by: Anastasios Koutian <akoutian2@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83270
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Anastasios Koutian
2024-06-29 09:12:08 +01:00
committed by Nico Huber
parent a5705f701d
commit 3dbf0c5c5f
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/cpu/intel/model_206ax/chip.h
View File

@@ -3,6 +3,8 @@
#ifndef __CPU_INTEL_MODEL_206AX_CHIP_H__
#define __CPU_INTEL_MODEL_206AX_CHIP_H__
#include "stdbool.h"
/* Keep this in sync with acpi.c */
enum cpu_acpi_level {
CPU_ACPI_DISABLED = 0,
@@ -44,7 +46,9 @@ struct cpu_intel_model_206ax_config {
int tcc_offset; /* TCC Activation Offset */
unsigned int pl1_mw; /* Long-term power limit in milliwatts */
bool pl1_clamp; /* Long-term power limit clamping limitation */
unsigned int pl2_mw; /* Short-term power limit in milliwatts */
bool pl2_clamp; /* Short-term power limit clamping limitation */
int pp0_current_limit; /* Primary Plane Current Limit (Icc) in Amps */
int pp1_current_limit; /* Secondary Plane Current Limit (IAXG) in Amps */

8
src/cpu/intel/model_206ax/model_206ax_init.c
View File

@@ -141,6 +141,10 @@ void set_power_limits(u8 power_limit_1_time)
/* Set long term power limit to TDP */
limit.lo |= tdp & PKG_POWER_LIMIT_MASK;
}
if (conf->pl2_clamp) {
printk(BIOS_DEBUG, "Enabling PL1 clamping limitation\n");
limit.lo |= PKG_POWER_LIMIT_CLAMP;
}
limit.lo |= PKG_POWER_LIMIT_EN;
limit.lo |= (power_limit_1_val & PKG_POWER_LIMIT_TIME_MASK) <<
PKG_POWER_LIMIT_TIME_SHIFT;
@@ -153,6 +157,10 @@ void set_power_limits(u8 power_limit_1_time)
/* Set short term power limit to 1.25 * TDP */
limit.hi |= ((tdp * 125) / 100) & PKG_POWER_LIMIT_MASK;
}
if (conf->pl2_clamp) {
printk(BIOS_DEBUG, "Enabling PL2 clamping limitation\n");
limit.hi |= PKG_POWER_LIMIT_CLAMP;
}
limit.hi |= PKG_POWER_LIMIT_EN;
/* Power limit 2 time is only programmable on SNB EP/EX */