soc/intel/common/lpc: Skip setting resources for disabled devices
If a downstream LPC device (eg, SIO function) is disabled, we shouldn't attempt to open PMIO windows for it, as those functions often have unset IO bases (which default to 0), resulting in false errors like: [ERROR] LPC IO decode base 0! TEST=build/boot purism/librem_cnl (Mini v2), verify no LPC IO errors in cbmem log for disabled SIO functions. Change-Id: I92c79fc01be21466976f3056242f6d1824878eab Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80646 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Subrata Banik <subratabanik@google.com> Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
parent
b6d16fb3fa
commit
4f1ba69b3c
@ -87,6 +87,9 @@ static void pch_lpc_loop_resources(struct device *dev)
|
||||
{
|
||||
struct resource *res;
|
||||
|
||||
if (!dev->enabled)
|
||||
return;
|
||||
|
||||
for (res = dev->resource_list; res; res = res->next) {
|
||||
if (res->flags & IORESOURCE_IO)
|
||||
lpc_open_pmio_window(res->base, res->size);
|
||||
|
Loading…
x
Reference in New Issue
Block a user