sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison

Browse Source 
Clang warns about unsigned comparison below 0. Use the enum value itself
to fix this warning.

Change-Id: I12fccff2fb7d43fd4582afd518a7eab632908a5f
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74553
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
This commit is contained in:
Arthur Heymans 2023-04-19 10:14:25 +02:00 committed by Lean Sheng Tan
parent bd429063d9
commit 4ffce7e8ac
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/mediatek/mt8195/apusys_devapc.c
View File

@ -151,7 +151,7 @@ static int set_slave_noc_dapc(u32 slave, enum domain_id domain_id, enum devapc_p
u32 apc_set_index;
u32 *base;
if (perm >= PERM_NUM || perm < 0) {
if (perm >= PERM_NUM || perm < NO_PROTECTION) {
printk(BIOS_ERR, "[NOC_DAPC] permission type:%#x is not supported!\n", perm);
return APUSYS_APC_ERR_PERMISSION_NOT_SUPPORTED;
}
@ -192,7 +192,7 @@ static int set_slave_apc(u32 slave, enum domain_id domain_id, enum devapc_perm_t
u32 apc_set_index;
u32 *base;
if (perm >= PERM_NUM || perm < 0) {
if (perm >= PERM_NUM || perm < NO_PROTECTION) {
printk(BIOS_ERR, "[APUAPC] perm type:%#x is not supported!\n", perm);
return APUSYS_APC_ERR_PERMISSION_NOT_SUPPORTED;
}