sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/acpi: Add SUPERIO_PNP_NO_DIS to support always active LDNs

Browse Source 
Some LDNs do not implement the activate bit at all, e.g. ITE GPIO LDNs
are an example where the LDN is always active. The pnp_generic.asl can
be used to describe the GPIO LDN resources configured by the platform,
however the register 0x30 is always 0 for these LDNs, so OS will not
claim the reported resource for the GPIO device, because _STA will
return inactive LDN.

Add SUPERIO_PNP_NO_DIS macro to generate _STA method returning an
always active LDN and skip _DIS generation. Define the SUPERIO_PNP_NO_DIS
for SIOs which use the pnp_generic.asl preserving the previous states,
except the ITE GPIO LDNs.

Change-Id: Ieb827fdffe7660b875cba6ca99b0560b4cab66b4
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80496
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Michał Żygowski 2024-02-14 12:30:32 +01:00 committed by Felix Held
parent 53f26e400d
commit 5ad8a5fa47
7 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/superio/acpi/pnp_generic.asl
View File

@ -13,6 +13,7 @@
* chip for this device (required)
* SUPERIO_PNP_DDN A string literal that identifies the dos device
* name (DDN) of this device (e.g. "COM1", optional)
* SUPERIO_PNP_NO_DIS If defined, the PNP device has no Enable/Disable methods
* SUPERIO_PNP_PM_REG Identifier of a 1-bit register to power down
* the logical device (optional)
* SUPERIO_PNP_PM_VAL The value for SUPERIO_PNP_PM_REG to power the logical
@ -54,6 +55,13 @@ Device (SUPERIO_ID(PN, SUPERIO_PNP_LDN)) {
Name (_DDN, SUPERIO_PNP_DDN)
#endif
#ifdef SUPERIO_PNP_NO_DIS
Method (_STA)
{
Return (DEVICE_PRESENT_ACTIVE)
}
#else
Method (_STA)
{
PNP_GENERIC_STA(SUPERIO_PNP_LDN)
@ -63,6 +71,7 @@ Device (SUPERIO_ID(PN, SUPERIO_PNP_LDN)) {
{
PNP_GENERIC_DIS(SUPERIO_PNP_LDN)
}
#endif
#ifdef SUPERIO_PNP_PM_REG
Method (_PSC) {

4
src/superio/ite/it8720f/acpi/superio.asl
View File

@ -127,6 +127,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN
@ -158,6 +159,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN
@ -167,6 +169,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_IRQ0
#undef SUPERIO_PNP_IRQ1
#undef SUPERIO_PNP_DMA
#define SUPERIO_PNP_NO_DIS
#define SUPERIO_PNP_LDN 7
#define SUPERIO_PNP_IO0 0x08, 0x08
#define SUPERIO_PNP_IO1 0x08, 0x08
@ -178,6 +181,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN

1
src/superio/ite/it8721f/acpi/superio.asl
View File

@ -127,6 +127,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN

1
src/superio/ite/it8784e/acpi/superio.asl
View File

@ -122,6 +122,7 @@ Device (SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN

2
src/superio/nuvoton/nct6687d/acpi/superio.asl
View File

@ -102,6 +102,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN
@ -157,6 +158,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN

3
src/superio/nuvoton/nct6776/acpi/superio.asl
View File

@ -100,6 +100,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN
@ -145,6 +146,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN
@ -165,6 +167,7 @@ Device(SUPERIO_DEV) {
#undef SUPERIO_PNP_HID
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN

1
src/superio/winbond/w83627dhg/acpi/superio.asl
View File

@ -192,6 +192,7 @@ Device(SUPERIO_DEV) {
#ifdef W83627DHG_SHOW_HWMON
#undef SUPERIO_PNP_LDN
#undef SUPERIO_PNP_DDN
#undef SUPERIO_PNP_NO_DIS
#undef SUPERIO_PNP_PM_REG
#undef SUPERIO_PNP_PM_VAL
#undef SUPERIO_PNP_PM_LDN