whl-u: Sync with cml-u

src/mainboard/system76/cml-u/acpi/mainboard.asl

@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
 
 #if defined(CONFIG_BOARD_SYSTEM76_DARP6)
 	#define COLOR_KEYBOARD 1
@@ -6,7 +7,6 @@
 #else
 	#error Unknown Mainboard
 #endif
-/* SPDX-License-Identifier: GPL-2.0-only */
 
 Scope (\_SB) {
 	#include "ac.asl"

src/mainboard/system76/whl-u/Kconfig

@@ -2,8 +2,8 @@ if BOARD_SYSTEM76_GALP3_C || BOARD_SYSTEM76_DARP5
 
 config BOARD_SPECIFIC_OPTIONS
 	def_bool y
-	select ADD_FSP_BINARIES
 	select BOARD_ROMSIZE_KB_16384
+	select DRIVERS_I2C_HID
 	select EC_ACPI
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
@@ -22,7 +22,6 @@ config BOARD_SPECIFIC_OPTIONS
 	select SOC_INTEL_WHISKEYLAKE
 	select SPD_READ_BY_WORD
 	select SYSTEM_TYPE_LAPTOP
-	select USE_BLOBS
 	select USE_OPTION_TABLE
 	select USE_LEGACY_8254_TIMER # Fix failure to boot GRUB
 

src/mainboard/system76/whl-u/acpi/ac.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 Device (AC)
 {

src/mainboard/system76/whl-u/acpi/battery.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 Device (BAT0)
 {

src/mainboard/system76/whl-u/acpi/buttons.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 Device (PWRB)
 {

src/mainboard/system76/whl-u/acpi/ec.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 Device (EC0)
 {
@@ -129,13 +116,17 @@ Device (EC0)
 	Method (_Q11, 0, NotSerialized) // Brightness Down
 	{
 		Debug = "EC: Brightness Down"
-		^^^^HIDD.HPEM (20)
+		if (^^^^HIDD.HRDY) {
+			^^^^HIDD.HPEM (20)
+		}
 	}
 
 	Method (_Q12, 0, NotSerialized) // Brightness Up
 	{
 		Debug = "EC: Brightness Up"
-		^^^^HIDD.HPEM (19)
+		if (^^^^HIDD.HRDY) {
+			^^^^HIDD.HPEM (19)
+		}
 	}
 
 	Method (_Q13, 0, NotSerialized) // Camera Toggle
@@ -146,10 +137,10 @@ Device (EC0)
 	Method (_Q14, 0, NotSerialized) // Airplane Mode
 	{
 		Debug = "EC: Airplane Mode"
-		// Only send HIDD message when hardware airplane mode not in use
+		if (^^^^HIDD.HRDY) {
-		If (ECOS == 2) {
 			^^^^HIDD.HPEM (8)
 		}
+		// TODO: hardware airplane mode
 	}
 
 	Method (_Q15, 0, NotSerialized) // Suspend Button

src/mainboard/system76/whl-u/acpi/ec_ram.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 OperationRegion (ERAM, EmbeddedControl, Zero, 0xFF)
 Field (ERAM, ByteAcc, Lock, Preserve)

src/mainboard/system76/whl-u/acpi/gpe.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 // GPP_D9 SCI
 Method (_L29, 0, Serialized) {

src/mainboard/system76/whl-u/acpi/hid.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 Device (HIDD)
 {

src/mainboard/system76/whl-u/acpi/lid.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 Device (LID0)
 {

src/mainboard/system76/whl-u/acpi/mainboard.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 #if defined(CONFIG_BOARD_SYSTEM76_DARP5)
 	#define COLOR_KEYBOARD 1

src/mainboard/system76/whl-u/acpi/s76.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 // Notifications:
 //   0x80 - hardware backlight toggle

src/mainboard/system76/whl-u/acpi/sleep.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 /* Method called from _PTS prior to enter sleep state */
 Method (MPTS, 1) {

src/mainboard/system76/whl-u/acpi/tbt.asl

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 // See https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports
 Scope(\_SB.PCI0.RP05) {

src/mainboard/system76/whl-u/bootblock.c

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 #include <bootblock_common.h>
 #include <gpio.h>

src/mainboard/system76/whl-u/devicetree.cb

@@ -2,14 +2,19 @@ chip soc/intel/cannonlake
 	# Lock Down
 	register "common_soc_config" = "{
 		.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 80,
+			.fall_time_ns = 110,
+		},
 	}"
 
 	# Send an extra VR mailbox command for the PS4 exit issue
 	register "SendVrMbxCmd" = "2"
 
 # ACPI (soc/intel/cannonlake/acpi.c)
-	# Disable s0ix
+	# Enable s0ix
-	register "s0ix_enable" = "0"
+	register "s0ix_enable" = "1"
 
 	# PM Timer Enabled
 	register "PmTimerDisabled" = "0"
@@ -19,8 +24,10 @@ chip soc/intel/cannonlake
 
 # CPU (soc/intel/cannonlake/cpu.c)
 	# Power limit
-	register "tdp_pl1_override" = "15"
+	register "power_limits_config" = "{
-	register "tdp_pl2_override" = "25"
+		.tdp_pl1_override = 20,
+		.tdp_pl2_override = 30,
+	}"
 
 	# Enable "Intel Speed Shift Technology"
 	register "speed_shift_enable" = "1"
@@ -30,9 +37,25 @@ chip soc/intel/cannonlake
 
 # FSP Memory (soc/intel/cannonlake/romstage/fsp_params.c)
 	register "SaGv" = "SaGv_Enabled"
-	#register "enable_c6dram" = "1"
+	register "enable_c6dram" = "1"
 
 # FSP Silicon (soc/intel/cannonlake/fsp_params.c)
+	# Serial I/O
+	register "SerialIoDevMode" = "{
+		[PchSerialIoIndexI2C0] = PchSerialIoPci,
+		[PchSerialIoIndexI2C1] = PchSerialIoDisabled,
+		[PchSerialIoIndexI2C2] = PchSerialIoDisabled,
+		[PchSerialIoIndexI2C3] = PchSerialIoDisabled,
+		[PchSerialIoIndexI2C4] = PchSerialIoDisabled,
+		[PchSerialIoIndexI2C5] = PchSerialIoDisabled,
+		[PchSerialIoIndexSPI0] = PchSerialIoDisabled,
+		[PchSerialIoIndexSPI1] = PchSerialIoDisabled,
+		[PchSerialIoIndexSPI2] = PchSerialIoDisabled,
+		[PchSerialIoIndexUART0] = PchSerialIoDisabled,
+		[PchSerialIoIndexUART1] = PchSerialIoDisabled,
+		[PchSerialIoIndexUART2] = PchSerialIoPci,
+	}"
+
 	# SATA
 	register "SataMode" = "Sata_AHCI"
 	register "SataSalpSupport" = "0"
@@ -127,7 +150,7 @@ chip soc/intel/cannonlake
 	register "PcieClkSrcClkReq[5]" = "5"
 
 	# Misc
-	register "Device4Enable" = "0"
+	register "Device4Enable" = "1"
 	register "HeciEnabled" = "0"
 	register "Heci3Enabled" = "0"
 	register "AcousticNoiseMitigation" = "1"
@@ -183,7 +206,7 @@ chip soc/intel/cannonlake
 	device domain 0 on
 		device pci 00.0 on  end # Host Bridge
 		device pci 02.0 on  end # Integrated Graphics Device
-		device pci 04.0 off end # SA Thermal device
+		device pci 04.0 on  end # SA Thermal device
 		device pci 12.0 on  end # Thermal Subsystem
 		device pci 12.5 off end # UFS SCS
 		device pci 12.6 off end # GSPI #2
@@ -195,7 +218,16 @@ chip soc/intel/cannonlake
 			device pci 14.3 on  end # CNVi wifi
 		#end
 		device pci 14.5 off end # SDCard
-		device pci 15.0 off end # I2C #0
+		device pci 15.0 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""PNP0C50""
+				register "generic.desc" = ""Synaptics Touchpad""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)"
+				register "generic.probed" = "1"
+				register "hid_desc_reg_offset" = "0x20"
+				device i2c 2c on end
+			end
+		end # I2C #0
 		device pci 15.1 off end # I2C #1
 		device pci 15.2 off end # I2C #2
 		device pci 15.3 off end # I2C #3

src/mainboard/system76/whl-u/dsdt.asl

@@ -1,19 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- * Copyright (C) 2015 Google Inc.
- * Copyright (C) 2015 Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 #include <acpi/acpi.h>
 DefinitionBlock(

src/mainboard/system76/whl-u/gpio.h

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
- * GNU General Public License for more details.
- */
 
 #ifndef MAINBOARD_GPIO_H
 #define MAINBOARD_GPIO_H
@@ -263,8 +250,8 @@ static const struct pad_config gpio_table[] = {
 		PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1),
 		// NC
 		PAD_CFG_NC(GPP_C22),
-		// NC
+		// TP_ATTN#
-		PAD_CFG_NC(GPP_C23),
+		PAD_CFG_GPI_APIC(GPP_C23, NONE, PLTRST, EDGE_SINGLE, INVERT),
 
 // GPP_D
 	// SPI1

src/mainboard/system76/whl-u/ramstage.c

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 #include <string.h>
 #include <acpi/acpi.h>

src/mainboard/system76/whl-u/romstage.c

@@ -1,17 +1,4 @@
-/*
+/* SPDX-License-Identifier: GPL-2.0-only */
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2019 System76
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
 
 #include <soc/cnl_memcfg_init.h>
 #include <soc/romstage.h>