sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: Add description to HMRFPO status

Browse Source 
Below changes are implemented:
1. Fix typos.
2. Rename 'padding' field of hmrfpo_get_status_resp struct to
   'reserved' to match with ME BWG Guide.
3. Add documentation for HMRFPO Status.

TEST=Build and boot hatch

Change-Id: I4db9bdf7386c48e17ed0373cf334ccff358d1951
Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38480
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Sridhar Siricilla
2020-01-19 12:38:56 +05:30
committed by Patrick Georgi
parent ff072e6ebf
commit 63be9181cb
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/common/block/cse/cse.c
View File

@@ -683,7 +683,7 @@ failed:
/*
* Sends HMRFPO Get Status command to CSE to get the HMRFPO status.
* The status can be DISABLES/LOCKED/ENABLED
* The status can be DISABLED/LOCKED/ENABLED
*/
int cse_hmrfpo_get_status(void)
{
@@ -694,7 +694,7 @@ int cse_hmrfpo_get_status(void)
struct hmrfpo_get_status_resp {
struct mkhi_hdr hdr;
uint8_t status;
uint8_t padding[3];
uint8_t reserved[3];
} __packed;
struct hmrfpo_get_status_msg msg = {

8
src/soc/intel/common/block/include/intelblocks/cse.h
View File

@@ -144,8 +144,16 @@ int cse_hmrfpo_get_status(void);
#define CSE_RESET_ONLY 3
/* HMRFPO Status types */
/* Host can't access ME region */
#define MKHI_HMRFPO_DISABLED 0
/*
* ME Firmware locked down HMRFPO Feature.
* Host can't access ME region.
*/
#define MKHI_HMRFPO_LOCKED 1
/* Host can access ME region */
#define MKHI_HMRFPO_ENABLED 2
/*