sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intelblocks/cpu: Fix wrong comment for P_Req field in PERF_CTL MSR

Browse Source 
The mentioned bits 14:8 are wrong as the functions always write
bits 15:8. What happens is visible in the written code. There is no need
for an extra comment.

Change-Id: I59b4d24d01a0a8fa74912f9754e7bbb217ca269d
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/c/29798
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
This commit is contained in:
Werner Zeh
2018-11-22 15:10:18 +01:00
committed by Patrick Georgi
parent 697faf0d5f
commit 6b522c31aa
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/soc/intel/common/block/cpu/cpulib.c
View File

@@ -34,7 +34,7 @@
#include <stdint.h>
/*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with
* Set PERF_CTL MSR (0x199) P_Req with
* Turbo Ratio which is the Maximum Ratio.
*/
void cpu_set_max_ratio(void)
@@ -86,7 +86,7 @@ int cpu_config_tdp_levels(void)
* 23:16 - MAX_TURBO_3_CORES
* 31:24 - MAX_TURBO_4_CORES
*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value.
* Set PERF_CTL MSR (0x199) P_Req with that value.
*/
void cpu_set_p_state_to_turbo_ratio(void)
{
@@ -106,7 +106,7 @@ void cpu_set_p_state_to_turbo_ratio(void)
* TDP level ratio to be used for specific processor (in units
* of 100MHz).
*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value.
* Set PERF_CTL MSR (0x199) P_Req with that value.
*/
void cpu_set_p_state_to_nominal_tdp_ratio(void)
{
@@ -125,7 +125,7 @@ void cpu_set_p_state_to_nominal_tdp_ratio(void)
* PLATFORM_INFO MSR (0xCE) Bits 15:8 tells
* MAX_NON_TURBO_LIM_RATIO.
*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value.
* Set PERF_CTL MSR (0x199) P_Req with that value.
*/
void cpu_set_p_state_to_max_non_turbo_ratio(void)
{
@@ -142,7 +142,7 @@ void cpu_set_p_state_to_max_non_turbo_ratio(void)
}
/*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with the value
* Set PERF_CTL MSR (0x199) P_Req with the value
* for maximum efficiency. This value is reported in PLATFORM_INFO MSR (0xCE)
* in Bits 47:40 and is extracted with cpu_get_min_ratio().
*/

10
src/soc/intel/common/block/include/intelblocks/cpulib.h
View File

@@ -20,7 +20,7 @@
#include <stdint.h>
/*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with
* Set PERF_CTL MSR (0x199) P_Req with
* Turbo Ratio which is the Maximum Ratio.
*/
void cpu_set_max_ratio(void);
@@ -52,7 +52,7 @@ int cpu_config_tdp_levels(void);
* 23:16 - MAX_TURBO_3_CORES
* 31:24 - MAX_TURBO_4_CORES
*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value.
* Set PERF_CTL MSR (0x199) P_Req with that value.
*/
void cpu_set_p_state_to_turbo_ratio(void);
@@ -61,7 +61,7 @@ void cpu_set_p_state_to_turbo_ratio(void);
* TDP level ratio to be used for specific processor (in units
* of 100MHz).
*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value.
* Set PERF_CTL MSR (0x199) P_Req with that value.
*/
void cpu_set_p_state_to_nominal_tdp_ratio(void);
@@ -69,12 +69,12 @@ void cpu_set_p_state_to_nominal_tdp_ratio(void);
* PLATFORM_INFO MSR (0xCE) Bits 15:8 tells
* MAX_NON_TURBO_LIM_RATIO.
*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value.
* Set PERF_CTL MSR (0x199) P_Req with that value.
*/
void cpu_set_p_state_to_max_non_turbo_ratio(void);
/*
* Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with the value
* Set PERF_CTL MSR (0x199) P_Req with the value
* for maximum efficiency. This value is reported in PLATFORM_INFO MSR (0xCE)
* in Bits 47:40 and is extracted with cpu_get_min_ratio().
*/