sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/x86: Check unsupported CPU type while writing to SMBIOS table 7

Browse Source 
Don't attempt to fill the SMBIOS table if the CPU doesn't support
deterministic cache CPUID.

TEST=Able to fix the hang issue seen on ASRock E350M1 with commit hash
e2b5fee.

Change-Id: Id65dc963e235f7080370a32cf69bcc4bee94d28f
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57306
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik
2021-09-01 12:40:47 +05:30
committed by Tim Wawrzynczak
parent 72f1e62bbb
commit 6efc4aa4af
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/arch/x86/smbios.c
View File

@@ -765,7 +765,8 @@ static int smbios_write_type7_cache_parameters(unsigned long *current,
if (!cpu_have_cpuid())
return len;
if (cpu_check_deterministic_cache_cpuid_supported() == CPUID_TYPE_INVALID) {
enum cpu_type dcache_cpuid = cpu_check_deterministic_cache_cpuid_supported();
if (dcache_cpuid == CPUID_TYPE_INVALID || dcache_cpuid == CPUID_COMMAND_UNSUPPORTED) {
printk(BIOS_DEBUG, "SMBIOS: Unknown CPU\n");
return len;
}