sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/x4x/dq_dqs.c: Avoid breaking strings over multiple lines

Browse Source 
Breaking strings across multiple lines hurts greppability. Refactor the
code a bit to drop one indentation level, and then reflow the strings.

Change-Id: I0accdfd0d2c5f58e4da493ba0d4b5c6a067d92c3
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51876
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons
2021-03-26 23:23:22 +01:00
committed by Nico Huber
parent e82191451c
commit 70dc0a8cc3
1 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/northbridge/intel/x4x/dq_dqs.c
View File

@@ -656,16 +656,13 @@ static enum cb_err increment_to_dqs_edge(struct sysinfo *s, u8 channel, u8 rank)
lane,
dq_sample[lane]);
if (dq_sample[lane] > 0) {
if (decrement_dq_dqs(s, &dqs_setting[lane])) {
printk(BIOS_EMERG,
"DQS setting channel%d, "
"lane %d reached a minimum!\n",
channel, lane);
return CB_ERR;
}
} else {
if (dq_sample[lane] == 0) {
bytelane_ok |= (1 << lane);
} else if (decrement_dq_dqs(s, &dqs_setting[lane])) {
printk(BIOS_EMERG,
"DQS setting channel%d, lane %d reached a minimum!\n",
channel, lane);
return CB_ERR;
}
dqsset(channel, lane, &dqs_setting[lane]);
}
@@ -695,14 +692,11 @@ static enum cb_err increment_to_dqs_edge(struct sysinfo *s, u8 channel, u8 rank)
if (dq_sample[lane] == N_SAMPLES) {
bytelane_ok |= (1 << lane);
} else {
if (increment_dq_dqs(s, &dqs_setting[lane])) {
printk(BIOS_EMERG,
"DQS setting channel%d, "
"lane %d reached a maximum!\n",
channel, lane);
return CB_ERR;
}
} else if (increment_dq_dqs(s, &dqs_setting[lane])) {
printk(BIOS_EMERG,
"DQS setting channel%d, lane %d reached a maximum!\n",
channel, lane);
return CB_ERR;
}
dqsset(channel, lane, &dqs_setting[lane]);
}