sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp: Find VTD devices by PCI DEV ID

Browse Source 
Instead of manually crafting S:B:D:F numbers for every
VTD device loop over the entire devicetree by PCI DEV IDs.

This adds PCI multi-segment support without any further code
modifications, since the correct PCI segment will be stored in the
devicetree.

Change-Id: I1c24d26e105c3dcbd9cca0e7197ab1362344aa96
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80092
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shuo Liu <shuo.liu@intel.com>
This commit is contained in:
Patrick Rudolph
2024-01-16 08:44:25 +01:00
committed by Lean Sheng Tan
parent 15672599e4
commit 8cfb4dc489
1 changed files with 10 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/soc/intel/xeon_sp/memmap.c
View File

@@ -4,6 +4,7 @@
#include <cbmem.h>
#include <console/console.h>
#include <device/pci_ops.h>
#include <device/pci_ids.h>
#include <cpu/x86/smm.h>
#include <soc/soc_util.h>
#include <soc/pci_devs.h>
@@ -53,7 +54,6 @@ void fill_postcar_frame(struct postcar_frame *pcf)
#if !defined(__SIMPLE_DEVICE__)
union dpr_register txt_get_chipset_dpr(void)
{
const IIO_UDS *hob = get_iio_uds();
union dpr_register dpr;
struct device *dev = VTD_DEV(0);
@@ -66,31 +66,15 @@ union dpr_register txt_get_chipset_dpr(void)
dpr.raw = pci_read_config32(dev, VTD_LTDPR);
/* Compare the LTDPR register on all iio stacks */
for (int socket = 0, iio = 0; iio < hob->PlatformData.numofIIO; ++socket) {
if (!soc_cpu_is_enabled(socket))
continue;
iio++;
for (int stack = 0; stack < MAX_IIO_STACK; ++stack) {
const STACK_RES *ri =
&hob->PlatformData.IIO_resource[socket].StackRes[stack];
if (ri->VtdBarAddress == 0)
continue;
uint8_t bus = ri->BusBase;
dev = VTD_DEV(bus);
if (!dev) {
printk(BIOS_ERR, "BUS %x: Unable to find VTD PCI dev\n", bus);
dpr.raw = 0;
return dpr;
}
union dpr_register test_dpr = { .raw = pci_read_config32(dev, VTD_LTDPR) };
if (dpr.raw != test_dpr.raw) {
printk(BIOS_ERR, "LTDPR not the same on all IIO's");
dpr.raw = 0;
return dpr;
}
dev = NULL;
/* Look for VTD devices on all sockets */
while ((dev = dev_find_device(PCI_VID_INTEL, MMAP_VTD_STACK_CFG_REG_DEVID, dev))) {
/* Compare the LTDPR register on all iio stacks */
union dpr_register test_dpr = { .raw = pci_read_config32(dev, VTD_LTDPR) };
if (dpr.raw != test_dpr.raw) {
printk(BIOS_ERR, "LTDPR not the same on all IIO's");
dpr.raw = 0;
return dpr;
}
}
return dpr;