sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/cmn/pmc: Add API to dump silicon QDF information

Browse Source 
This adds pmc_dump_soc_qdf_info function and PMC_IPC_CMD_SOC_REG_ACC
PMC IPC Command to read and print Intel SoC QDF information using PMC
interface if SOC_QDF_DYNAMIC_READ_PMC is enabled. QDF read command is
supported from Panther Lake SoC.

QDF is a four digit code that can be used to identify enabled features
and capabilities. This information will be useful to debug issues
found during the development phase and in the field as well.

Change-Id: I927da1a97e6dad4ee54c4d2256fea5813a0ce43d
Signed-off-by: Jamie Ryu <jamie.m.ryu@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83784
Reviewed-by: Sukumar Ghorai <sukumar.ghorai@intel.com>
Reviewed-by: Wonkyu Kim <wonkyu.kim@intel.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Ronak Kanabar <ronak.kanabar@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jamie Ryu 2024-07-22 14:19:36 -07:00 committed by Subrata Banik
parent 6b8c40a95a
commit 8d19e0faa1
3 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/common/block/include/intelblocks/pmclib.h
View File

@ -268,4 +268,10 @@ uint8_t get_pm_pwr_cyc_dur(uint8_t slp_s4_min_assert, uint8_t slp_s3_min_assert,
/* API to set ACPI mode */
void pmc_set_acpi_mode(void);
/*
* This function reads and prints SoC QDF information using PMC interface
* if SOC_QDF_DYNAMIC_READ_PMC config is enabled.
*/
void pmc_dump_soc_qdf_info(void);
#endif /* SOC_INTEL_COMMON_BLOCK_PMCLIB_H */

8
src/soc/intel/common/block/pmc/Kconfig
View File

@ -82,3 +82,11 @@ config USE_PM_ACPI_TIMER
(Legacy) software requiring `TMR_STS` (for timer overflow
interrupts) will not work with this option disabled.
config SOC_QDF_DYNAMIC_READ_PMC
bool
default n
depends on SOC_INTEL_COMMON_BLOCK_PMC && PMC_IPC_ACPI_INTERFACE
help
Enable this option if the platform supports reading SOC QDF
data dynamically at runtime using the PMC IPC interface.

41
src/soc/intel/common/block/pmc/pmclib.c
View File

@ -26,6 +26,11 @@
#define PMC_IPC_BIOS_RST_SUBID_PCI_ENUM_DONE 0
#define PMC_IPC_BIOS_RST_CMPL_STS_PCI_ENUM BIT(0)
/* IPC command for accessing SoC registers */
#define PMC_IPC_CMD_SOC_REG_ACC 0xAA
#define PMC_IPC_CMD_SUBCMD_SOC_REG_RD 0x00
#define PMC_IPC_CMD_REGID_SOC_QDF 0x03
static struct chipset_power_state power_state;
/* List of Minimum Assertion durations in microseconds */
@ -882,3 +887,39 @@ void pmc_send_bios_reset_pci_enum_done(void)
if (pmc_send_ipc_cmd(cmd, &req, &rsp) != CB_SUCCESS)
printk(BIOS_ERR, "PMC: Failed sending PCI Enumeration Done Command\n");
}
/*
* This function reads and prints SoC QDF information using PMC interface
* if SOC_QDF_DYNAMIC_READ_PMC config is enabled.
*/
void pmc_dump_soc_qdf_info(void)
{
struct pmc_ipc_buffer req = { 0 };
struct pmc_ipc_buffer rsp;
uint32_t cmd_reg;
int r;
char qdf_info[5];
if (!CONFIG(SOC_QDF_DYNAMIC_READ_PMC))
return;
req.buf[0] = PMC_IPC_CMD_REGID_SOC_QDF;
cmd_reg = pmc_make_ipc_cmd(PMC_IPC_CMD_SOC_REG_ACC,
PMC_IPC_CMD_SUBCMD_SOC_REG_RD,
PMC_IPC_BUF_COUNT);
r = pmc_send_ipc_cmd(cmd_reg, &req, &rsp);
if (r < 0 || rsp.buf[0] == 0) {
printk(BIOS_ERR, "%s: pmc_send_ipc_cmd failed or QDF not available.\n",
__func__);
return;
}
qdf_info[0] = ((rsp.buf[0] >> 24) & 0xFF);
qdf_info[1] = ((rsp.buf[0] >> 16) & 0xFF);
qdf_info[2] = ((rsp.buf[0] >> 8) & 0xFF);
qdf_info[3] = (rsp.buf[0] & 0xFF);
qdf_info[4] = '\0';
printk(BIOS_INFO, "SoC QDF: %s\n", qdf_info);
}