sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/x86/mpspec: reduce scope of smp_write_ioapic

Browse Source 
smp_write_ioapic is only called from smp_write_ioapic_from_hw within the
same compilation unit, so reduce its scope by making it a static
function.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6a1bbfd50ae9d6c8ab18f478ae9bae3f8bf5e10d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80357
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
Felix Held
2024-02-06 16:43:10 +01:00
parent 7608699a9e
commit 9c25a03fc3
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/arch/x86/include/arch/smp/mpspec.h
View File

@@ -225,8 +225,6 @@ void smp_write_processor(struct mp_config_table *mc,
u8 cpuflag, u32 cpufeature, u8 cpuflag, u32 cpufeature,
u32 featureflag); u32 featureflag);
void smp_write_processors(struct mp_config_table *mc); void smp_write_processors(struct mp_config_table *mc);
void smp_write_ioapic(struct mp_config_table *mc,
u8 id, u8 ver, void *apicaddr);
/* Call smp_write_ioapic() and return IOAPIC ID field. */ /* Call smp_write_ioapic() and return IOAPIC ID field. */
u8 smp_write_ioapic_from_hw(struct mp_config_table *mc, void *apicaddr); u8 smp_write_ioapic_from_hw(struct mp_config_table *mc, void *apicaddr);

2
src/arch/x86/mpspec.c
View File

@@ -206,7 +206,7 @@ static void smp_write_bus(struct mp_config_table *mc,
* Entry Type, APIC ID, Version, * Entry Type, APIC ID, Version,
* APIC Flags:EN, Address * APIC Flags:EN, Address
*/ */
void smp_write_ioapic(struct mp_config_table *mc, static void smp_write_ioapic(struct mp_config_table *mc,
u8 id, u8 ver, void *apicaddr) u8 id, u8 ver, void *apicaddr)
{ {
struct mpc_config_ioapic *mpc; struct mpc_config_ioapic *mpc;