sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/psp_smm: add/improve comments to buffers and flags

Browse Source 
Since it's not exactly obvious what 'c2p_buffer', 'p2c_buffer' and
'smm_flag' are used for, add comments to those.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I4ec092a92fe9f0686ffb7103e441802fc05381f4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83698
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
This commit is contained in:
Felix Held
2024-07-30 15:08:48 +02:00
parent ad8d0eff74
commit 9c366417df
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/soc/amd/common/block/psp/psp_smm.c
View File

@@ -14,15 +14,28 @@
#define C2P_BUFFER_MAXSIZE 0xc00 /* Core-to-PSP buffer */
#define P2C_BUFFER_MAXSIZE 0xc00 /* PSP-to-core buffer */
/*
* When sending PSP mailbox commands to the PSP from the SMI handler after the boot done
* command was sent, the corresponding data buffer needs to be placed in this core to PSP (C2P)
* buffer.
*/
struct {
u8 buffer[C2P_BUFFER_MAXSIZE];
} __aligned(32) c2p_buffer;
/*
* When the PSP sends mailbox commands to the host, it will update the PSP to core (P2C) buffer
* and then send an SMI to the host to process the request.
*/
struct {
u8 buffer[P2C_BUFFER_MAXSIZE];
} __aligned(32) p2c_buffer;
static uint32_t smm_flag; /* Non-zero for SMM, clear when not */
/*
* When sending PSP mailbox commands to the PSP from the SMI handler, the SMM flag needs to be
* set for the PSP to accept it. Otherwise it should be cleared.
*/
static uint32_t smm_flag;
static void set_smm_flag(void)
{