sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/ironlake/raminit: Work around compiler bug

Browse Source 
This fixes commit e1d1fe454cf27d6b1c2ef5625f1cefc1a9c6ec9d
initialize 'reply.command'.

The compiler now optimized away the final condition, that checks
the result of heci message, resulting in a binary that always
calls die().

Fix that behaviour by using volatile.
Tested on Lenovo T410: Boots again into Linux.

Change-Id: I63cffc8812bd22695c01bf57283ca593b12e3d87
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45174
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Patrick Rudolph 2020-09-08 17:23:04 +02:00 committed by Nico Huber
parent 292afef2fb
commit a1ef21301b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/northbridge/intel/ironlake/raminit.c
View File

@ -1770,7 +1770,7 @@ recv_heci_message(struct raminfo *info, u32 *message, u32 *message_size)
static void send_heci_uma_message(struct raminfo *info)
{
struct uma_reply {
volatile struct uma_reply {
u8 group_id;
u8 command;
u8 reserved;